75266 Commits

This Branch

This Branch

All Branches

• RankingsSort -> LeaderboardSortMode
  Dani211e · 2025-06-26 19:03:49 +02:00
  c1a34d8c6a
• Merge pull request #33615 from bdach/slider-encode-decode-instability

  Fix lack of slider encode-decode stability due to truncating control point coordinates on decode

  Dan Balasescu · 2025-06-26 23:25:36 +09:00
  ae3100af11
• Merge pull request #33858 from frenzibyte/multiplayer-match-link

  Add external link button to multiplayer/playlists room panels

  Dan Balasescu · 2025-06-26 23:16:05 +09:00
  bc07aba692
• Merge pull request #33883 from smoogipoo/add-test

  Add test hitting next circle during tail window

  Dan Balasescu · 2025-06-26 23:04:56 +09:00
  548b442507
• Add test coverage
  Salman Alshamrani · 2025-06-26 10:05:21 +03:00
  7a1c7fbd7d
• Add source grouping mode
  Salman Alshamrani · 2025-06-26 09:59:12 +03:00
  b4833d80d1
• Change GroupDefinition equality to be case insensitive
  Salman Alshamrani · 2025-06-26 09:58:30 +03:00
  e06e74d84e
• Support changing weight in text-based elements
  Salman Alshamrani · 2025-06-26 07:36:11 +03:00
  fa508245a1
• Add test coverage
  Salman Alshamrani · 2025-06-26 03:03:22 +03:00
  3ac557907e
• Simplify code and fix link not updating on changes to room ID
  Salman Alshamrani · 2025-06-26 03:03:22 +03:00
  8b67747735
• Move room URL formatting to extension method
  Salman Alshamrani · 2025-06-26 02:56:43 +03:00
  75a3cdcfe2
• Simplify important frame management
  Dan Balasescu · 2025-06-25 21:50:04 +09:00
  5dc08d4351
• Add test hitting next circle during tail window
  Dan Balasescu · 2025-06-25 21:20:00 +09:00
  5d69af55f0
• Merge pull request #33880 from bdach/user-tag-reorders

  Fix user tags moving in the control after voting

  Dean Herbert · 2025-06-25 20:55:21 +09:00
  5a01b76c35
• Uncomment & adjust relevant replay test cases

  The replay stability tests needed adjustments because hit windows have
  been materially changed with the previous commit. What matters in the
  replay stability tests is covering the time instants near the hit window
  edges and ensuring that re-encode doesn't mutate the resulting
  judgements, not what the particular numbers used are.

  Bartłomiej Dach · 2025-06-25 12:22:19 +02:00
  89c48451cd
• Merge pull request #33881 from smoogipoo/remove-dead-code

  Remove no longer used method

  Dan Balasescu · 2025-06-25 19:21:17 +09:00
  c80a63f328
• Apply flooring and half-millisecond-adjustments to hit windows

  This is a "two-birds-with-one-stone" change, which addresses both
  https://github.com/ppy/osu/issues/28744 and
  https://github.com/ppy/osu/issues/11311 simultaneously.
  
  - The replay stability issue caused by time instants being rounded to
    nearest integer is fixed by this, because flooring and
    subtracting/adding 0.5 from the hit window threshold makes it
    impossible for a judgement to switch to anything else after replay
    rounding is applied - all hit windows are always a full integer plus
    0.5 milliseconds, which immunizes them to rounding-to-full-ms issues.
  
  - The direction of applying the 0.5 adjustment additionally fixes the
    disparity with stable - in osu! and taiko 0.5 is subtracted as
    hit window ranges in those rulesets are exclusive on stable, while in
    mania 0.5 is added, as the hit window ranges there are *inclusive* on
    stable.
  
  As should be obvious, this materially changes hit windows. To what degree
  this is a *significant* change is up for discussion; I would say "no"
  since hitting half a millisecond changes would require 2000fps input
  recording, and we're still timestamping inputs using the update thread's
  clock, that gives a 1ms resolution at best.
  
  In the worst case, in osu! and taiko, this can change a hit window range
  by 1.5ms (e.g. 300.9ms -> floored to 300ms -> 299.5ms after subtraction
  of the half). It's more than the best-case resolution of input
  timestamps, but not by much. Considering how cleanly this resolves the
  issues in question, I see it as an acceptable tradeoff.

  Bartłomiej Dach · 2025-06-25 11:44:13 +02:00
  0f078ee550
• Merge pull request #33879 from peppy/selection-debounce-refactor

  Rewrite and add commentary to selection debounce logic

  Bartłomiej Dach · 2025-06-25 11:42:39 +02:00
  5c00985fa9
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Merge pull request #33875 from bdach/hitwindow-refactor

  Refactor hit windows class structure to reduce rigidity

  Dan Balasescu · 2025-06-25 18:22:01 +09:00
  09e31b7b01
• Fix user tags moving in the control after voting

  Closes https://github.com/ppy/osu/issues/33877.
  
  Most likely regressed when the user tags were changed such that the
  loading spinner that shows on adding/removing a vote was introdiced to
  every individual tag separately. This in turn means that the
  `LoadingLayer` responsible for showing the spinner also briefly consumes
  all input when visible, which also means that the control briefly
  becomes unhovered, breaking the logic.
  
  This probably doesn't work on mobile because mobile input sucks. On iOS
  simulator it looks somewhat fine in that the tags don't move until you
  touch the screen anywhere else which seems okay if that's what actually
  what happens on device as well. And if it isn't I'm not sure I can do
  anything sane about it anyway.

  Bartłomiej Dach · 2025-06-25 11:16:18 +02:00
  7975120d5d
• Merge pull request #33869 from smoogipoo/no-release-stream-dropdown-external

  Disallow changing release stream on fixed installs

  Dean Herbert · 2025-06-25 18:13:49 +09:00
  12df6e02a8
• Rename variable
  diquoks · 2025-06-25 12:04:04 +03:00
  3923b0a949
• Add failing test case
  Bartłomiej Dach · 2025-06-25 11:01:53 +02:00
  ee2a247c66
• Rewrite and add commentary to selection debounce logic

  Hopefully a bit easier to maintain going forward? Not sure.

  Dean Herbert · 2025-06-25 17:58:54 +09:00
  49a9652fa5
• Merge branch 'master' into keybinds-in-tips
  Denis Titovets · 2025-06-25 11:53:00 +03:00
  026b05b93c
• Fix default values and remove tips' array
  diquoks · 2025-06-25 11:52:33 +03:00
  8e228e17b7
• Fix code quality issue
  Dan Balasescu · 2025-06-25 17:41:04 +09:00
  a369061c15
• Merge pull request #33878 from bdach/leaderboard-ensure-correct-beatmap

  Ensure global leaderboard state matches beatmap when loading player

  Dean Herbert · 2025-06-25 17:39:05 +09:00
  d3296e0343
• Always show update button on mobile so section isn't empty
  Dean Herbert · 2025-06-25 17:35:57 +09:00
  e05c716d70
• Hide entire section on mobile instead
  Dan Balasescu · 2025-06-25 17:13:39 +09:00
  8fb8772282
• Make assertion completely dead in release mode
  Bartłomiej Dach · 2025-06-25 10:06:04 +02:00
  55ff5a744c
• Ensure global leaderboard state matches beatmap when loading player

  Closes https://github.com/ppy/osu/issues/33835.
  
  I love fixing issues multiple times.
  
  Notably the refetch is not forced so this should be a no-op if the
  global state is already correct.
  
  https://github.com/ppy/osu/issues/33835#issuecomment-2998897932 says
  
  > but we should also consider adding a force `RunTask` of the pending debounce before entering gameplay, probably around here:
  >
  > https://github.com/ppy/osu/blob/3192eaa2a20f20495db8431d3d6f35af7c705a94/osu.Game/Screens/SelectV2/SongSelect.cs#L420
  
  but I am not confident in making that change as I have no idea whether
  it is correct or not.

  Bartłomiej Dach · 2025-06-25 09:54:05 +02:00
  dee4ede306
• Merge pull request #33612 from bdach/stable-scores-with-zero-legacy-id

  Fix stable scores importing with a `LegacyOnlineID` of 0

  Dean Herbert · 2025-06-25 16:50:45 +09:00
  4b665842fb
• Add failing test
  Bartłomiej Dach · 2025-06-25 09:47:53 +02:00
  57bfb37888
• Fix flaky carousel test due to out of range async filter operation

  See
  https://github.com/ppy/osu/actions/runs/15868654672/job/44740248052?pr=33873#step:5:49.

  Dean Herbert · 2025-06-25 15:45:41 +09:00
  2025.625.0-tachyon f1e23595e7
• Merge pull request #33873 from peppy/update-framework

  Update framework

  Dean Herbert · 2025-06-25 15:45:38 +09:00
  678132d64b
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Update framework

  Update framework

  Dean Herbert · 2025-06-25 15:04:23 +09:00
  9febf635f3
• Move room name line to own component

  Fixes test failure caused by accessing components loaded asynchronously,
  see
  https://github.com/ppy/osu/actions/runs/15848940420/job/44677458262?pr=33858.

  Salman Alshamrani · 2025-06-25 08:24:04 +03:00
  d888572f7f
• Fix incorrect localisation keys
  Dan Balasescu · 2025-06-25 12:16:53 +09:00
  37df9c5a48
• Support release streams in MobileUpdateNotifier
  Dan Balasescu · 2025-06-25 12:04:56 +09:00
  c52c82ae8a
• Disallow changing release stream on fixed installs

  For package-managed solutions that set `OSU_EXTERNAL_UPDATE_STREAM`
  (which overrides the config value), we should not allow the user to
  change the release stream themselves.

  Dan Balasescu · 2025-06-25 12:04:33 +09:00
  bb15df1ba5
• Add basic test scene
  Dani211e · 2025-06-25 05:01:40 +02:00
  3e615d4192
• Persist sorting between results screen and song select
  Dani211e · 2025-06-25 05:01:40 +02:00
  d04094a2c4
• Add sorting dropdown

  Only use sorting when on local scope otherwise hide

  Dani211e · 2025-06-25 05:01:40 +02:00
  ad35dad46d
• Merge pull request #33621 from minetoblend/somewhat-less-weird-toolbar

  Maintain scroll position relative to hovered drawable when editor toolbox expands

  Dan Balasescu · 2025-06-25 08:21:38 +09:00
  c5ce191ceb
• Merge branch 'ppy:master' into ssv2-localisation
  Denis Titovets · 2025-06-24 19:16:27 +03:00
  f3b4f16ca6
• Add custom keybinds to tips in Main menu
  diquoks · 2025-06-24 19:15:02 +03:00
  eaadd507d3
• Merge pull request #33773 from peppy/fix-carousel-random-not-respecting-group

  SongSelectV2: Refine random selection to currently open group (and support difficulty split panels better)

  Bartłomiej Dach · 2025-06-24 14:37:09 +02:00
  a797c46d75