osu-lazer

Adjust song select spatial division one more time

Dean Herbert · 2025-07-17 11:42:59 +09:00

dd5925d119

Merge pull request #33759 from frenzibyte/noto-bopomofo

Add Bopomofo characters

Dean Herbert · 2025-07-16 19:08:06 +09:00

451d3cf8c9

Merge branch 'master' into noto-bopomofo

Dean Herbert · 2025-07-16 18:41:01 +09:00

d74b2444e0

Merge branch 'ppy:master' into ssv2-localisation

Denis Titovets · 2025-07-16 11:59:47 +03:00

021ef6d727

Merge pull request #30506 from smoogipoo/mania-key-mod-multiplier

Add default multiplier for mania key mods

Dean Herbert · 2025-07-16 17:20:30 +09:00

7e373f6410

Fix typo

Co-authored-by: De4n <55669793+tadatomix@users.noreply.github.com>

Bartłomiej Dach · 2025-07-16 08:31:58 +02:00

482a0f0856

Merge pull request #34239 from Joehuu/fix-renderer-restart

Fix game not restarting after changing renderers

Dan Balasescu · 2025-07-16 15:26:06 +09:00

9694eef970

Merge pull request #34227 from bdach/display-weird-numbers-for-mania-so-that-people-stop-complaining

Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

Dean Herbert · 2025-07-16 14:35:32 +09:00

d539c4b97f

Fix game not restarting after changing renderers

Joseph Madamba · 2025-07-15 22:20:30 -07:00

2a6137863b

fix ci

Hivie · 2025-07-16 02:08:07 +01:00

83ad34b718

address review

- add TODO for refactoring verifier context ctor
- call `GetPlayableBeatmap()` in verifier context ctor
- filter diffs with relevant ruleset in check logic
- fix tests

Hivie · 2025-07-16 01:53:22 +01:00

747bff1df9

Merge pull request #34232 from bdach/android-stream-versioning

Fix android builds losing awareness of their release stream

Dan Balasescu · 2025-07-16 01:04:24 +09:00

2025.715.0-tachyon 2a15ffdb6c

Revert "Remove duplicated string" and move string to CollectionsStrings

Denis Titovets · 2025-07-15 16:33:58 +03:00

57c3be4e0a

Fix tests

Bartłomiej Dach · 2025-07-15 14:30:30 +02:00

02d54e5a38

Remove duplicated string

Bartłomiej Dach · 2025-07-15 13:35:09 +02:00

d0d76d38e6

Use better name for string

Bartłomiej Dach · 2025-07-15 13:34:56 +02:00

3eb52e7771

Fix android builds losing awareness of their release stream

Bartłomiej Dach · 2025-07-15 12:37:09 +02:00

2890a19a85

Fix code quality

Bartłomiej Dach · 2025-07-15 11:35:25 +02:00

6ad9714318

Fix TagsLine arbitrarily changing how it performs search in the popover

So much passing of the `linkAction` to only then give up halfway through
and reimplement it locally again down in the overflow popover.

This materially matters now because mapper tags are searched as plain
words and user tags are searched using the `tag=""!` syntax.

Bartłomiej Dach · 2025-07-15 11:10:34 +02:00

6d8d5bdd00

Add initial support for filtering by user tags in song select

The way that this works is that it plugs into the online request to
retrieve the beatmap set that the client is already performing, and
stores user tag data to the local realm database.

This means that for now user tags will only populate for beatmaps that
the user has displayed on song select which is obviously subpar. I plan
to follow this change up by adding user tag state dumps to `online.db`
and using that data for initial tag population to make the majority case
(ranked beatmaps) work.

Note that several decisions were made here that are potential discussion
points:

- `RealmPopulatingOnlineLookupSource` is set up such that it can be the
  middle man / redirection point for similar flows that we need and we
  are currently missing, such as storing guest difficulty information,
  or storing the user's current best score on a beatmap (handy for rank
  achieved sorting / filtering / etc.)

- The user tags are stored in `BeatmapMetadata` which breaks the
  longstanding assumption that you can arbitrarily pull out a metadata
  instance from any of the beatmaps in a set and get essentially the
  same object back.

  I've attempted to constrain this some by not adding user tags to
  the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
  exposes metadata further, but I warn in advance that this is
  a temporary state of affairs and I will make it worse in the future
  when `BeatmapMetadata.Author` becomes `Authors` plural in order to
  support guest mapper display (and direct guest difficulty submission).

- The syntax for searching via user tags is chosen to mostly match web -
  it's `tag=`, with support for all of the string matching modes song
  select already has (bare word for substring, `""` quotes for phrase
  isolated by whitespace, `""!` for exact full match).

Bartłomiej Dach · 2025-07-15 11:09:40 +02:00

8cb81974eb

Update framework

Dean Herbert · 2025-07-15 17:01:11 +09:00

66a4cb5931

Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

In stable mania, Hard Rock and Easy mods do not work the same way as
they do on all of the rulesets. The difference is that mania HR and EZ,
rather than apply a multiplier to the map's original Overall Difficulty,
apply multipliers to *the durations of hit windows themselves*.

Prior to the last release, lazer was oblivious to this reality and just
treated mania HR / EZ as it did every other ruleset. Last release, for
the sake for gameplay parity across rulesets, the mods in question were
adjusted to match stable, but in the process, it started looking like HR
/ EZ did not change OD anymore.

The problem is that they do, but applying a multiplier to the map's OD
and applying a multiplier to the hit window duration is not the same
thing. The second thing is actually *much harsher* in magnitude, to the
point where applying HR to any map is almost guaranteed to exceed "the
effective OD" of 10, and applying EZ to any map is almost guaranteed to
result in "negative effective OD".

This change attempts to convey that reality by displaying "effective
OD", similar to what's already done in other rulesets when rate-changing
mods are active. Note that the values this will display *do not match*
stable *and that is correct*, because stable song select *lies* about
the actual impact on OD by just assuming it can treat all rulesets in
the same way.

---

Would close https://github.com/ppy/osu/issues/34150 I guess.

And yes I would like *all of the above* to land on the changelog if
possible if this is merged.

For further convincing that this makes any semblance of sense please see
the following: https://www.desmos.com/calculator/yigt7jycdv

Bartłomiej Dach · 2025-07-15 09:40:55 +02:00

131f828e6a

Merge pull request #34209 from smoogipoo/playlist-results-no-submission-no-indexing

Make online play results not request leaderboard on failed submission

Bartłomiej Dach · 2025-07-15 07:54:41 +02:00

0d1788e7f1

Merge pull request #34205 from bdach/skin-external-edit-safety

Improve safety of external skin edit operation in several scenarios

Dean Herbert · 2025-07-15 14:42:32 +09:00

f5a97e945b

Add safeguard against skin resources getting left in place on game exit

Dean Herbert · 2025-07-15 14:03:02 +09:00

0d58b2d53a

Merge pull request #34225 from smoogipoo/fix-release-stream-reset

Write only fixed release streams back to config

Dean Herbert · 2025-07-15 14:01:57 +09:00

9dc9ec3594

Merge pull request #34221 from smoogipoo/debug-settings

Bring back minimal debug settings

Dean Herbert · 2025-07-15 14:01:43 +09:00

e7beafdb2d

Log changes to latency mode

Dan Balasescu · 2025-07-15 13:44:58 +09:00

985241c63e

Hide entire general section

Dan Balasescu · 2025-07-15 13:44:49 +09:00

a80a9bbfd1

Centralise logging of non-official builds

Dan Balasescu · 2025-07-15 13:19:00 +09:00

35a3186bf0

Write only fixed release streams back to config

Dan Balasescu · 2025-07-15 13:18:56 +09:00

55befe9efb

Add failing test

Dan Balasescu · 2025-07-15 13:03:35 +09:00

27f93d56a0

Add GC mode dropdown

Dan Balasescu · 2025-07-15 11:07:39 +09:00

1c243b25b2

Clear caches as aggressively as possible

Dan Balasescu · 2025-07-15 10:38:45 +09:00

adc054f08e

Re-enable debug settings

Dan Balasescu · 2025-07-15 10:24:14 +09:00

c59447c407

Fix flaky playlists navigation test

See: https://github.com/ppy/osu/actions/runs/16267403227/job/45929099025

Repro:

```diff
diff --git a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
index a4e808ff76..db0a0e83a6 100644
--- a/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
+++ b/osu.Game/Screens/OnlinePlay/Lounge/LoungeSubScreen.cs
@@ -88,6 +88,7 @@ public abstract partial class LoungeSubScreen : OnlinePlaySubScreen, IOnlinePlay
         [BackgroundDependencyLoader(true)]
         private void load()
         {
+            System.Threading.Thread.Sleep(1000);
             Masking = true;

             const float controls_area_height = 25f;

```

Dan Balasescu · 2025-07-14 22:41:08 +09:00

3a3c1c4e09

Merge pull request #34169 from EYHN/eyhn/fix/deleted-user-map

Fix failed to load beatmap detail host by deleted user

Dan Balasescu · 2025-07-14 22:33:07 +09:00

e43ccb99d0

Merge pull request #34206 from smoogipoo/improve-user-style-selection

Improve user style selection UX based on local beatmap state

Bartłomiej Dach · 2025-07-14 15:02:23 +02:00

cb3cfd828c

Adjust behavior of beatmap set with deleted author

eyhn · 2025-07-14 20:58:03 +08:00

3eca3897ed

unlazy BeatmapsetDifficulties

Hivie · 2025-07-14 13:53:01 +01:00

806995e951

Use more descriptive test step name

Bartłomiej Dach · 2025-07-14 14:47:33 +02:00

9cc5fab383

Re-privatise PlaylistItem.Beatmap, adjust tests

Dan Balasescu · 2025-07-14 21:19:20 +09:00

13fc37b2de

Refactor order of operations

Dan Balasescu · 2025-07-14 21:16:15 +09:00

bd922e2888

Change failing test to use until step instead

Bartłomiej Dach · 2025-07-14 13:51:46 +02:00

fc44301713

Make online play results not request leaderboard on failed submission

Dan Balasescu · 2025-07-14 20:31:22 +09:00

5a45586455

Add failing test

Dan Balasescu · 2025-07-14 20:30:15 +09:00

fd776c58ad

Merge pull request #34175 from FluffyOMC/duration-multiplayer

Fix multiplayer duration by having it set on beatmap population.

Dan Balasescu · 2025-07-14 18:59:05 +09:00

8e79ab6c04

Merge pull request #34127 from bdach/idk

Fix text flow arbitrary drawable wrapper accessing child in an unsafe manner

Dan Balasescu · 2025-07-14 18:30:36 +09:00

6389095639

Move variables local

Dan Balasescu · 2025-07-14 18:16:43 +09:00

bcf087346b

Exit user style selection when beatmap set changes

Dan Balasescu · 2025-07-14 18:02:18 +09:00

3401706e7e

75266 Commits