48098 Commits

• Merge pull request #33307 from peppy/song-select-v2-fix-incorrect-split-out-conditional

  SongSelectV2: Fix incorrect conditional being used for "split out" check

  Bartłomiej Dach · 2025-05-29 09:21:24 +02:00
  6a7e9b9375
• Add check to see if MouseUp event was the left button
  Chris Ehmann · 2025-05-28 17:02:18 -07:00
  13ace770ae
• SongSelectV2: Select random instead of fixed item when recovering from no selection
  Dean Herbert · 2025-05-29 01:53:10 +09:00
  b4a6803236
• Fix multiple issues causing song select to retain a deleted or hidden selection
  Dean Herbert · 2025-05-29 01:53:10 +09:00
  8f18336b2c
• SongSelectV2: Fix incorrect conditional being used for "split out" check

  🤦
  
  Have inlined the v1 usage so we don't accidentally do this again.

  Dean Herbert · 2025-05-29 01:22:22 +09:00
  ef8fd7b5d7
• SongSelectV2: Fix filtering all results away nuking user's selection
  Dean Herbert · 2025-05-29 00:44:48 +09:00
  5d5a569523
• Merge pull request #33306 from peppy/song-select-v2-select-single-result

  SongSelectV2: If only one results is visible after filter, select it automatically

  Bartłomiej Dach · 2025-05-28 14:05:33 +02:00
  f1b6814ff3
• Merge branch 'master' into song-select-v2-fix-loading-overlay
  Bartłomiej Dach · 2025-05-28 13:16:30 +02:00
  bbeb1be295
• SongSelectV2: If only one results is visible after filter, select it automatically
  Dean Herbert · 2025-05-28 20:07:44 +09:00
  731a4968f5
• Merge branch 'master' into song-select-v2-random
  Dean Herbert · 2025-05-28 20:06:50 +09:00
  0b527ce14b
• Merge pull request #33301 from peppy/remember-group-expansion

  SongSelectV2: Fix expanded group not being persisted over filter operations

  Bartłomiej Dach · 2025-05-28 12:55:23 +02:00
  d9d74696df
• Merge pull request #33303 from bdach/song-select-v2-holding-traversal-resets-to-start-end

  SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low

  Dean Herbert · 2025-05-28 19:39:18 +09:00
  13f0f6d7bf
• Prevent random selection from selecting hidden beatmaps
  Bartłomiej Dach · 2025-05-28 12:22:09 +02:00
  db7c6fa850
• Fix difficulty grouping not working with random
  Dean Herbert · 2025-05-28 12:14:27 +02:00
  dca839211c
• SongSelectV2: Fix holding beatmap carousel previous / next traversal actions resetting position to start / end when update frame rate is low
  Bartłomiej Dach · 2025-05-28 11:45:59 +02:00
  c56c7b7239
• SongSelectV2: Fix carousel loading state looking out of place
  Dean Herbert · 2025-05-28 18:31:37 +09:00
  7a4d9c7c9a
• SongSelectV2: Fix expanded group not being persisted over filter operations
  Dean Herbert · 2025-05-28 18:15:40 +09:00
  df66bab31f
• Rename and expose BeatmapCarousel selection handling variables

  For test usage and consistency.

  Dean Herbert · 2025-05-28 18:15:39 +09:00
  ef39b8d9c0
• SongSelectV2: Fix group panels being recreated every filter

  This also allows *all* panels to be re-used based on equality, as
  originally intended. Beatmap updates should be handled correctly without
  a full (flashing) recreation of panels now.

  Dean Herbert · 2025-05-28 17:46:14 +09:00
  c2bd4a9827
• SongSelectV2: Fix status pill still animating on stand-alone panels

  Addresses
  https://github.com/ppy/osu/issues/32736#issuecomment-2911264829.

  Dean Herbert · 2025-05-28 16:57:11 +09:00
  e2af0654b8
• Set random beatmap on entering song select
  Dean Herbert · 2025-05-28 16:54:11 +09:00
  f602bdeb2f
• SongSelectV2: Add back basic random selection support

  This is a minimal implementation in order to keep moving forward.
  
  For simplicity I've copied over the old implementation verbatim. Note
  that this is beatmap*set* based randomisation, which means that when
  panels are split up by difficulty, it is still randomising by set (with
  the difficulty choice being left up to the user recommendation system).
  I think this is what we want, but if it isn't, any changes can come
  later.

  Dean Herbert · 2025-05-28 16:54:11 +09:00
  1b56ce9a39
• Merge pull request #33288 from peppy/song-select-v2-sounds

  SongSelectV2: Add back missing song select sound effects

  Bartłomiej Dach · 2025-05-28 08:08:17 +02:00
  7926a26b0b
• remove grouping by date submitted to reduce clutter

  i doubt it would get much use anyway

  WitherFlower · 2025-05-27 21:09:24 +02:00
  80664d9b92
• reverse group order
  WitherFlower · 2025-05-27 20:35:07 +02:00
  e2db76897e
• add grouping support for ranked and submitted date
  WitherFlower · 2025-05-27 18:49:59 +02:00
  e6f933c1c0
• Use global sample debounce period
  Dean Herbert · 2025-05-27 22:57:22 +09:00
  cc6c274d98
• Mode BDL method to proper region
  Dean Herbert · 2025-05-27 22:55:49 +09:00
  5ad1e05861
• Finalise selection before entering edit / play modes
  Dean Herbert · 2025-05-27 19:33:12 +09:00
  533e0513ad
• Add support for presenting beatmaps at song select v2
  Dean Herbert · 2025-05-27 19:33:11 +09:00
  7290f912d9
• Merge pull request #33287 from peppy/fix-selection

  SongSelectV2: Fix carousel not correctly handling traversal when current selection is filtered away

  Bartłomiej Dach · 2025-05-27 12:33:04 +02:00
  e5ba517f9c
• Add back beatmap carousel sound effects
  Dean Herbert · 2025-05-27 19:10:02 +09:00
  b01b0daf70
• Add back sound effect when entering gameplay
  Dean Herbert · 2025-05-27 18:42:06 +09:00
  33dd310f79
• Fix carousel not correctly handling traversal when current selection is filtered away

  Closes https://github.com/ppy/osu/issues/33215.

  Dean Herbert · 2025-05-27 18:32:56 +09:00
  046db53857
• Merge pull request #33285 from peppy/change-statistics-order

  SongSelectV2: Change difficulty information order to match stable

  Bartłomiej Dach · 2025-05-27 11:27:04 +02:00
  423a92b27c
• Merge pull request #33284 from peppy/fix-filter-performance-shit

  Fix filtering performance being abysmal due to implementation failure

  Bartłomiej Dach · 2025-05-27 11:18:30 +02:00
  5afe81532d
• Merge pull request #33281 from peppy/fix-switching-difficulty-split-modes

  Fix panels not updating visually when changing between difficulty sort modes

  Bartłomiej Dach · 2025-05-27 10:59:44 +02:00
  790a2f8f37
• Merge pull request #33279 from peppy/song-select-v2-reset-scroll

  SongSelectV2: Scroll to selection when mouse moves to left area

  Bartłomiej Dach · 2025-05-27 10:50:12 +02:00
  f34980ba54
• SongSelectV2: Change difficulty information order to match stable

  Addresses concerns at https://github.com/ppy/osu/discussions/33282.

  Dean Herbert · 2025-05-27 17:30:11 +09:00
  af7b5897e0
• Fix panels not updating visually when changing between difficulty sort modes

  I'm going with the simplest approach for this for now. If there's a
  discrepancy, clear all panels and start from scratch.
  
  Closes #33204.

  Dean Herbert · 2025-05-27 17:21:15 +09:00
  907d680188
• Fix filtering performance being abysmal due to implementation failure

  I only briefly skimmed this code during implementation becuse I assumed
  it was doing what was already proven in old song select.
  
  Turns out it was not. And it was iterating and LINQing its way to death
  (multiple seconds for <1000 beatmaps).

  Dean Herbert · 2025-05-27 17:00:10 +09:00
  d9c1d1b127
• Add inline comment explaining depth adjustment
  Dean Herbert · 2025-05-27 16:24:28 +09:00
  cc206fad11
• Merge pull request #33268 from peppy/song-select-v2-logo-fix

  SongSelectV2: Fix multiple issues with osu! logo animations

  Bartłomiej Dach · 2025-05-27 09:00:59 +02:00
  fb5a8a2454
• Add reset scroll support when moving cursour out of carousel
  Dean Herbert · 2025-05-27 15:53:32 +09:00
  32044d745a
• Expose ability to scroll to selected in Carousel (and handle screen-wide input to allow scrolling outside of bounds)
  Dean Herbert · 2025-05-27 15:53:32 +09:00
  a50ee3b3d2
• Merge pull request #33277 from peppy/fix-score-scroll-animation

  Fix leaderboard wedge transition looking bad when user is scrolled down

  Bartłomiej Dach · 2025-05-27 08:42:07 +02:00
  1b70722333
• Merge pull request #33274 from peppy/fix-context-panels

  Fix context menus not showing for standalone panels

  Bartłomiej Dach · 2025-05-27 08:32:31 +02:00
  3962521433
• Fix leaderboard wedge transition looking bad when user is scrolled down

  Closes https://github.com/ppy/osu/issues/33227.

  Dean Herbert · 2025-05-27 14:39:25 +09:00
  070b0c0e7f
• Merge pull request #33266 from bdach/score-correct-processing-status

  Fix profile score display logic not matching website

  Dean Herbert · 2025-05-27 13:47:52 +09:00
  900cef8f20
• Adjust selected panel visuals to look better on standalone panels
  Dean Herbert · 2025-05-27 12:36:01 +09:00
  bf22160098