48098 Commits

• Fix context menus not showing for standalone panels

  Closes https://github.com/ppy/osu/issues/33270.

  Dean Herbert · 2025-05-27 12:30:36 +09:00
  b7d862d63d
• Fix logo animations being interrupted incorrectly
  Dean Herbert · 2025-05-27 02:19:50 +09:00
  eea5a2f893
• Fix logo transitions with song select v2
  Dean Herbert · 2025-05-27 02:19:50 +09:00
  68d557b4ad
• Simplify logo tracking logic since we never have more than one logo
  Dean Herbert · 2025-05-27 02:18:25 +09:00
  4335b51edc
• Add missing current screen check

  I don't understand why stuff that was present in v1 wasn't carried
  across to v2 rather than waiting until stuff breaks a second time to fix
  it.

  Dean Herbert · 2025-05-27 02:16:56 +09:00
  d765b7e233
• Add comments around convoluted code that needs to be refactored
  Dean Herbert · 2025-05-27 02:16:48 +09:00
  b3ed1729c2
• Remove unused dependency
  Dean Herbert · 2025-05-27 02:11:43 +09:00
  e1334868e8
• Fix mod and beatmap options toggle keys not working
  Dean Herbert · 2025-05-27 01:44:06 +09:00
  bb6bdec361
• Fix backgroud blur getting stuck when returning to song select v2
  Dean Herbert · 2025-05-27 01:44:01 +09:00
  daaa90d902
• Fix placeholder animation flickering to wrong position for one frame
  Dean Herbert · 2025-05-27 00:33:25 +09:00
  be55cadc95
• Merge pull request #33241 from bdach/participant-list-transform-spam

  Implement list virtualisation in multiplayer participants list

  Dean Herbert · 2025-05-26 23:58:27 +09:00
  7cc89dfd4e
• Merge pull request #33264 from peppy/song-select-v2-hookup

  SongSelectV2: Hook up screen to carousel and move selection logic up one level

  Dean Herbert · 2025-05-26 23:49:54 +09:00
  dc09d170f3
• Merge pull request #33259 from LumpBloom7/ruleset-agnostic-concurrent-check

  Make concurrent object check ruleset specific

  Bartłomiej Dach · 2025-05-26 14:33:41 +02:00
  f043a95dbd
• Merge branch 'master' into song-select-v2-hookup
  Bartłomiej Dach · 2025-05-26 14:09:05 +02:00
  590194b525
• Fix grammar in comment
  Bartłomiej Dach · 2025-05-26 14:08:56 +02:00
  72bd8b2203
• Add TODO marking incompatible logic

  Chances are this will not be materially noticed anyway because I'm not
  even sure that unranked mod scores *can* show up on leaderboards.

  Bartłomiej Dach · 2025-05-26 13:22:18 +02:00
  bedac98e06
• Fix profile score display logic not matching website

  Reported via e-mails.
  
  The web-side change that wasn't ported here is
  https://github.com/ppy/osu-web/pull/11151. I wanted to port it at the
  time but then ran into issues because this logic should *ideally* also
  be applied to the beatmap set overlay leaderboards, but those are
  hard-glued to `ScoreInfo`, cannot be easily weaned off it to use
  `SoloScoreInfo` instead, and I did not want to make `ScoreInfo` even
  more of a mess than it already is.
  
  This time I'm just ignoring it and adding a TODO instead because I have
  no confidence I will get review eyes on any refactor of the beatmap set
  overlay. All I'll say that such refactors would have potentially
  beneficial effects on results screens too which also (ab)use
  `ScoreInfo`.

  Bartłomiej Dach · 2025-05-26 13:11:41 +02:00
  90bc8865c9
• Ensure protected beatmap is reselected on entering screen
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  5212c27a71
• Fix beatmap background not being used at new song select
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  d0a1b40a84
• Add basic "eager" selection to ensure something is selected at song select after import
  Dean Herbert · 2025-05-26 19:32:32 +09:00
  4a03240ee6
• Hook up carousel to song select to global beatmap
  Dean Herbert · 2025-05-26 19:32:31 +09:00
  c1e1bfde0a
• Fix BeatmapSetInfo missing GetHashCode implentation

  Causing dictionary lookups to fail when expecting equality
  implementation to work.

  Dean Herbert · 2025-05-26 19:32:31 +09:00
  f3782acddd
• Add even more logging to beatmap submission process

  Every now and again someone will report having done something horrible
  to their beatmap via lazer submission, always claim having done
  "nothing" while invariably having done *something*, will not provide me
  with a workable reproduction scenario, and even if they attempt to do
  so, I will be unable to reproduce the issue anyway. So this change is
  just desperation mostly. It's logging pretty much all that it is
  possible to log of client-side state.

  Bartłomiej Dach · 2025-05-26 11:33:59 +02:00
  c7404cb81d
• Make CheckConcurrentObjects.Run virtual

  And let implementers copy-paste common code.

  Derrick Timmermans · 2025-05-26 10:59:57 +02:00
  0495a03607
• Rename ConcurrentCondition to ConcurrencyPrecondition

  Better describes the intent of the method.

  Derrick Timmermans · 2025-05-26 10:59:17 +02:00
  257767b311
• Use null coalesce wherever possible

  Rider EAP being noisy about this one now.

  Dean Herbert · 2025-05-26 17:15:35 +09:00
  5450298468
• Remove redundant public specfications in interfaces

  Rider EAP being noisy about this now (smoogi will be happy :D).

  Dean Herbert · 2025-05-26 17:14:41 +09:00
  cb0592d711
• Apply review suggestions
  Bartłomiej Dach · 2025-05-26 09:57:37 +02:00
  ea8ad6b637
• Merge pull request #33256 from peppy/beatmap-title-wedge-fixes

  SongSelectV2: Change beatmap title wedge to use debounced difficulty retrieval

  Dean Herbert · 2025-05-26 16:12:30 +09:00
  5af3921dde
• Adjust BeatmapMetadataDisplay to account for stars always being available now
  Dean Herbert · 2025-05-26 15:34:32 +09:00
  ed51f2345a
• Use more consistent ordering between beatmap & beatmapset panels
  Bartłomiej Dach · 2025-05-26 07:54:25 +02:00
  2d9cc382c8
• Merge branch 'master' into song-select-v2-context-menus
  Bartłomiej Dach · 2025-05-26 07:45:02 +02:00
  c6954fd55d
• Change BeatmapTitleWedge to use debounced bindable rather than custom flow
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  19f8096dc9
• Make BeatmapDifficultyCache's returned bindable non-nullable
  Dean Herbert · 2025-05-25 22:27:37 +09:00
  6500be3f2d
• Make CheckConcurrentObject ruleset specific
  Derrick Timmermans · 2025-05-25 14:19:23 +02:00
  0065696248
• Improve general code quality of beatmap title wedge's difficulty stats updating
  Dean Herbert · 2025-05-25 20:42:13 +09:00
  4e29c59be4
• Fix mod change tracker not being hooked up if mods are present on load
  Dean Herbert · 2025-05-25 20:42:13 +09:00
  bd71c2ce52
• Add back missing using statement
  Dean Herbert · 2025-05-25 20:41:36 +09:00
  48fe2a6723
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Add back two missing actions for beatmap set headers
  Dean Herbert · 2025-05-24 11:28:12 +09:00
  a1426eb8be
• Remove obsoleted flow by using a new configuration variable

  The old one wasn't used anyway.

  Dean Herbert · 2025-05-24 01:01:17 +09:00
  cd44cab3ff
• Handle star difficulty grouping in a way which doesn't require arbitrary nullable data
  Dean Herbert · 2025-05-23 19:49:24 +09:00
  dc519441f9
• Fix weird todo comments..
  Dean Herbert · 2025-05-23 19:43:05 +09:00
  6555e45367
• Fix typo in comment
  Dean Herbert · 2025-05-23 19:37:22 +09:00
  ff48c4a047
• Merge branch 'master' into carousel-grouping
  Dean Herbert · 2025-05-23 19:03:09 +09:00
  0a5fbb35c5
• Fix nasty bug associated with reusing a single panel wrong
  Bartłomiej Dach · 2025-05-23 11:45:25 +02:00
  9742f48437
• Refactor team display to fit with pooling better
  Bartłomiej Dach · 2025-05-23 10:47:36 +02:00
  17cf5df668
• Implement pooling in multiplayer participants list
  Bartłomiej Dach · 2025-05-23 10:47:07 +02:00
  61e8c25a92
• Merge pull request #33209 from bdach/mania-combo-accounting-rewind

  Fix combo accounting when rewinding mania replays

  Dean Herbert · 2025-05-23 16:47:36 +09:00
  fa92fbb9d1
• Add context menus to new carousel panels

  This changes the flow of actions (yet again.. sorry) to standardise what
  is shown on the beatmap options button in the footer and the context
  menus.
  
  This is something I wanted from the start – for devices where right
  click is not available, it's always preferable to have a second method
  of accessing actions which isn't the context menu.
  
  Collection actions are missing for now, as they will come in a second
  pass which includes tidying things up further.
  
  Fix formatting
  
  Duplicate menu items between implementations

  Dean Herbert · 2025-05-23 16:02:13 +09:00
  891f0c469f