106 Commits

• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Move "attribute adjusted" tooltips to individual attribute displays

  Pre-requisite for displaying additional information regarding the impact
  of particular attributes on various beatmap metrics.

  Bartłomiej Dach · 2025-08-01 11:05:54 +02:00
  cb73717a34
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Fix test
  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  1319a5499b
• Migrate other usages of GetAdjustedDisplayDifficulty() to use GetBeatmapAttributesForDisplay() instead

  This ensures parity between all beatmap attribute displays that used the
  former method.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  a952e3704e
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• Use floored star rating in BeatmapCarouselFilterGrouping and AdvancedStats

  This commit changes BeatmapCarouselFilterGrouping to now use floored star
  rating when determining which group a beatmap belongs to,
  to be consistent with changes introduced here:
  https://github.com/ppy/osu/pull/33679.
  The AdvancedStats section of the original song select is also
  updated to show the floored star rating (rather than rounded).

  Chris Ehmann · 2025-06-30 19:50:11 -07:00
  32d478e19c
• Decouple AdvancedStats from global mods

  Closes https://github.com/ppy/osu/issues/30163.
  
  If I'm to be blunt, the decoupled stuff in song select makes my head
  spin. I spent a solid 20 minutes thinking how I was going to fix this
  one but then finally realised that generally most of the cause there
  was the fact that `AdvancedStats` was seeing the new rulesets *before*
  the "ensure global selected mods are valid for current ruleset" logic,
  and so decided to just _delay_ that until the decoupled transfer
  thingamajig happens.
  
  I was honestly considering combining `BeatmapInfo`, `Ruleset`, and
  `Mods` into one property on `AdvancedStats`. I figured I'd rather not
  push my luck and try the baseline version first, but I honestly think
  that direction is going to be required at some point to properly corral
  all of the decoupled madness taking place in song select.

  Bartłomiej Dach · 2024-10-10 14:22:16 +02:00
  f1842d781e
• Creating method in ModUtils to calculate the rate for the song
  Xesquim · 2024-06-06 10:06:07 -03:00
  860afb8123
• Add ability to query key count with mods
  Dan Balasescu · 2024-03-28 22:51:12 +09:00
  10edb54614
• Add xmldoc explaining Ruleset bindable's usage
  Dean Herbert · 2024-02-26 18:31:40 +08:00
  8e336610d0
• Fix advanced stats in beatmap info overlay showing "key count" on non-mania beatmaps
  Salman Ahmed · 2024-02-25 21:18:15 +03:00
  5c049feca1
• Apply proposed changes
  Dean Herbert · 2023-12-20 12:42:06 +09:00
  85e5d74a16
• Tidy up visual look
  Dean Herbert · 2023-12-19 19:28:02 +09:00
  3b848e8503
• Add support for dual-column advanced stats
  Dean Herbert · 2023-12-19 19:09:47 +09:00
  0a64d631e2
• Fix AdjustedAttributesTooltip being broken by design

  Fixes issue described in the following comment:
  https://github.com/ppy/osu/pull/25759#issuecomment-1855954637
  
  That is just not how the tooltip system is supposed to be used.
  
  To name the individual sins:
  
  - Caching and returning a tooltip instance like the classes that used
    tooltips is incorrect. The lifetime of tooltip instances is managed by
    the tooltip container. `GetCustomTooltip()` is called by it
    exclusively. It should return a fresh instance every time.
  
  - Not putting actual data in `IHasCustomTooltip.TooltipContent` is
    wrong.
  
  - Having `Tooltip.SetContent()` be a no-op is *grossly and flagrantly*
    wrong.
  
  I'm not even sure which particular combination of the above
  transgressions caused the issue as it presented itself, but at this time
  I frankly do not care.

  Bartłomiej Dach · 2023-12-14 16:15:56 +01:00
  9e5b6b97ff
• Update AdvancedStats.cs
  Givikap120 · 2023-12-14 14:31:58 +02:00
  b22a7cf520
• change the order of attributes

  + simplifying the bug fix

  Givikap120 · 2023-12-14 14:31:19 +02:00
  c2373bb37b
• fixed bug

  fixed the bug where it's not updates tooltip when there are no mods

  Givikap120 · 2023-12-14 14:00:35 +02:00
  8698835db2
• Refactor everything for sanity
  Dean Herbert · 2023-12-13 17:33:39 +09:00
  5062c53e36
• Update in line with upstream changes
  Dean Herbert · 2023-12-13 16:42:20 +09:00
  fb44fb18e0
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-12-13 16:35:18 +09:00
  0259ab761b
• Fix possible nullref
  Dan Balasescu · 2023-12-13 13:32:27 +09:00
  c31ff84417
• fixed one test
  Givikap120 · 2023-12-10 02:00:32 +02:00
  2d94841929
• fixed test errors
  Givikap120 · 2023-12-10 00:40:05 +02:00
  1d0c37e138
• Add keycount to song select details panel and carousel panels
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  b36db3518c
• Made custom tooltip
  Givikap120 · 2023-11-23 23:30:18 +02:00
  c2a44cf118
• Rename method and adjust xmldoc to be very explicit about how wrong this is
  Dean Herbert · 2023-11-17 17:04:20 +09:00
  9172632b0b
• Add note about localisation
  Dean Herbert · 2023-11-17 16:52:40 +09:00
  d1cea10f21
• Fixed precision and updated AdvancedStats
  Givikap120 · 2023-11-12 18:05:18 +02:00
  26d493986c
• Merge branch 'master' into arod_rate_adjust
  Dean Herbert · 2023-11-12 15:49:07 +09:00
  6bd5eda2a0
• fixed naming incconvinence
  Givikap120 · 2023-11-10 15:13:40 +02:00
  60c3e7250b
• Update AdvancedStats.cs
  Givikap120 · 2023-11-04 21:57:42 +02:00
  d0b2b4f7b9
• improved tooltip
  Givikap120 · 2023-11-04 21:55:46 +02:00
  820519c37d
• Improve code quality
  Givikap120 · 2023-11-04 17:25:09 +02:00
  57170501cd
• Added BeatmapAttributesDisplay support
  Givikap120 · 2023-09-12 16:44:44 +03:00
  1a70110a4e
• fixed stated problems

  removed functions from `Ruleset.cs` and added a `GetEffectiveDifficulty()` instead

  Givikap120 · 2023-08-26 02:13:14 +03:00
  290f8db341
• Added "value is rate changed" indication

  Now if AR or OD value is not "true" and changed through rate - it will appear with symbol `*`
  Instead of `11` it wil show as `11*`

  Givikap120 · 2023-08-25 01:25:12 +03:00
  d5ac93f631
• Moved ruleset decl in right place
  Givikap120 · 2023-08-25 01:02:12 +03:00
  772633178c
• Fixed "works only for std" problem

  1) Now it use AR/OD calculation from Ruleset class
  2) Implemented needed functions in each of default rulesets

  Givikap120 · 2023-08-25 00:58:26 +03:00
  17b9b1649a
• Added a true AR/OD display when using DT/HT
  Givikap120 · 2023-08-24 16:49:42 +03:00
  ed886a4dc3
• Schedule difficulty calculation to avoid performing with incomplete state updates
  Salman Ahmed · 2023-01-05 12:52:08 +03:00
  8f37e69dc4
• Fix advanced statistics display using decoupled ruleset bindable for difficulty calculation
  Salman Ahmed · 2023-01-05 12:52:08 +03:00
  39221a52da
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use existing web localisation for most hardcoded strings
  Joseph Madamba · 2022-04-20 16:31:11 -07:00
  5e5c8e78a6
• Fix typon on AdvancedStats
  Dean Herbert · 2022-01-07 17:33:38 +09:00
  2ef791069c