85 Commits

• Fix FilterCriteria only being able to support one tag filter at once

  Other textual keyword filters also worked like that, wherein if you did
  `artist=a artist=b` the second filter would overwrite the second, but in
  those cases the query is against a single field, so attempting to put
  multiple search criteria in conjunction on a single field is kind of
  nonsensical, so it was sort of fine to do that.
  
  Which is not the case for user tags, which are multi-valued.

  Bartłomiej Dach · 2025-08-13 10:24:54 +02:00
  3fb1880466
• Add initial support for filtering by user tags in song select

  The way that this works is that it plugs into the online request to
  retrieve the beatmap set that the client is already performing, and
  stores user tag data to the local realm database.
  
  This means that for now user tags will only populate for beatmaps that
  the user has displayed on song select which is obviously subpar. I plan
  to follow this change up by adding user tag state dumps to `online.db`
  and using that data for initial tag population to make the majority case
  (ranked beatmaps) work.
  
  Note that several decisions were made here that are potential discussion
  points:
  
  - `RealmPopulatingOnlineLookupSource` is set up such that it can be the
    middle man / redirection point for similar flows that we need and we
    are currently missing, such as storing guest difficulty information,
    or storing the user's current best score on a beatmap (handy for rank
    achieved sorting / filtering / etc.)
  
  - The user tags are stored in `BeatmapMetadata` which breaks the
    longstanding assumption that you can arbitrarily pull out a metadata
    instance from any of the beatmaps in a set and get essentially the
    same object back.
  
    I've attempted to constrain this some by not adding user tags to
    the `IBeatmapMetadataInfo` interface through which `BeatmapSetInfo`
    exposes metadata further, but I warn in advance that this is
    a temporary state of affairs and I will make it worse in the future
    when `BeatmapMetadata.Author` becomes `Authors` plural in order to
    support guest mapper display (and direct guest difficulty submission).
  
  - The syntax for searching via user tags is chosen to mostly match web -
    it's `tag=`, with support for all of the string matching modes song
    select already has (bare word for substring, `""` quotes for phrase
    isolated by whitespace, `""!` for exact full match).

  Bartłomiej Dach · 2025-07-15 11:09:40 +02:00
  8cb81974eb
• Adjust implementation of star rating filtering in song select to new star rating flooring behaviour

  Required for things to not be broken after the previous change.

  Bartłomiej Dach · 2025-06-13 09:13:20 +02:00
  eda489b911
• Perform client side validation that the selected beatmap and ruleset have valid online IDs

  This is local to playlists, since in multiplayer the validation is
  already provided by `osu-server-spectator`.

  Dean Herbert · 2025-01-21 19:51:55 +09:00
  459847cb80
• Initial support for free style selection
  Dan Balasescu · 2024-12-23 20:12:25 +09:00
  638d959c5c
• Add missing source query filter in song select
  Joseph Madamba · 2024-11-15 22:53:23 -08:00
  465cc716d3
• Filter out unranked/unsubmitted beatmaps when using the ranked/submitted search filters
  WitherFlower · 2024-10-11 09:49:47 +02:00
  da376c534b
• Implement ranked and submitted date filtering
  WitherFlower · 2024-10-08 13:56:55 +02:00
  2369e98cfc
• Add mods to FilterCriteria, pass to ruleset method
  Dan Balasescu · 2024-03-28 23:03:26 +09:00
  9fd6449fd8
• Merge branch 'master' into add-last-played-filter
  Bartłomiej Dach · 2024-02-14 15:36:19 +01:00
  1113355753
• Fix searching at song select matching incorrect ruleset

  Regressed with https://github.com/ppy/osu/pull/25679.

  Dean Herbert · 2023-12-06 11:32:26 +09:00
  8286d3896f
• Search terms before performing other criteria checks

  Very minor, but putting the more common case towards the
  start of the method allows early return.

  Dean Herbert · 2023-12-05 15:28:56 +09:00
  45e499778f
• Avoid list construction when doing filtering
  Dean Herbert · 2023-12-05 15:26:14 +09:00
  42010574b5
• Remove incorrect copy paste fail
  Dean Herbert · 2023-10-24 17:32:01 +09:00
  c9161a7bfc
• Simplify implementation and remove unsupported test coverage
  Dean Herbert · 2023-10-24 16:01:32 +09:00
  6865d8894d
• Add ability to search for difficulty names
  Pasi4K5 · 2023-09-25 12:52:49 +02:00
  793d1bf970
• Add missing "title=" search support at song select
  Dean Herbert · 2023-06-27 15:21:13 +09:00
  702266198b
• Add exact match support at song select
  Dean Herbert · 2023-06-26 18:26:44 +09:00
  a74547c43c
• limited max Date comparison
  Elvendir · 2023-03-18 21:35:10 +01:00
  216a88e18d
• adddede LastPlayed as filter option in beatmap carousel
  Elvendir · 2023-03-18 17:53:41 +01:00
  102576cd8c
• Move filter matching code into own method to simplify early returns
  Dean Herbert · 2023-03-07 17:24:17 +09:00
  5af41bb1c8
• added extra early-returns
  OliBomby · 2023-03-04 16:49:33 +01:00
  70a925aab1
• using List instead of Span in GetSearchableTerms
  OliBomby · 2023-03-04 15:42:35 +01:00
  b90c389ff0
• Optimised GetSearchableTerms

  Reduced memory allocations to 1

  OliBomby · 2023-03-03 19:21:50 +01:00
  91d206e8d2
• Remove nullable disabling in carousel
  mk56-spn · 2023-01-08 19:02:48 +01:00
  47fb467012
• Moved filter exclusion
  Andrew Hong · 2022-08-22 03:39:46 -04:00
  c2036d3893
• Adjust to reviews
  Andrew Hong · 2022-08-22 03:20:27 -04:00
  09ef13908c
• Convert realm data propagation to more correctly use Live<T>

  wip

  Dean Herbert · 2022-07-27 19:35:09 +09:00
  438067a18b
• Replace BeatmapCollection with RealmBeatmapCollection
  Dean Herbert · 2022-07-27 19:35:09 +09:00
  41393616d8
• Add ranked and submitted date storage and filtering
  Dean Herbert · 2022-07-19 19:55:56 +09:00
  30daa0fd44
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Rename Beatmaps to BeatmapHashes for clarity
  Dean Herbert · 2022-06-10 14:03:51 +09:00
  4a5e86e451
• Change CollectionManager to only store MD5 hashes instead of full BeatmapInfo
  Dean Herbert · 2022-06-08 18:23:09 +09:00
  42cd7d9e6e
• Merge branch 'master' into ruleset-ordering-fix
  Dean Herbert · 2022-01-27 21:46:03 +09:00
  7af23328a4
• Fix compilation error due to commit split
  Dean Herbert · 2022-01-27 17:08:31 +09:00
  3ae5973ab7
• Perform ordering using IComparable instead
  Dean Herbert · 2022-01-27 15:59:20 +09:00
  5637fd64d6
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Add SortID to RulesetInfo to allow stable ordering of rulesets for display
  Dean Herbert · 2022-01-27 15:35:16 +09:00
  f30d63107a
• Fix ruleset filter matching using OnlineID instead of ShortName
  Dean Herbert · 2022-01-27 01:25:57 +09:00
  f70e10e8a4
• Fix custom rulesets not being able to convert maps
  Derrick Timmermans · 2022-01-26 15:51:39 +01:00
  873d367615
• Avoid performing keyword filtering at song select unless keywords are specified
  Dean Herbert · 2022-01-21 12:26:24 +09:00
  45bf35c425
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Update FilterMatchingTest and filter code to use ruleset's OnlineID

  The tests were relying on the `RulesetID` being set to 0 in the example
  beatmap, even though the ruleset *instance* was set to ID 5.
  
  This explicitly adds that 0 value to show intent, and also removes the
  incorrect specification of 5 (which would cause the convert filter tests
  to fail).
  
  Also updates the filter code to use `OnlineID`, which is required in
  realm changes.

  Dean Herbert · 2022-01-10 12:30:34 +09:00
  02d8a6359a
• Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:52:44 +09:00
  692e846acd
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634
• Rename BeatmapInfo.StarDifficulty to StarRating to match underlying interface
  Dean Herbert · 2021-11-11 17:19:46 +09:00
  ebe58cee11
• Update all existing usages of AuthorString/AuthorId

  Unfortunately the getters need to be left in place else EF breaks.

  Dean Herbert · 2021-11-04 18:59:37 +09:00
  ed07ee8c61
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Move common interface implementations to extension methods
  Dean Herbert · 2021-10-05 14:41:14 +09:00
  d3b9660148
• Rename BeatmapInfo variables which were named beatmap for clarity
  Dean Herbert · 2021-10-02 12:45:34 +09:00
  973c31132b