1228 Commits

• Fix argon judgement counter looking misaligned with wireframe off

  Closes https://github.com/ppy/osu/issues/34959.
  
  `ArgonCounterTextComponent` is pretty terrible and prevents being able
  to fix the issue easily. The core issue is that this is the first
  instance of the component's usage where the label text can be longer
  than the counter in the X dimension, so the total width of any counter
  is equal to max(label width, counter width), and the label will be
  aligned to the left of that width, while the counter will be aligned to
  the right of that width.
  
  The fix sort of relies on the fact that I don't expect *any* consumer of
  `ArgonCounterTextComponent` that meaningfully uses the wireframe digits
  to want the non-wireframe digits to be aligned to the *left* rather than
  the right. It's not what I'd expect any segmented display to work.
  (There are usages that specify `TopLeft` anchor, but they usually
  display the same number of wireframe and non-wireframe digits, so for
  them it doesn't really matter if the digits are left-aligned to the
  wireframes or not.)

  Bartłomiej Dach · 2025-09-13 11:11:45 +09:00
  e73e9275ba
• Change debounce method in rank display to allow more immediate updates
  Dean Herbert · 2025-09-08 15:12:49 +09:00
  06c1b81c1b
• Improve initial state handling
  Dean Herbert · 2025-09-05 16:19:55 +09:00
  ab7985f31e
• Change DefaultRankDisplay to start with no value
  Dean Herbert · 2025-09-05 16:10:27 +09:00
  52c10a42be
• Change debounce to be delayed since last actual change to avoid state flickering
  Dean Herbert · 2025-09-05 16:10:12 +09:00
  912c0a39cf
• Simplify implementation
  Dean Herbert · 2025-09-05 16:01:22 +09:00
  45ef97c92c
• Fix rank-up and rank-down sounds playing too often in some scenarios
  NiyazBiyaz · 2025-09-05 15:41:04 +09:00
  54d4b16a01
• Merge branch 'master' into argon-judgement-counter
  Bartłomiej Dach · 2025-09-03 13:01:57 +02:00
  dac534e22a
• Fix leaderboard score text never showing if leaderboard starts collapsed

  Only seems to reproduce in gameplay for whatever reason. Can't justify
  spending time to chase down why really because the previous code looked
  obviously wrong on closer inspection anyway (`rightLayer` has transforms
  applied to it on collapse/expand).

  Bartłomiej Dach · 2025-08-19 13:32:01 +02:00
  ad6c0c272d
• Hide right-side numbers when not enough space is available
  Salman Alshamrani · 2025-08-18 13:46:08 +03:00
  62548244bc
• Limit leaderboard size to sane minimum values
  Salman Alshamrani · 2025-08-13 12:52:08 +03:00
  a3443f76be
• Fix leaderboard not resizing correctly
  Salman Alshamrani · 2025-08-13 12:51:51 +03:00
  d998847271
• Merge pull request #34592 from Hiviexd/feature/argon-unstable-rate-counter

  Add "Argon" unstable rate counter

  Bartłomiej Dach · 2025-08-12 14:06:39 +02:00
  4bed784a20
• Fix initial alpha not applying correctly

  Also fixes value change callbacks in BDL (very bad) and potential
  lingering initial transforms.

  Bartłomiej Dach · 2025-08-12 13:19:35 +02:00
  6a9064cf44
• address review
  Hivie · 2025-08-11 14:14:28 +01:00
  ca4d475c6f
• Add note about dual layer being weird
  Dean Herbert · 2025-08-11 21:48:35 +09:00
  3d79cc9826
• Remove bindable added only for tests
  Dean Herbert · 2025-08-11 21:07:55 +09:00
  e93d15ef0e
• Merge branch 'master' into game-leaderboard-redesign
  Dean Herbert · 2025-08-11 19:20:13 +09:00
  2ff8393603
• fix warnings
  Hivie · 2025-08-09 22:51:07 +01:00
  7ed30af2df
• add argon variant of UR counter
  Hivie · 2025-08-09 22:34:21 +01:00
  83fbf27ff9
• convert UnstableRateCounter to an abstract class and move triangles implementation to its own component
  Hivie · 2025-08-09 22:33:07 +01:00
  5616be09a0
• Set initial gameplay leaderboard alpha to zero
  Salman Alshamrani · 2025-08-04 09:45:49 +03:00
  4f834532d4
• Add commentary
  Salman Alshamrani · 2025-07-31 04:56:37 +03:00
  fd5e67c34a
• Implement new gameplay leaderboard design
  Salman Alshamrani · 2025-07-23 00:49:46 +03:00
  e172e7f80c
• Rewrite gameplay leaderboard test scene to be usable

  At some point during the leaderboard data refactor, this test scene
  became completely unusable. This change rewrites it to use
  `SoloGameplayLeaderboardProvider` to be able to witness the user score
  being resorted and advancing through the leaderboard.

  Salman Alshamrani · 2025-07-22 23:58:06 +03:00
  84a36b1bfa
• Fix multiplayer spectator leaderboard respecting "show leaderboard" config setting

  Closes https://github.com/ppy/osu/issues/34128
  
  Simplest is best? 🤷

  Bartłomiej Dach · 2025-07-14 09:01:28 +02:00
  0f272ea0f9
• Remove unnecessary skin settings descriptions
  Salman Alshamrani · 2025-06-30 12:00:21 +03:00
  2b92b59504
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Fix player settings overlay potentially disappearing unexpectedly

  Closes https://github.com/ppy/osu/issues/33793.
  
  Can be tested with this diff:
  
  ```diff
  diff --git a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  index 635d140a4a..b3a827b699 100644
  --- a/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  +++ b/osu.Game/Screens/Play/HUD/PlayerSettingsOverlay.cs
  @@ -60,6 +60,8 @@ public PlayerSettingsOverlay()
               Origin = Anchor.TopRight;
               Anchor = Anchor.TopRight;
  
  +            X = 0.01f;
  +
               base.Content.Add(content = new FillFlowContainer
               {
                   AutoSizeAxes = Axes.Both,
  
  ```

  Dean Herbert · 2025-06-24 15:37:32 +09:00
  c0a51da110
• Merge pull request #33657 from nekodex/legacy-rank-change-sfx

  Add support for rank change SFX to `LegacyRankDisplay`

  Dean Herbert · 2025-06-12 19:41:28 +09:00
  85f0e85718
• Localise new setting
  Dean Herbert · 2025-06-12 17:30:11 +09:00
  612f853baa
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Add missing last sample playback update
  Jamie Taylor · 2025-06-12 15:45:28 +09:00
  2b0f1bfc4b
• Add support for rank change SFX to LegacyRankDisplay and debouncing
  Jamie Taylor · 2025-06-12 14:42:29 +09:00
  b729091244
• Add setting to leaderboard to allow disabling automatic collapsing

  Was a 2 minute implementation, so why not?
  
  Addresses https://github.com/ppy/osu/discussions/33523.

  Dean Herbert · 2025-06-11 17:36:56 +09:00
  04871fe55a
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Prevent rank display shown in skin editor toolbox from playing samples

  Closes https://github.com/ppy/osu/issues/33456.

  Bartłomiej Dach · 2025-06-06 13:18:20 +02:00
  e02cd28df6
• Add toggle for rank change sound playback to default rank display

  Because some people don't seem to like it. Defaults to on still.

  Bartłomiej Dach · 2025-06-06 12:51:56 +02:00
  6835d7659d
• Fix abhorrently incorrect bindable usage
  Dean Herbert · 2025-05-31 00:41:28 +09:00
  43b7171f5c
• Add sfx to ingame rank display
  Jamie Taylor · 2025-05-30 17:52:36 +09:00
  04f1e59d0e
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Fix back-to-front conditional
  Bartłomiej Dach · 2025-05-07 12:12:25 +02:00
  1fc68a3c48
• Fix gameplay leaderboard not always being expanded in gameplay leaderboard

  I'd have preferred a `get; init;` property but tests were also attached
  at the hip to the public bindable. Without some extra composition this
  is the best that I can do.

  Bartłomiej Dach · 2025-05-07 12:09:26 +02:00
  8cc2af4060
• Merge branch 'master' into gameplay-leaderboard-skinnable
  Bartłomiej Dach · 2025-05-07 10:45:51 +02:00
  5b61761bbd
• Use actual score positions in gameplay leaderboard

  Intends to close https://github.com/ppy/osu/issues/32859.
  
  The difference between this and https://github.com/ppy/osu/pull/32942 is
  that this PR takes the approach of completely moving the score sorting
  behaviour to `IGameplayLeaderboardProvider` implementations.
  
  This is going to be helpful for further work - to be precise, I am
  looking to add a leaderboard position indicator in the bottom right of
  multiplayer player to match stable, and having the position in the
  provider will make the implementation of that *much* easier.

  Bartłomiej Dach · 2025-04-25 12:40:55 +02:00
  06dc4235f0
• Convert gameplay leaderboard to skinnable component

  This PR converts the leaderboard into a full-fledged skinnable component
  that can be manipulated by users at will.
  
  Notably, this finally allows https://github.com/ppy/osu/issues/20422 to
  be fixed - although it's a very mixed bag, for several reasons:
  
  - Because of taiko players' refusal to see reason^W^W^W^Winsistence on
    keeping stable behaviours related to aspect ratio treatment, I have to
    assume the worst case scenario, which means than on typical
    resolutions like 16:9 (or even worse, 4:3), the leaderboard will
    likely not occupy as much vertical space as it probably could.
  
  - Additionally, there's the problem of where to put the spectator list.
    I settled on putting it to the right of the leaderboard, but that's
    kind of janky, because the leaderboard sometimes collapses and
    sometimes fully hides, leading to a very awkward space left behind. If
    we had the capability to anchor elements to other elements, maybe this
    could be resolved, but for now, I'm not sure what to do. I think if
    some users are bothered by it they can move it where they want it. Or
    delete it.

  Bartłomiej Dach · 2025-04-24 13:10:30 +02:00
  59b826c321
• Bring back reading from config value
  Bartłomiej Dach · 2025-04-21 09:15:44 +02:00
  da1fc1013e
• Remove unnecessary interface
  Bartłomiej Dach · 2025-04-18 12:12:21 +02:00
  6d258d4ed5
• Fix incorrect score position treatment if last score on partial leaderboard isn't tracked
  Bartłomiej Dach · 2025-04-18 12:02:02 +02:00
  3ecf56b6f6
• Fix code quality
  Bartłomiej Dach · 2025-04-18 09:09:57 +02:00
  2c690ae94c