4556 Commits

• Fix argon judgement counter looking misaligned with wireframe off

  Closes https://github.com/ppy/osu/issues/34959.
  
  `ArgonCounterTextComponent` is pretty terrible and prevents being able
  to fix the issue easily. The core issue is that this is the first
  instance of the component's usage where the label text can be longer
  than the counter in the X dimension, so the total width of any counter
  is equal to max(label width, counter width), and the label will be
  aligned to the left of that width, while the counter will be aligned to
  the right of that width.
  
  The fix sort of relies on the fact that I don't expect *any* consumer of
  `ArgonCounterTextComponent` that meaningfully uses the wireframe digits
  to want the non-wireframe digits to be aligned to the *left* rather than
  the right. It's not what I'd expect any segmented display to work.
  (There are usages that specify `TopLeft` anchor, but they usually
  display the same number of wireframe and non-wireframe digits, so for
  them it doesn't really matter if the digits are left-aligned to the
  wireframes or not.)

  Bartłomiej Dach · 2025-09-13 11:11:45 +09:00
  e73e9275ba
• Change debounce method in rank display to allow more immediate updates
  Dean Herbert · 2025-09-08 15:12:49 +09:00
  06c1b81c1b
• Improve initial state handling
  Dean Herbert · 2025-09-05 16:19:55 +09:00
  ab7985f31e
• Change DefaultRankDisplay to start with no value
  Dean Herbert · 2025-09-05 16:10:27 +09:00
  52c10a42be
• Change debounce to be delayed since last actual change to avoid state flickering
  Dean Herbert · 2025-09-05 16:10:12 +09:00
  912c0a39cf
• Simplify implementation
  Dean Herbert · 2025-09-05 16:01:22 +09:00
  45ef97c92c
• Fix rank-up and rank-down sounds playing too often in some scenarios
  NiyazBiyaz · 2025-09-05 15:41:04 +09:00
  54d4b16a01
• Merge branch 'master' into argon-judgement-counter
  Bartłomiej Dach · 2025-09-03 13:01:57 +02:00
  dac534e22a
• Move solo spectator-specific fail logic to SoloSpectatorPlayer
  Bartłomiej Dach · 2025-09-02 12:25:42 +02:00
  9354547e15
• Add test coverage and fix one more fail case
  Dean Herbert · 2025-08-26 18:41:14 +09:00
  2ccb65aa65
• Fix crash on exiting ReplayPlayer is beatmap was not loaded successfully

  Closes https://github.com/ppy/osu/issues/34763.

  Dean Herbert · 2025-08-26 18:31:42 +09:00
  4d851f2527
• Apply NRT to ReplayPlayer for good measure
  Dean Herbert · 2025-08-26 18:30:12 +09:00
  4bafbfb9e4
• Merge pull request #34643 from frenzibyte/leaderboard-resize

  Fix leaderboard not resizing correctly

  Dean Herbert · 2025-08-21 13:33:24 +09:00
  41885c0fc0
• Fix leaderboard score text never showing if leaderboard starts collapsed

  Only seems to reproduce in gameplay for whatever reason. Can't justify
  spending time to chase down why really because the previous code looked
  obviously wrong on closer inspection anyway (`rightLayer` has transforms
  applied to it on collapse/expand).

  Bartłomiej Dach · 2025-08-19 13:32:01 +02:00
  ad6c0c272d
• Hide right-side numbers when not enough space is available
  Salman Alshamrani · 2025-08-18 13:46:08 +03:00
  62548244bc
• Unapply replay playback speed when going to results

  closes https://github.com/ppy/osu/issues/34700

  Bartłomiej Dach · 2025-08-18 09:09:34 +02:00
  d26f31b71d
• Stop fail sample when rewinding to before it in replay

  closes https://github.com/ppy/osu/issues/34688
  
  I originally wrote it this way semi-intentionally because I thought
  cutting out the sample was worse than letting it play out, but I also
  forgot that people use like seventy hour long fail samples.

  Bartłomiej Dach · 2025-08-18 09:02:49 +02:00
  59ec6ed2eb
• Fix replay fail indicator "go to results" button being clickable while invisible

  closes https://github.com/ppy/osu/issues/34685

  Bartłomiej Dach · 2025-08-18 08:54:45 +02:00
  5b1b22cb66
• Fix score rank not being F on fail in replays

  closes https://github.com/ppy/osu/issues/34673
  
  This is a bit half-baked because the next thing someone is going to
  report is that when rewinding with a rank display present in the user's
  skin, the rank doesn't revert from F anymore. That is because of
  
      https://github.com/ppy/osu/blob/237de1ef72a06babd9e3dbd582d5c29faca171b9/osu.Game/Rulesets/Scoring/ScoreProcessor.cs#L392-L394
  
  which I'm not willing to touch on short notice.

  Bartłomiej Dach · 2025-08-15 19:51:44 +02:00
  fd13e94c6f
• Fix fail indicator being hideable by toggling HUD off

  closes https://github.com/ppy/osu/issues/34675

  Bartłomiej Dach · 2025-08-15 19:42:46 +02:00
  8dfe72c7e1
• Fix frequency not returning to normal when proceeding to results screen of a failed replay

  closes https://github.com/ppy/osu/issues/34674

  Bartłomiej Dach · 2025-08-15 19:41:20 +02:00
  78a3a1b721
• Merge pull request #34612 from frenzibyte/auto-beatmap-offset

  Add setting for adjusting beatmap offset automatically based on last play

  Dean Herbert · 2025-08-15 23:33:32 +09:00
  99dc2bb58f
• Reorder class to suck a bit less
  Dean Herbert · 2025-08-15 22:55:49 +09:00
  12811e2506
• Always use UR algorithm
  Dean Herbert · 2025-08-15 22:51:37 +09:00
  2d8aa403f7
• Adjust code to be more reviewable
  Salman Alshamrani · 2025-08-15 13:59:04 +03:00
  a1f0cd3b31
• Add inline comment
  Salman Alshamrani · 2025-08-15 13:35:55 +03:00
  d5758cd8fb
• Merge pull request #34628 from bdach/show-results-on-failed-replay

  Show indicator in replay player once replay fails

  Dean Herbert · 2025-08-15 19:33:47 +09:00
  a14d7a23bd
• Refetch leaderboard when (slow) retrying a beatmap

  Probably closes https://github.com/ppy/osu/issues/34645.
  
  Obviously this is only good if the score has managed to process online
  and slot into a leaderboard before the user requested a retry. I can't
  make miracles happen.
  
  Notably this is not applied to quick retry, because it would make quick
  retry slower, and the presumption is that if the user is quick-retrying
  their last score is likely useless for global leaderboards anyway. (The
  one exception to that last part is possibly quick-retrying from results
  screen, which is a flow that we have, but maybe fine to ignore it...?)

  Bartłomiej Dach · 2025-08-14 14:31:49 +02:00
  44e76a61a9
• Fix current change check not solid enough
  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  76630cff98
• Fix calibrating offset with auto-adjust enabled does not account for UR

  Covered by test `TestAutomaticAdjustmentWithUnstableRate`.

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  de7e3c96a6
• Move beatmap offset write logic to a separate method

  Note that calling `writeOffsetToBeatmap` from `currentChanged` is still intentionally not
  scheduled, see https://github.com/ppy/osu/pull/34612#discussion_r2269052138.
  
  This commit is done so that if that call is scheduled, then the logic
  above it that update the play graph and visibility state of the button
  still don't get scheduled, otherwise the test will fail (as noticed in https://github.com/ppy/osu/pull/34612#discussion_r2269208998).

  Salman Alshamrani · 2025-08-14 13:48:08 +03:00
  1db49d250f
• Limit leaderboard size to sane minimum values
  Salman Alshamrani · 2025-08-13 12:52:08 +03:00
  a3443f76be
• Fix leaderboard not resizing correctly
  Salman Alshamrani · 2025-08-13 12:51:51 +03:00
  d998847271
• Show indicator in replay player once replay fails

  This indicator allows the player to either rewind to an earlier part of
  the replay, or to proceed to results. It also plays a shortened variant
  of the failure animation SFX.

  Bartłomiej Dach · 2025-08-12 14:25:58 +02:00
  35a472ae39
• Refactor fail management to be more centralised

  Before this commit, there was `AllowFailAnimation` (used by multiplayer)
  and `OnFail()` (used by score submitting implementations of player to
  ensure a failed play submits).
  
  The former is replaced by `PerformFail()` which allows for arbitrary
  operations on failure, which replay player shall leverage in subsequent
  commits. The latter would ideally be replaced by nothing, but it's
  placed in a very awkward place behind a schedule, so by force of
  necessity to avoid code duplication it's replaced by
  `ConcludeFailedScore()` which is overridden to submit the score in all
  submitting players --- except for multiplayer, which is never supposed
  to be calling it, so in that case it just throws an exception.

  Bartłomiej Dach · 2025-08-12 14:18:48 +02:00
  85d48f5df6
• Merge pull request #34592 from Hiviexd/feature/argon-unstable-rate-counter

  Add "Argon" unstable rate counter

  Bartłomiej Dach · 2025-08-12 14:06:39 +02:00
  4bed784a20
• Fix initial alpha not applying correctly

  Also fixes value change callbacks in BDL (very bad) and potential
  lingering initial transforms.

  Bartłomiej Dach · 2025-08-12 13:19:35 +02:00
  6a9064cf44
• Display calibration button when offset is manually adjusted
  Salman Alshamrani · 2025-08-12 11:05:36 +03:00
  43d10608b4
• Adjust offset text and fix incorrect display in certain scenarios
  Salman Alshamrani · 2025-08-12 11:05:13 +03:00
  9b360e5ea9
• address review
  Hivie · 2025-08-11 14:14:28 +01:00
  ca4d475c6f
• Add note about dual layer being weird
  Dean Herbert · 2025-08-11 21:48:35 +09:00
  3d79cc9826
• Remove bindable added only for tests
  Dean Herbert · 2025-08-11 21:07:55 +09:00
  e93d15ef0e
• Merge branch 'master' into game-leaderboard-redesign
  Dean Herbert · 2025-08-11 19:20:13 +09:00
  2ff8393603
• Allow adjusting beatmap offset automatically based on last play
  Salman Alshamrani · 2025-08-11 10:37:31 +03:00
  de0eb7ccf3
• fix warnings
  Hivie · 2025-08-09 22:51:07 +01:00
  7ed30af2df
• add argon variant of UR counter
  Hivie · 2025-08-09 22:34:21 +01:00
  83fbf27ff9
• convert UnstableRateCounter to an abstract class and move triangles implementation to its own component
  Hivie · 2025-08-09 22:33:07 +01:00
  5616be09a0
• Set initial gameplay leaderboard alpha to zero
  Salman Alshamrani · 2025-08-04 09:45:49 +03:00
  4f834532d4
• Add commentary
  Salman Alshamrani · 2025-07-31 04:56:37 +03:00
  fd5e67c34a
• Add a comment about a sneaky part of the leaderboard sorting changes
  Bartłomiej Dach · 2025-07-28 11:47:19 +02:00
  a80fecffe7