37 Commits

• Fix timeline not updating ticks correctly after arbitrary timing control point changes (again)

  Closes https://github.com/ppy/osu/issues/33393.
  
  This is admittedly a half-assed diff. This was apparently "fixed" once
  before, eons ago, in https://github.com/ppy/osu/pull/11032, but I'm not
  sure whether it regressed, or where, because I don't want to bisect four
  years back. (At that time `ControlPointInfo.ControlPointsChanged`
  did not exist yet.)
  
  Also there's the part where changes to control points do not undo or
  redo (see https://github.com/ppy/osu/issues/31942), but I'm not touching
  that *either*, because if I start touching that, then I will get yelled
  at for not reviewing the 2.5k line PR that rewrites the entirety of
  change handling in editor instead
  (https://github.com/ppy/osu/pull/30314). I will attempt to get through
  that mental block sometime within the year. Please do not rush me.
  
  The cheap cop-out argument is that hooking this up to `ControlPointInfo`
  specifically is probably "more efficient" anyway.

  Bartłomiej Dach · 2025-06-10 14:44:23 +02:00
  f5aeedc7e1
• Adjust visuals of tick display (and fine tune some other timeline elements)
  Dean Herbert · 2024-08-21 16:46:14 +09:00
  7e6490133d
• Ignore "too many ticks" in timeline (triggers in normal cases)
  Dean Herbert · 2024-07-19 19:57:47 +09:00
  c4de2bbb60
• Add tooltips to summary timeline display
  Dean Herbert · 2024-07-12 16:39:41 +09:00
  2454722601
• Adjust timeline ticks to add a bit more body back
  Dean Herbert · 2024-07-12 14:29:18 +09:00
  9a7a0cdb34
• Ensure timeline ticks aren't hidden by other pieces

  Addresses https://github.com/ppy/osu/issues/28667.

  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  50818da166
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Apply required changes after framework masking updates
  Dan Balasescu · 2024-05-09 20:18:53 +09:00
  3b8b56cbcb
• Don't update subtree masking in TimelineTickDisplay
  Andrei Zavatski · 2024-03-16 15:20:37 +03:00
  34a5e2d606
• Fix transforms overhead in TimelineTickDisplay
  Andrei Zavatski · 2024-03-16 15:05:52 +03:00
  981ee54cdc
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix weird conditional
  Dean Herbert · 2022-09-27 20:09:21 +09:00
  58217b6839
• Add assert/log output when too many ticks are being displayed
  Dean Herbert · 2022-09-27 17:18:46 +09:00
  a9088d9231
• Don't attempt to render timeline ticks until DrawWidth is above zero
  Dean Herbert · 2022-09-27 17:18:46 +09:00
  e227519b09
• Remove unused static
  Dean Herbert · 2022-09-27 17:04:56 +09:00
  9dc0eb7fd0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix wrong sizing of editor timeline ticks
  Bartłomiej Dach · 2022-05-29 20:15:17 +02:00
  c892ec83ef
• Move beat divisor tick size retrieval to static methods
  Dean Herbert · 2022-05-24 18:15:20 +09:00
  4a88affd03
• Add flow for changing set of valid divisors between presets
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  d0c01afc2e
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Also adjust height
  Dean Herbert · 2021-04-13 16:43:29 +09:00
  27e851c2ee
• Update timeline ticks to use width as a differentiation method, rather than height
  Dean Herbert · 2021-04-13 16:29:35 +09:00
  ebf97ff48f
• Adjust timeline ticks to be more visible
  Dean Herbert · 2021-03-19 19:45:00 +09:00
  9be7981e0d
• Allow editor change handler to be null
  Bartłomiej Dach · 2020-12-01 20:08:31 +01:00
  94a8784e04
• Fix timeline not updating ticks correctly after arbitrary timing control point changes
  Dean Herbert · 2020-12-01 16:44:08 +09:00
  190c6ef45e
• Fix bar lines ("down beat" as people call it) showing up too often in timeline
  Dean Herbert · 2020-10-09 18:35:44 +09:00
  21c6242f90
• Account for the width of points so they don't suddenly appear at timeline edges
  Dean Herbert · 2020-10-09 16:49:51 +09:00
  5d888f687a
• Only run regeneration when passing a new min/max tick boundary
  Dean Herbert · 2020-10-09 16:47:29 +09:00
  ceb1494c33
• Only recalculate when display actually changes
  Dean Herbert · 2020-10-09 15:57:31 +09:00
  017a8ce496
• Add local pooling to TimelineTickDisplay
  Dean Herbert · 2020-10-09 15:48:24 +09:00
  9baf704942
• Reverse comparison for readability

  Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2020-02-01 02:05:26 +09:00
  90caa61245
• Fix too many ticks being displayed on beatmaps with multiple timing sections

  Closes https://github.com/ppy/osu/issues/7681.

  Dean Herbert · 2020-01-31 00:24:00 +09:00
  f51cfa2220
• Use centre origin/anchors
  Dean Herbert · 2020-01-27 18:09:54 +09:00
  d5fda053f4
• Rename class to TimelineTickDisplay
  Dean Herbert · 2020-01-27 18:08:01 +09:00
  493390b750