26 Commits

• Revert "Use median for statistic display"

  This reverts commit fa06643bb6.
  
  Revert "Remove mean hit error calculation"
  
  This reverts commit b3c578e545.

  Dean Herbert · 2025-04-11 02:12:40 +09:00
  ba5932c1dd
• Remove mean hit error calculation
  sineplusx · 2025-03-29 13:45:39 +01:00
  b3c578e545
• Add comment
  sineplusx · 2025-03-26 17:22:57 +01:00
  6452514066
• Use median instead of mean for automatic beatmap offset adjustment
  sineplusx · 2025-03-26 15:41:48 +01:00
  bb8f8e8d8c
• Fix incremental unstable rate calculation not matching expectations

  The `EventCount` variable wasn't factoring in that some results do not
  affect unstable rate. It would therefore become more incorrect as the
  play continued.
  
  Closes https://github.com/ppy/osu/issues/31712.

  Dean Herbert · 2025-01-29 17:11:12 +09:00
  d8ec3b77e4
• Add basic xmldoc to results class
  Dean Herbert · 2024-11-26 12:16:26 +09:00
  d6cf1db0f5
• Rename NextProcessableIndex to EventCount in line with actual functionality
  Dean Herbert · 2024-11-26 12:10:34 +09:00
  d903d381d5
• Only update unstable rate counter when an applicable hitobject is reached
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  bbe8f2ec44
• Use class instead of record for lower allocations
  Dean Herbert · 2024-11-25 21:13:18 +09:00
  ea68d4b33a
• Add incremental processing
  Dean Herbert · 2024-11-25 21:13:17 +09:00
  5668258182
• Address unstable rate calculations as a list for marginal gains
  Dean Herbert · 2024-11-25 19:44:11 +09:00
  33d725e889
• Make empty hitwindows readonly static and slightly improve comparison performance
  Dean Herbert · 2024-11-25 19:17:32 +09:00
  605fe71f46
• Do not show timing distribution graph in offset control if there's not enough timed hits

  Intended to address concerns raised in
  https://github.com/ppy/osu/pull/30620#issuecomment-2475744164.

  Bartłomiej Dach · 2024-11-14 13:17:03 +01:00
  bd1d3cad49
• Move algorithm description to remarks section of xmldoc
  Bartłomiej Dach · 2024-02-05 18:57:57 +01:00
  7b03bebd5f
• Use better variable names

  It's not the 1970s. We can spare a few extra letters.

  Bartłomiej Dach · 2024-02-05 18:56:20 +01:00
  a5aeb2ff9e
• Improve readability
  Andrei Zavatski · 2024-02-03 00:19:04 +03:00
  57bc5ee04f
• Incorporate new unstable rate algo
  Andrei Zavatski · 2024-02-02 22:46:52 +03:00
  dde7e068a4
• Rewrite backwards assertion
  Poyo · 2023-11-21 15:19:04 -08:00
  3a0586a8f5
• Allow GameplayRate to be nullable and assert before use
  Poyo · 2023-11-15 17:00:35 -08:00
  a73c870712
• Calculate unstable rate using rate-adjusted offsets
  Poyo · 2023-11-10 19:57:44 -08:00
  064857c40b
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix CalculateAverageHitError throwing if there are zero HitEvents
  Dean Herbert · 2022-03-01 18:44:15 +09:00
  7215f3f66b
• Add missing xmldoc
  Dean Herbert · 2022-02-28 19:14:43 +09:00
  159db38f8a
• Show hit error on results screen

  Leading up to implementation of "local offset", this feels like a good
  thing to have visible first and foremost.

  Dean Herbert · 2022-02-28 19:11:06 +09:00
  a41e1c80f1
• Fix HUD unstable rate counter not including judgements before load complete

  Also unifies UR calculation logic with the results screen statistic item
  to reduce duplication.

  Bartłomiej Dach · 2021-11-11 13:36:05 +01:00
  69809390d3