osu-lazer

Fix HealthProcessor potentially incorrectly reverting failed state

This stems from me looking into `TestSceneFailAnimation` failures
(https://github.com/ppy/osu/runs/48663953318). As it turns out, I should
not have been mad by CI, and rather should have been mad at myself for
failing to read.

`FailedAtJudgement` in fact does not mean "this judgement, and only this
judgement, triggered failure". If any further judgements occur
post-fail, they will also have `FailedAtJudgement` set to true. It is
essentially a *dump* of the state of `HealthProcessor.Failed` prior to
applying the judgement.

	https://github.com/ppy/osu/blob/ec21685c2531af3b243f7f0833ffbb340bf3c044/osu.Game/Rulesets/Scoring/HealthProcessor.cs#L49-L57

Because of this, reverting several judgements which occur post-fail
could lead to failed state reverting earlier than intended, and thus
potentially trigger a second fail, thus tripping the `Player` assertion.

Bartłomiej Dach · 2025-08-27 12:27:11 +02:00

197c318180

Add rudimentary support of rewinding failed state to health processor

As indicated in the inline comment this is very best effort, just to
make the HP bar not very obviously stuck in a very obviously incorrect
state after the replay is rewound from a failure. There's likely to be a
bunch of replay accuracy issues related to this, but I'm just making the
minimum effort to get this to work semi-acceptably for now.

Bartłomiej Dach · 2025-08-12 14:26:00 +02:00

30857de55e

Prevent multiple invocations of failure procedure

Dan Balasescu · 2024-06-26 13:57:18 +09:00

0379abd714

Fix missing tiny droplet not triggering fail with perfect on

Stable does this:

    https://github.com/peppy/osu-stable-reference/blob/46cd3a10af7cc6cc96f4eba92ef1812dc8c3a27e/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102

I'd rather not say what I think about it doing that, since it's likely
to be unpublishable, but to approximate that, just make it so that
only the "default fail condition" is beholden to the weird ebbs
and flows of what the ruleset wants. This appears to fix the problem
case and I'm hoping it doesn't break something else but I'm like 50/50
on it happening anyway at this point. Just gotta add tests add nauseam.

Bartłomiej Dach · 2024-02-14 14:21:48 +01:00

2c0a5b7ef5

Fix draining processor failing gameplay on bonus misses and ignore hits

Bartłomiej Dach · 2024-02-13 13:06:19 +01:00

16d893d40c

Add helper method to bypass judgement woes