107 Commits

• Attempt to disable rulesets that can be linked to an unhandled crash
  Bartłomiej Dach · 2024-03-22 19:05:58 +01:00
  c7c0330265
• Fix a couple of remaining issues
  Dean Herbert · 2023-06-24 09:58:36 +09:00
  58e6b3782b
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Cherry-picked android changes from #17462
  Dean Herbert · 2022-12-19 15:46:54 +09:00
  877413524f
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Improve messaging when ruleset load fails
  Dean Herbert · 2022-11-01 13:57:34 +09:00
  706adfb28c
• Centralise logging of failed ruleset loads
  Dean Herbert · 2022-08-18 16:14:38 +09:00
  b0a740071e
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Split out realm portion of RulesetStore
  Dean Herbert · 2022-02-16 17:13:31 +09:00
  7a69de0060
• Fix rulesets potentially being marked Available even when methods are missing

  Came up when running the game after the recent breaking changes
  (https://github.com/ppy/osu/pull/16722), where two template rulesets I
  had loaded were erroring on startup but still being marked as available,
  allowing them to crash the game on attempting to initiate relpay logic.
  
  These cases are already handled for first-time ruleset loading via the
  `GetTypes()` enumeration in `RulesetStore.addRuleset`, but when
  consistency checking already present rulesets the only runtime
  validation being done was `ruleset.CreateInstance()`, which does not
  handle missing types or methods.

  Dean Herbert · 2022-02-02 14:52:01 +09:00
  0c5da9370a
• Perform ordering using IComparable instead
  Dean Herbert · 2022-01-27 15:59:20 +09:00
  5637fd64d6
• Add SortID to RulesetInfo to allow stable ordering of rulesets for display
  Dean Herbert · 2022-01-27 15:35:16 +09:00
  f30d63107a
• Fix custom rulesets being displayed before official ones
  Dean Herbert · 2022-01-26 18:46:32 +09:00
  57e624d8e7
• Update remaining cases of clashes with realm.Write and realm.RegisterForNotifications
  Dean Herbert · 2022-01-25 13:09:48 +09:00
  d7342880f5
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Update all usages of CreateContext to use either Run or Write
  Dean Herbert · 2022-01-21 17:27:08 +09:00
  114c9e8c1f
• Fix rulesets being out of order
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  2d2faa72a9
• Fix missing interface implementation of IRulesetStore
  Dean Herbert · 2022-01-12 16:58:58 +09:00
  a3da8dc49d
• Replace EF RulesetStore with realm version

  Pass full EF context factory to `RealmContextFactory` for migration purposes

  Dean Herbert · 2022-01-12 16:39:36 +09:00
  3ecd889fef
• Add IRulesetStore to allow for transitional usage in upcoming manager classes
  Dean Herbert · 2021-12-03 17:57:40 +09:00
  675ecb603f
• Throw again to ensure correct available state is set

  Also standardises handling between `RulesetStore` and `RealmRulesetStore`.

  Dean Herbert · 2021-11-11 17:39:36 +09:00
  4bca96d548
• Remove unused using
  Dan Balasescu · 2021-11-11 15:29:08 +09:00
  57c333b472
• Gracefully handle missing type rather than triggering ArgumentNullException
  Dean Herbert · 2021-11-11 14:46:21 +09:00
  ea536dea23
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Reword comment and remove brackets
  Salman Ahmed · 2021-08-22 12:40:41 +03:00
  956112eb10
• Add null check for Android ruleset loading
  Michael Malloy · 2021-08-22 00:38:48 -05:00
  9cd0a182f6
• Remove unused using statement
  Dean Herbert · 2021-06-18 19:39:01 +09:00
  2dadc9d686
• Fix renaming a ruleset DLL causing a startup crash
  Dean Herbert · 2021-06-18 19:32:40 +09:00
  78c5ccda60
• Ignore possible nulls in Type.GetType() calls

  They're mostly used in extensibility scenarios, so everything happens in
  runtime. There is no better resolution than to crash with a null
  reference exception.

  Bartłomiej Dach · 2021-05-15 00:09:34 +02:00
  628e7a71ed
• Remove unused using directive
  Salman Ahmed · 2021-04-02 02:45:26 +03:00
  5b1dc7d2b4
• Guard against same ruleset file with loaded assembly filenames instead
  Salman Ahmed · 2021-04-02 02:12:25 +03:00
  fcd56dba44
• Change .StartsWith() to .Equals()

  In line with planned-but-delayed breaking change.

  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  68352782db
• Replace with local tolist
  smoogipoo · 2020-10-16 23:40:44 +09:00
  6385d5f369
• Silence EF warning due to ordinal being unsupported
  smoogipoo · 2020-10-16 23:31:37 +09:00
  81cc5e1c42
• Add missing string function ordinal specifications
  Dean Herbert · 2020-10-16 12:49:31 +09:00
  cc41845f56
• Fix crash when same ruleset loaded more than once

  If the same ruleset assembly was present more than once in the current
  AppDomain, the game would crash. We recently saw this in Rider EAP9.
  While this behaviour may change going forward, this is a good safety
  measure regardless.

  Dean Herbert · 2020-08-11 11:09:02 +09:00
  471ed968e3
• Use OrderByDescending
  Dean Herbert · 2020-07-31 16:21:47 +09:00
  62ba214dad
• Fix dynamic compilation loading wrong ruleset versions
  smoogipoo · 2020-07-30 21:10:13 +09:00
  23ab6f8f94
• Fix incorrect usage of Directory.GetFiles
  Dean Herbert · 2020-06-02 14:55:10 +09:00
  6c8c95677f
• Remove unnecessary use of and remove StartupStorage
  Salman Ahmed · 2020-05-31 19:49:03 +03:00
  2c6887e610
• Replace any potential usage of Environment.CurrentDirectory with a new RuntimeInfo.StartupDirectory

  Using `Environment.CurrentDirectory` for storing / reading files is dangerous as the current directory is mutable and can be changed when performing a certain operation (like opening solutions in roslyn type reference builder for example).

  Salman Ahmed · 2020-05-31 02:24:49 +03:00
  82fe99cf4a
• Change comparison direction
  Dean Herbert · 2020-05-08 20:33:02 +09:00
  5c2778d5f0
• Fix loading a ruleset with a new version specification causing a crash
  Dean Herbert · 2020-05-08 18:05:06 +09:00
  a59db976d6
• Add spaces to comments
  alex · 2020-05-04 18:36:24 -07:00
  0e2ccac33b
• Resolve ruleset dependencies on game core / framework assemblies by checking already loaded assemblies in AppDomain.
  Lucas A · 2020-04-20 13:56:15 +02:00
  a541f92682
• Fix whitespace formatting
  Bartłomiej Dach · 2020-04-19 16:29:32 +02:00
  1dcb0f53a2
• Add comment in regards to the attaching of event handler to the assembly lookup event before call to loadUserRulesets().
  Lucas A · 2020-04-19 15:26:00 +02:00
  ba1c465edf
• Fix comment wording

  Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Lucas A · 2020-04-19 15:15:04 +02:00
  a7179d1c87
• Don't search for user rulesets if rulesetsStorage isn't set (Testing environnment)
  Lucas A · 2020-04-07 16:01:47 +02:00
  2087d8d09e
• Apply review suggestions
  Lucas A · 2020-04-07 12:22:09 +02:00
  08308e07e7