24 Commits

• Adjust combo accounting in score processor to be order-agnostic

  Closes https://github.com/ppy/osu/issues/21732.
  
  While the problem of multiple judgements in one frame and ordering of
  `RevertResult()` calls as described in the issue is a real one, this
  commit is a bit of a sidestep of the entire issue.
  
  The idea here that while *snapshots* of instantaneous combo values are
  susceptible to such ordering foibles on revert, *deltas* are not - and
  such, when deltas are using to update the combo counts on revert,
  ordering stops mattering so much.

  Bartłomiej Dach · 2025-05-20 12:28:28 +02:00
  237de1ef72
• Refactor result application around again to remove requirement for fields

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Bartłomiej Dach · 2024-02-05 13:21:01 +01:00
  efe6bb25b1
• Add helper method to bypass judgement woes
  Dean Herbert · 2024-01-16 15:52:05 +09:00
  57a6025a2c
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Allow GameplayRate to be nullable and assert before use
  Poyo · 2023-11-15 17:00:35 -08:00
  a73c870712
• Calculate unstable rate using rate-adjusted offsets
  Poyo · 2023-11-10 19:57:44 -08:00
  064857c40b
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix TestSceneScoring and incorrect combo calculations
  Dan Balasescu · 2023-05-19 14:09:19 +09:00
  7cbf48ffcf
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add new method handling hit state specifically

  Until now UpdateStateTransforms was applying results offsets to
  StartTime. This didn't cover the case of a HitObject with duration,
  where the call would be made with `StartTime + hitOffset` rather than
  `EndTime + hitOffset`.
  
  To resolve this, a new method has been added which should be used to
  handle hit-specific state transforms.

  Dean Herbert · 2020-11-04 16:13:14 +09:00
  7f30140b7e
• Fix a few missed judgements
  smoogipoo · 2020-09-29 16:33:38 +09:00
  a1394c1830
• Merge branch 'master' into stop-counting-to-score-after-fail
  Dean Herbert · 2019-09-06 16:12:53 +09:00
  6ce36bd39e
• Expose full hitobject rather than hit windows
  smoogipoo · 2019-09-02 17:14:40 +09:00
  0c73c5acf3
• Add HitWindows to JudgementResult to indicate timing errors
  smoogipoo · 2019-09-02 16:28:14 +09:00
  f2bdf94a1d
• Refactor as proposed
  smoogipoo · 2019-08-09 13:38:04 +09:00
  88fa06efba
• Make hp work + cleanup
  smoogipoo · 2019-04-22 18:02:49 +09:00
  4edb17a88a
• Add ToString for Judgements to ease debugging
  Dean Herbert · 2019-02-22 12:02:54 +09:00
  f919f2252f
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• More xmldocs to hitobject/drawablehitobject
  smoogipoo · 2018-08-06 10:55:38 +09:00
  b35817c877
• Split out judgement definition from judgement result
  smoogipoo · 2018-08-02 20:35:54 +09:00
  3619290c34