244 Commits

• Add Hits Per Play statistic to profile overlay
  Denis Titovets · 2025-07-27 22:23:40 +03:00
  5dd180c3c5
• Adjust user actions popover design
  Salman Alshamrani · 2025-06-14 15:46:10 +03:00
  32285f4560
• Add block / unblock option to user profile overlay

  This is not doing the thing that the website does wherein the entire
  user profile is replaced by the message that the user is blocked if
  they're blocked. Someone else can try doing that.
  
  I'm also not adding report button to this because it's going to be
  annoying to make happen because currently reporting is only available as
  a popover and not as a dialog. Someone else can pick that up as well.

  Bartłomiej Dach · 2025-06-13 14:53:18 +02:00
  b47988e899
• Fix daily challenge marker text spacing

  Closes https://github.com/ppy/osu/issues/32908.
  
  Have you ever been in a situation wherein you find out you fixed a bug
  that you didn't know existed, but that makes *another* bug appear
  because it was relying on the other bug? This is where I'm at right now.
  
  But, to start from the top.
  
  `TextFlowContainer.Text` (the setter) is a convenience property that you
  use to set the text in one go. Internally it uses `AddText()`:
  
  	https://github.com/ppy/osu-framework/blob/681900ffb70adfeede4e3fa32a69da66252691ee/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L81-L94
  
  `AddText()`'s xmldoc says:
  
  	The \n character will create a new paragraph, not just a line break.
  	If you need \n to be a line break, use <see cref="AddParagraph{TSpriteText}(LocalisableString, Action{TSpriteText})"/> instead.
  
  	https://github.com/ppy/osu-framework/blob/681900ffb70adfeede4e3fa32a69da66252691ee/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L226-L239
  
  That's right. This portion of xmldoc was *straight up false* and
  *silently broken* before https://github.com/ppy/osu-framework/pull/6556.
  If you want to check that out yourself, apply the following patch to
  framework:
  
  diff --git a/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs b/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
  index 464f47c2c..e1ad521a7 100644
  --- a/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
  +++ b/osu.Framework.Tests/Visual/Containers/TestSceneTextFlowContainer.cs
  @@ -180,6 +180,22 @@ public void TestAlignmentIsCorrectWhenLineBreaksAtLastWordOfParagraph(Anchor tex
               });
           }
  
  +        [Test]
  +        public void TestSetTextWithNewLine()
  +        {
  +            AddStep("set text", () => textContainer.Text = "this text\nhas a newline");
  +            AddStep("clear and add text", () =>
  +            {
  +                textContainer.Clear();
  +                textContainer.AddText("this text\nhas a newline");
  +            });
  +            AddStep("clear and add paragraph", () =>
  +            {
  +                textContainer.Clear();
  +                textContainer.AddParagraph("this text\nhas a newline");
  +            });
  +        }
  +
           private void assertSpriteTextCount(int count)
               => AddAssert($"text flow has {count} sprite texts", () => textContainer.ChildrenOfType<SpriteText>().Count() == count);
  
  On `master`, there will be a difference between the first two steps, and
  the third. On 2025.321.0, *there will be none*.
  
  My working theory as to why this was always busted is that the
  corresponding code that was there before in
  
  	https://github.com/bdach/osu-framework/blob/c31a48178889ca2f9b4d257d2d64915eee90338a/osu.Framework/Graphics/Containers/TextFlowContainer.cs#L454-L458
  
  just straight up ran too late. *The height of the container is being
  changed after the flow has laid itself out, without adjusting subsequent
  children in any way.*
  
  There is potentially a discussion to be had as to whether the emergent
  behaviour of `TextFlowContainer.Text` with respect to `\n` character is
  correct, but I'm just going to start with this diff and see what the
  reaction is.

  Bartłomiej Dach · 2025-04-22 08:52:01 +02:00
  5895a8ac49
• Fix potential crashes due to asynchronous BindableList usage

  Band-aid fix for https://github.com/ppy/osu/issues/32671.
  
  Removes all `BindableList.BindTo` from `load()` methods (except one
  editor one which looks safe and is kinda hard to fix without moving
  drawable load to a blocking operation).

  Dean Herbert · 2025-04-04 19:54:47 +09:00
  04f8fcd04f
• Adjust text flow usages to framework changes
  Bartłomiej Dach · 2025-03-11 10:43:35 +01:00
  e2e2383c50
• Minor bump some packages
  Dean Herbert · 2025-02-17 15:23:26 +09:00
  db4a4a1723
• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Expose EndpointConfiguration directly in IAPIAccess
  Bartłomiej Dach · 2025-02-05 13:31:37 +01:00
  7d299bb2ad
• Add basic animation
  Dean Herbert · 2025-01-20 15:47:47 +09:00
  04ba686be5
• Fix code quality
  Bartłomiej Dach · 2025-01-17 13:34:16 +01:00
  b79e937d2d
• Remove unnecessary masking spec

  It was clipping the daily challenge completion checkmark, and it
  originates in some veeeeery old code where the profile overlay looked
  and behaved very differently (0fa0271878).

  Bartłomiej Dach · 2025-01-17 10:40:26 +01:00
  a67a68c596
• Add completion marker to daily challenge profile counter
  Bartłomiej Dach · 2025-01-17 10:26:59 +01:00
  b215073957
• Fix idle/hover colour handling weirdness in OsuHoverContainer
  Dean Herbert · 2025-01-16 18:54:51 +09:00
  cde8e7b82e
• Always show dialog when clicking supporter icon before opening browser

  I managed to do this by accident three times today while testing using
  the dashboard display, so it's time to action on it.
  
  Touched on in
  https://github.com/ppy/osu/discussions/30740#discussioncomment-11345996.
  Was also mentioned recently in discord or another discussion explicitly
  but I can't find that.

  Dean Herbert · 2025-01-06 17:51:04 +09:00
  4f1a6b4688
• Split actual methods & fix completely broken localisation

  Localisable strings cannot be plainly interpolated or joined. That is a
  lossy operation that loses data.

  Bartłomiej Dach · 2024-12-16 13:16:52 +09:00
  cfdb959cf6
• Clean up model

  - Properly annotate things as nullable
  - Remove weird passthrough property (more on that later)

  Bartłomiej Dach · 2024-12-16 13:14:21 +09:00
  8d1d026f56
• Fix code quality issues
  Nicholas Chin · 2024-12-15 13:53:33 +08:00
  e2edd9e0d5
• Use Count comparison instead of Any
  Nicholas Chin · 2024-12-14 08:29:32 +08:00
  153e6c0c22
• Add missing mania tooltip overlay for 4k and 7k
  Nicholas Chin · 2024-12-11 23:15:05 +08:00
  26f15def70
• Remove no longer required comment
  Salman Alshamrani · 2024-11-28 17:55:15 -05:00
  51bcde67aa
• Adjust daily challenge tier thresholds to match expectations
  Hiviexd · 2024-11-28 12:49:30 +01:00
  66093872e8
• add AddFriendResponse
  cdwcgt · 2024-11-05 15:55:42 +08:00
  c576fd8448
• Handle response to get accurate mutual state immediately
  Dean Herbert · 2024-11-05 16:20:55 +09:00
  1fcdf67806
• Update status and count immediately after friend request completes
  Dean Herbert · 2024-11-05 14:53:54 +09:00
  0087270b7e
• Remove weird method
  Bartłomiej Dach · 2024-11-04 13:13:23 +01:00
  e064965281
• Adjust colours to actually match web
  Bartłomiej Dach · 2024-11-04 12:02:20 +01:00
  cb833007e0
• rename FriendDeleteRequest to DeleteFriendRequest
  cdwcgt · 2024-11-01 19:17:25 +08:00
  fbe6077ec2
• rename FriendAddRequest to AddFriendRequest
  cdwcgt · 2024-11-01 19:16:56 +08:00
  21b1c799f3
• add tooltips
  cdwcgt · 2024-11-01 14:43:00 +08:00
  9e4c382a61
• typo
  cdwcgt · 2024-11-01 14:42:50 +08:00
  3bd116cd65
• store follower count locally
  cdwcgt · 2024-11-01 14:06:23 +08:00
  29ba13fe77
• add test
  cdwcgt · 2024-11-01 14:05:24 +08:00
  0b2f4facac
• logic in FollowersButton
  cdwcgt · 2024-11-01 12:54:13 +08:00
  45cc830aee
• add ability to shou loading layer and set icon for followersButton
  cdwcgt · 2024-11-01 12:53:57 +08:00
  350e1d6332
• Fix incorrect tiers being used for tooltip total participation display

  Compare: https://github.com/ppy/osu-web/pull/11457/commits/95e4561a54353016f25c3fc859b176038b82088a

  Bartłomiej Dach · 2024-09-08 14:26:50 +02:00
  7f814d3106
• show stats on all rulesets
  Michael Bui · 2024-09-06 23:05:04 +12:00
  a31ea24c6d
• Hide daily challenge stats if there are no plays
  Michael Bui · 2024-09-06 23:01:05 +12:00
  362b4bbc56
• change colour
  Michael Bui · 2024-09-06 22:04:10 +12:00
  ab8771900a
• revert back to axes.both
  Michael Bui · 2024-09-06 22:02:35 +12:00
  34a9d60c19
• take out drawable
  Michael Bui · 2024-09-06 21:54:41 +12:00
  f59895aa34
• show participation count in tooltip
  Michael Bui · 2024-09-06 21:52:42 +12:00
  15f73a3dfb
• Fix Daily Challenge play count using a different colour than osu-web
  Jonas Brandstötter · 2024-08-24 11:21:28 +02:00
  89a4025c01
• Add localisation for daily challenge day/week units
  Dan Balasescu · 2024-08-14 15:10:55 +09:00
  f882ad4a53
• Undo localisation of Daily Challenge string for now
  Dean Herbert · 2024-08-03 22:44:51 +09:00
  d95d63d7ee
• Add colouring for play count

  Matches https://github.com/ppy/osu-web/pull/11381.

  Dean Herbert · 2024-08-02 15:38:17 +09:00
  729039406b
• Rename classes to remove "streak" terminology

  Since the primary display isn't showing a streak.

  Dean Herbert · 2024-08-02 15:33:30 +09:00
  816dee181a
• Update to use localiastions
  Dean Herbert · 2024-08-02 15:33:25 +09:00
  d76fc34cf8
• Fix daily challenge display showing incorrect statistic
  Salman Ahmed · 2024-07-30 08:12:03 +03:00
  91dfe4515b
• Remove no longer used dependency
  Salman Ahmed · 2024-07-30 07:07:11 +03:00
  dca61eb76c