34 Commits

• Always use MessagePack to talk to spectator server
  Dan Balasescu · 2025-08-06 16:36:33 +09:00
  d0e9fda874
• Also send version hash header under more accepted convention of name
  Bartłomiej Dach · 2024-07-17 16:21:46 +02:00
  2a601ce961
• Send client-generated session GUID for identification purposes

  This is the first half of a change that *may* fix
  https://github.com/ppy/osu/issues/26338 (it definitely fixes *one case*
  where the issue happens, but I'm not sure if it will cover all of them).
  
  As described in the issue thread, using the `jti` claim from the JWT
  used for authorisation seemed like a decent idea. However, upon closer
  inspection the scheme falls over badly in a specific scenario where:
  
  1. A client instance connects to spectator server using JWT A.
  
  2. At some point, JWT A expires, and is silently rotated by the game in
     exchange for JWT B.
  
     The spectator server knows nothing of this, and continues to only
     track JWT A, including the old `jti` claim in said JWT.
  
  3. At some later point, the client's connection to one of the spectator
     server hubs drops out. A reconnection is automatically attempted,
     *but* it is attempted using JWT B.
  
     The spectator server was not aware of JWT B until now, and said JWT
     has a different `jti` claim than the old one, so to the spectator
     server, it looks like a completely different client connecting, which
     boots the user out of their account.
  
  This PR adds a per-session GUID which is sent in a HTTP header on every
  connection attempt to spectator server. This GUID will be used instead
  of the `jti` claim in JWTs as a persistent identifier of a single user's
  single lazer session, which bypasses the failure scenario described
  above.
  
  I don't think any stronger primitive than this is required. As far as I
  can tell this is as strong a protection as the JWT was (which is to say,
  not *very* strong), and doing this removes a lot of weird complexity
  that would be otherwise incurred by attempting to have client ferry all
  of its newly issued JWTs to the server so that it can be aware of them.

  Bartłomiej Dach · 2024-07-17 15:56:41 +02:00
  3006bae0d8
• Centralise and improve messaging around online state

  When the server requests a disconnect due to a user connecting
  via a second device, the client will now log the user out on the first
  device and show a notification informing them of the cause of
  disconnection.

  Bartłomiej Dach · 2023-11-21 15:15:46 +09:00
  42fada578e
• Remove redundant api field from HubClientConnector
  Bartłomiej Dach · 2023-11-21 15:15:46 +09:00
  2391035e49
• Implement client-side disconnection flow
  Bartłomiej Dach · 2023-11-21 15:15:45 +09:00
  1c612e2e0c
• Update usages of SupportsJIT in line with framework changes
  Salman Ahmed · 2022-12-16 00:22:11 +03:00
  5fbd4ad3b4
• Avoid configuring web proxies on iOS for now
  Salman Ahmed · 2022-12-16 00:22:11 +03:00
  660cc72f2a
• Fix chat connecting too early
  Dan Balasescu · 2022-11-04 19:36:24 +09:00
  f12ada9d92
• Rename Socket* -> PersistentEndpoint*
  Dan Balasescu · 2022-11-02 11:43:22 +09:00
  46d1713e28
• Extract general elements from HubClientConnector into SocketClientConnector
  Dan Balasescu · 2022-10-27 14:37:10 +09:00
  4127aaa988
• Perform actions after server reconnection
  Dean Herbert · 2022-07-17 21:09:48 +09:00
  da7edd5d49
• Simplify error output when hub cannot connect

  Full call stack is useless in these cases.
  
  Before:
  
  ```csharp
  
  [network] 2022-07-07 16:05:31 [verbose]: OnlineMetadataClient connection error: System.Net.Http.HttpRequestException: Response status code does not indicate success: 403 (Forbidden).
  [network] 2022-07-07 16:05:31 [verbose]: at System.Net.Http.HttpResponseMessage.EnsureSuccessStatusCode()
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.NegotiateAsync(Uri url, HttpClient httpClient, ILogger logger, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.GetNegotiationResponseAsync(Uri uri, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.SelectAndStartTransport(TransferFormat transferFormat, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.StartAsyncCore(TransferFormat transferFormat, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnection.StartAsync(TransferFormat transferFormat, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory.ConnectAsync(EndPoint endPoint, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.Http.Connections.Client.HttpConnectionFactory.ConnectAsync(EndPoint endPoint, CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsyncCore(CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsyncInner(CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at Microsoft.AspNetCore.SignalR.Client.HubConnection.StartAsync(CancellationToken cancellationToken)
  [network] 2022-07-07 16:05:31 [verbose]: at osu.Game.Online.HubClientConnector.connect() in /Users/dean/Projects/osu/osu.Game/Online/HubClientConnector.cs:line 119
  
  ```
  
  After:
  
  ```csharp
  
  [network] 2022-07-07 16:06:59 [verbose]: OnlineMetadataClient connecting...
  [network] 2022-07-07 16:06:59 [verbose]: OnlineMetadataClient connect attempt failed: Response status code does not indicate success: 403 (Forbidden).
  
  ```

  Dean Herbert · 2022-07-08 01:06:40 +09:00
  f500d5ade6
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Handle server shutdown messages in room creation and spectator initialisation
  Dean Herbert · 2022-05-26 18:03:41 +09:00
  abb69a49b0
• Expose Reconnect logic in HubClientConnector
  Dean Herbert · 2022-05-26 18:02:50 +09:00
  63dd9bd493
• Specify web proxy in SignalR connection building

  Might solve https://github.com/ppy/osu/discussions/17897 (depends on how
  adeptly signalr falls back to long polling if/when is fails to websocket
  via the proxy, or maybe succeed).
  
  As with the framework side change, I've tested this to not break a
  zero-proxy flow. Intending to have the user test this after next
  release.
  
  Reference:
  https://stackoverflow.com/questions/59343807/get-system-default-web-proxy-in-net-core
  /
  https://stackoverflow.com/questions/13515058/using-signalr-client-through-a-web-proxy

  Dean Herbert · 2022-04-21 15:16:41 +09:00
  e54d3702a6
• Replace usage of TypeNameHandling.All with custom type converter
  Dean Herbert · 2021-11-11 14:04:19 +09:00
  98fa253e1e
• Add workaround for SignalR union serialisation
  Dean Herbert · 2021-08-19 17:41:50 +09:00
  fa01e4fad2
• Fix incorrectly overwritten ReferenceLoopHandling setting
  Dean Herbert · 2021-08-03 14:55:20 +09:00
  ee102e3755
• Add the ability to not use MessagePack when creating a HubConnector
  Dean Herbert · 2021-08-02 18:50:22 +09:00
  617ff40de7
• Add signalr json type handling specification
  Dean Herbert · 2021-08-02 18:50:22 +09:00
  1cd967b351
• Fix HubClientConnector reconnecting with no delay on server-triggered error
  Dean Herbert · 2021-07-28 20:46:02 +09:00
  cd2a1af6de
• Apply ConfigureAwait changes to game side
  Dean Herbert · 2021-03-08 14:36:35 +09:00
  b1cd01ceb8
• Send version hash on hub connection
  Dean Herbert · 2021-02-15 16:51:40 +09:00
  55d5d8d5be
• Move HubClientConnector retrieval to IAPIProvider
  Dean Herbert · 2021-02-15 16:43:56 +09:00
  9ad38ab20e
• Remove unused using
  Salman Ahmed · 2021-02-11 13:00:18 +03:00
  f4a7ec57e9
• Slight reword in ConfigureConnection's xmldoc
  Salman Ahmed · 2021-02-11 12:39:06 +03:00
  37e3d95c35
• Replace nullable API with null connector instead
  Salman Ahmed · 2021-02-11 12:34:39 +03:00
  d3c1b47592
• Apply documentation suggestions

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Ahmed · 2021-02-11 10:51:04 +03:00
  18acd7f080
• Rename some members and extract connection closure to separate method
  Salman Ahmed · 2021-02-11 10:49:16 +03:00
  5fb99fdc52
• Remove necessity of making hub client connector a component
  Salman Ahmed · 2021-02-09 07:53:22 +03:00
  848b81e952
• Add a SignalR hub client connector component
  Salman Ahmed · 2021-02-09 01:52:35 +03:00
  af345ea5db