76 Commits

• Simplify naming of endpoints
  Dean Herbert · 2025-02-07 17:33:32 +09:00
  41c8f64806
• Expose EndpointConfiguration directly in IAPIAccess
  Bartłomiej Dach · 2025-02-05 13:31:37 +01:00
  7d299bb2ad
• Trigger request failure on receiving a null response for a typed APIRequest
  Dean Herbert · 2024-09-05 01:00:23 +09:00
  6fc60908c0
• Apply NRT to APIRequest
  Dean Herbert · 2024-08-30 18:35:31 +09:00
  2d745fb67e
• Use IAPIProvider interface and correctly support scheduling from DummyAPIAccess
  Dean Herbert · 2024-08-30 18:35:31 +09:00
  07611bd8f5
• Provide API context earlier to api requests in order to fix missing schedules

  Closes https://github.com/ppy/osu/issues/29546.

  Dean Herbert · 2024-08-30 18:10:36 +09:00
  5836f497ac
• Clean up type display for web requests in logs
  Dean Herbert · 2023-10-30 15:07:35 +09:00
  a8c3f59845
• Supply Accept-Language header in API requests
  Salman Ahmed · 2023-06-08 02:59:34 +03:00
  9f842ccdc0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Fix web requests potentially being performed after cancelled

  Closes https://github.com/ppy/osu/issues/18524.

  Dean Herbert · 2022-06-03 16:04:52 +09:00
  eb2d822530
• Add API versioning
  Dean Herbert · 2022-02-21 19:02:03 +09:00
  7f4cc221d2
• Move API request response size log to correct logging target
  Salman Ahmed · 2021-12-07 04:01:56 +03:00
  974987550f
• Log output response sizes

  Visibility is the first step towards action. Or something.

  Dean Herbert · 2021-11-30 19:09:13 +09:00
  23e297d414
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-07 11:26:01 +09:00
  0ecf5f201c
• Check for null/empty instead
  Dean Herbert · 2021-11-03 04:09:31 +09:00
  51e92e1b2d
• Fix unauthenticated API requests no longer working
  Dean Herbert · 2021-11-03 03:30:15 +09:00
  8d0b32981f
• Rename APIRequest.Result to Response
  Dean Herbert · 2021-10-05 14:28:56 +09:00
  b41fa41c85
• Ensure all request failures are correctly handled during login
  Dean Herbert · 2021-08-19 19:55:14 +09:00
  a6b7ca1a4c
• Fix aborting an APIRequest potentially resulting in incorrect success
  Dean Herbert · 2021-07-29 13:01:52 +09:00
  3a5324c947
• Avoid deserialisation JSON request content when error is not present (or not relevant)
  Dean Herbert · 2021-07-28 20:13:40 +09:00
  1ed4fdd5f5
• Fix derived API request types firing success when they shouldn't

  The usual case of `virtual`/`override` being dangerous when logic is
  added to the base implementation. As such, I've removed this completely.

  Dean Herbert · 2021-07-22 14:23:27 +09:00
  57e5f5575a
• Fix API request potentially firing failed events after completion

  Specifically, `Cancel()` calls were not thread safe. Due to a series of
  events, `ListPollingComponent` could call `Cancel` from a non-update
  thread, leading to a race condition where both a `Success` and `Fail`
  event can be fired.
  
  This is intended to be the simplest fix possible, locking and guarding
  specifically on the callbacks. Further work could be done in the future
  to improve the flow surrounding `pendingFailure`, potentially reducing
  redundant work and cleaning up the code, but that's not happening here.
  
  Closes https://github.com/ppy/osu/issues/13632.

  Dean Herbert · 2021-07-19 20:27:01 +09:00
  80c2b1449b
• Avoid firing any kind of failures after success
  Dean Herbert · 2021-03-23 17:50:31 +09:00
  ce452565f4
• Fail all API requests sent to DummyAPIAccess

  Until now, API requests sent to dummy API were just lost in the void. In most cases this somehow worked as expected, but any logic which is waiting on a request to finish will potentially never get a response.
  
  Going forward, I'm not 100% sure that every `Wait` on a web response will have local timeout logic (I think there is a certain amount of assumption that this is being managed for us by `APIAccess`), so I've made this change to better handle such cases going forward. Now, rather than nothing happening, requests will trigger a failure via the existing exception logic rather than silently pretending the request never arrived.

  Dean Herbert · 2021-03-23 17:37:45 +09:00
  f5ba746ae5
• Add website root URL and update most links to use it

  For what it's worth, I intentionally didn't include news / changelog /
  supporter, because these should never change.

  Dean Herbert · 2020-12-24 18:11:42 +09:00
  323da82477
• Add APIRequest.TriggerFailure() for testing
  smoogipoo · 2020-07-31 20:55:26 +09:00
  8e8a11bb72
• Fix some web requests retrieving the user too early
  Dean Herbert · 2020-07-14 13:07:17 +09:00
  7fe69bb199
• Add spaces to comments
  alex · 2020-05-04 18:36:24 -07:00
  0e2ccac33b
• Fix inline executions of APIRequest.Perform not getting result populated early enough
  Dean Herbert · 2020-04-20 17:48:02 +09:00
  801f02a3d7
• Exception instead of assert
  Dean Herbert · 2020-04-13 21:24:47 +09:00
  1c8a71b284
• Add support for non-generic requests
  Dean Herbert · 2020-04-11 18:02:49 +09:00
  c96df97586
• Add support for Result fetching
  Dean Herbert · 2020-04-11 18:02:43 +09:00
  415adecdf6
• Add basic request / response support
  Dean Herbert · 2020-04-11 17:48:23 +09:00
  832822858c
• Keep provided IDs where possible if not online
  Dean Herbert · 2020-03-30 15:07:39 +09:00
  7ecce713bb
• Fix json web requests having incorrect user agents
  smoogipoo · 2020-01-17 19:21:27 +09:00
  2187523bf3
• Fix user agent missing in registration
  Dean Herbert · 2020-01-16 12:51:43 +09:00
  0d8b4e7c3e
• Set UserAgent for API requests
  Roman Kapustin · 2019-12-28 18:07:55 +03:00
  e8bcb52612
• CA2201: throw correct exception type.
  Huo Yaoyuan · 2019-12-17 13:00:02 +08:00
  d7b3578cc6
• Apply fixes
  Dean Herbert · 2019-11-25 11:30:55 +09:00
  45514ff660
• Update obsolete usages
  Dean Herbert · 2019-11-21 10:55:31 +09:00
  19dfbb0a45
• Get error message from server
  Dean Herbert · 2019-11-12 19:34:20 +09:00
  58df6930b2
• Use isolated storage/api
  Dean Herbert · 2019-09-25 15:00:08 +09:00
  c83db94eb7
• Avoid calling api request callback after user cancel
  Dean Herbert · 2019-06-25 13:52:43 +09:00
  90acc9b6ca
• Use interface to access API

  Allows for better testability.

  Dean Herbert · 2019-03-13 12:58:18 +09:00
  f0114d776d
• Fix remaining issues
  Dean Herbert · 2019-02-28 13:31:40 +09:00
  26d53d06a9
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Merge remote-tracking branch 'upstream/master' into timeshift-wip
  Dean Herbert · 2018-12-26 22:42:24 +09:00
  bfbd7e5106
• Fix cancelled webrequests triggering exceptions
  smoogipoo · 2018-12-26 21:17:10 +09:00
  bee4e8ad28
• Merge remote-tracking branch 'origin/master' into timeshift-wip

  # Conflicts:
  #	osu.Game.Tests/Visual/TestCasePollingComponent.cs
  #	osu.Game/Online/API/APIRequest.cs
  #	osu.Game/osu.Game.csproj

  smoogipoo · 2018-12-21 12:51:31 +09:00
  5d59a1ffca
• Remove all retry logic and simplify overall handling of API requests
  Dean Herbert · 2018-12-18 20:20:17 +09:00
  6088612a26