38 Commits

• Always convert mania spinners

  A big part of these changes is refactoring, which is somewhat necessary
  because it was previously implemented as two separate pathways which
  in-fact need to be joined at the hip when handling spinners.
  
  I've chosen to use `IHasLegacyHitObjectType` here because there's no
  other flag that allows us to tell `ConvertHold` apart from
  `ConvertSpinner`.

  Dan Balasescu · 2024-12-06 16:40:28 +09:00
  8b456e1379
• Add IHasLegacyHitObjectType to ConvertHitObject
  Dan Balasescu · 2024-11-11 16:10:15 +09:00
  7206e97b7b
• Add ScoreV2 to LegacyMods
  Bartłomiej Dach · 2023-07-09 16:06:05 +02:00
  10ba04512d
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Remove redundant nullable suppression directives
  Salman Ahmed · 2023-06-07 08:20:41 +03:00
  62cb6a98ca
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Throw rather than ignore on invalid control point addition
  Dean Herbert · 2021-09-06 22:04:37 +09:00
  eabca016d4
• Change SamplePoints to be SortedList for conformity
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  8f24ea54ee
• Fix regression in SampleControlPoint add logic
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  2b9157987e
• Move DifficultyControlPoints list to LegacyControlPointInfo
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  db3fc1d4af
• Remove unnecessary variable discard

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-08-31 15:08:07 +09:00
  448c58c35d
• Fix early return causing event loss in case of multiple control points in group
  Dean Herbert · 2021-08-30 18:33:05 +09:00
  1aaea7011a
• Remove redundant null coalesce
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  6fd24a5d92
• Move to legacy namespace
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  ccacf56dd8
• Add legacy flag value for mirror mod
  Bartłomiej Dach · 2020-08-29 11:45:59 +02:00
  658a1d159f
• Add overlay layer to enumeration type
  Bartłomiej Dach · 2020-05-18 22:45:31 +02:00
  9415e45aea
• Switch back to strings and update setting labels
  voidedWarranties · 2020-03-12 23:29:11 -07:00
  c27751050b
• Code quality, read position offsets
  voidedWarranties · 2020-03-08 14:02:39 -07:00
  22dd93a4f6
• Add missing headers
  smoogipoo · 2019-12-13 19:14:49 +09:00
  9bc02f489e
• Extract the rest of legacy enums
  smoogipoo · 2019-12-10 20:23:15 +09:00
  c378e525da
• Extract legacy effect flags enum
  smoogipoo · 2019-12-10 20:19:31 +09:00
  3c18872a16
• Extract legacy hitobject type enum
  smoogipoo · 2019-12-10 20:19:16 +09:00
  e3f925f69a
• Extract legacy sound type enum
  smoogipoo · 2019-12-10 20:18:44 +09:00
  8012b21ffa
• Apply new resharper refactors
  Dean Herbert · 2019-08-09 12:29:33 +09:00
  7e9c100c9b
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Remove LegacyBeatmap
  smoogipoo · 2018-04-19 18:58:45 +09:00
  ac64f9d958
• Make an interface for beatmaps
  smoogipoo · 2018-04-19 18:58:40 +09:00
  b5a55a0dce
• Review changes
  tgi74000 · 2018-04-16 14:14:40 +02:00
  9b36cf2066
• Add support for replay mods
  tgi74000 · 2018-04-13 15:41:35 +02:00
  b23b0a445b
• Normalize all the line endings
  Dean Herbert · 2018-04-13 18:26:38 +09:00
  32a74f95a5
• Update licence headers
  Dean Herbert · 2018-01-05 20:21:19 +09:00
  37d393bca0
• What even was this lol.
  smoogipooo · 2017-03-18 18:38:51 +09:00
  b68b017a49
• Remove IIsLegacy, expose LegacyBeatmap without a public constructor.
  smoogipooo · 2017-03-18 18:32:54 +09:00
  26b0bb02d8
• Fix nullref.
  smoogipooo · 2017-03-17 14:56:50 +09:00
  74a1837a05
• Add license headers.
  smoogipooo · 2017-03-17 14:51:09 +09:00
  67c9bb37fd
• Add legacy beatmap flag.
  smoogipooo · 2017-03-17 14:24:46 +09:00
  862c4c408f