31 Commits

• Adjust interpolation workaround to catch-up slightly smoother
  Dean Herbert · 2025-08-29 21:24:23 +09:00
  41b8033ebd
• Add comprehensive log output to help figure out problematic clocks
  Dean Herbert · 2024-02-29 23:05:28 +08:00
  cc8b838bd4
• Change userBeatmapOffsetClock to a FramedOffsetClock

  Assuming that the global audio offset is set perfectly, such that
  any audio latency is fully accounted for, if a specific beatmap
  still sounds out of sync, that would no longer be a latency issue.
  
  Instead, it would indicate a misalignment between the beatmap's
  track and time codes, the correction for which should be a
  virtual-time offset, not a real-time offset.

  Mike Will · 2024-02-19 09:14:49 -05:00
  012d6b7fe1
• Remove "pause rate adjust" flow
  Dean Herbert · 2024-01-18 14:21:02 +09:00
  8ab8c90e33
• Fix double interpolation being applied when applyOffsets=false
  Dean Herbert · 2023-10-05 13:20:52 +09:00
  f8455af0d0
• Update in line with framed clock changes
  Dean Herbert · 2023-09-22 22:02:18 +09:00
  d019cb5167
• Fix FramedBeatmapClock's source not being processed
  Dean Herbert · 2023-09-22 16:22:35 +09:00
  6629a47ed3
• Set source directly in FramedBeatmapClock ctor

  This isn't required, but avoids creating a temporary `StopwatchClock`
  and generally just makes debug easier with less state changes.

  Dean Herbert · 2023-09-22 16:22:35 +09:00
  bf08fbe196
• Add note about beatmap offset not being reapplied correctly on ChangeSource
  Dean Herbert · 2023-09-22 14:41:07 +09:00
  0200b63fd3
• Remove hopefully-unnecessary workaround

  It was causing issues with the new implementation.

  Dean Herbert · 2023-09-22 14:41:05 +09:00
  a451ab75dd
• Disable decoupling for OsuGameBase's beatmap implementation

  This avoids it ever mutating the underlying track (aka attempting to start
  it). Resolves the one caveat mentioned in
  aeef92fa710648d4a00edc523e13c17ac6104125.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  df08c4e1ad
• Remove unnecessary encapsulation workaround

  The new implementation of `DecouplingClock` will not mutate the
  underlying clock in any way (unless attempting to start it when
  approaching from a negative time value).
  
  This should be quite safe as a result.

  Dean Herbert · 2023-09-22 12:49:25 +09:00
  5f634f2812
• Simplify some pieces of FramedBeatmapClock
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  21a2e27e5f
• Fix interpolation not being applied when applyOffsets is set
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  04e6ec8715
• Update usage of DecoupleableInterpolatingFramedClock in FramedBeatmapClock
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  117cd74af6
• Change FramedBeatmapClock to always be decoupled
  Dean Herbert · 2023-09-22 12:49:25 +09:00
  600651795b
• Update clocks in line with framework changes
  Dean Herbert · 2023-09-20 21:17:08 +09:00
  bf984388b3
• Add lenience to FramedBeatmapClock workaround
  Dean Herbert · 2023-08-02 18:49:24 +09:00
  75c1d5ad7f
• Expose rewinding state of IGameplayClocks

  The implementation of this requires a bit of a special case
  for 0, so makes sense to implement in a central place.

  Dean Herbert · 2023-07-06 19:08:42 +09:00
  2e98ab0a48
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Avoid double call to ProcessFrame
  Dean Herbert · 2022-09-09 14:35:47 +09:00
  d6748d6921
• Compare with decoupled clock directly to avoid including offsets
  Dean Herbert · 2022-09-09 14:35:35 +09:00
  64cf6b9014
• Fix beat sync stopping after returning to menu from a failed play

  Closes #20193.
  
  Explanation is inline comment.

  Dean Herbert · 2022-09-09 14:13:03 +09:00
  20ffbc4676
• Account for offset being applied to editor clock time in TestSceneEditorClock
  Dean Herbert · 2022-08-29 16:42:50 +09:00
  2dafa041a7
• Avoid setting the source clock until gameplay is ready to start

  Without this change, the audio track may audibly seek during load
  proceedings.

  Dean Herbert · 2022-08-23 18:34:17 +09:00
  29fed0c4a3
• Fix incorrect implicit null specification for user audio offset bindable
  Dean Herbert · 2022-08-22 14:03:51 +09:00
  17a1df281c
• Make FramedBeatmapClock.Track non-null
  Dean Herbert · 2022-08-22 14:02:41 +09:00
  ba23ce75c2
• Reword class xmldoc to better explain that offset application is optional
  Dean Herbert · 2022-08-22 14:02:20 +09:00
  85d0b7fc57
• Add xmldoc and reorganise FramedBeatmapClock
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  bcc153f738
• Use FramedBeatmapClock in GameplayClockContainer
  Dean Herbert · 2022-08-18 18:54:10 +09:00
  6003afafc7
• Add FramedBeatmapClock

  Expose `IsCoupled` in `FramedBeatmapClock` for now to provide editor compatibility

  Dean Herbert · 2022-08-18 18:54:10 +09:00
  32e127a6fa