29 Commits

• Add inline note about deadlock
  Dean Herbert · 2023-12-26 12:06:56 +09:00
  b18b5b9977
• Do not attempt to stop preview tracks when arriving from a "track completed" sync

  This fixes an issue identified with the WASAPI implementation in
  https://github.com/ppy/osu-framework/pull/6088. It has no real effect
  on current `master`, but fixes a deadlock that occurs with the
  aforementioned framework branch when one lets a preview track play out
  to the end - at this point all audio will stop and an attempt to perform
  any synchronous BASS operation (playing another track, seeking) will
  result in a deadlock.
  
  It isn't terribly clear as to why this is happening precisely, but
  there does not appear to be any need to stop and seek at that point,
  so this feels like a decent workaround even if the actual issue is
  upstream (and will unblock pushing out WASAPI support to users).

  Bartłomiej Dach · 2023-12-25 19:01:06 +01:00
  f84b07e71a
• Reset preview track when stopping instead
  Joseph Madamba · 2023-02-13 22:39:34 -08:00
  ea624b8ad0
• Fix disposal of playing preview track not unmuting game track
  Salman Ahmed · 2022-12-05 14:45:32 +03:00
  a457a2fbbf
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix PreviewTrack not disposing its owned audio Track
  Dean Herbert · 2022-08-05 14:15:01 +09:00
  786af81274
• Mark the GetTrack() return type as nullable.
  andy840119 · 2022-07-31 22:01:30 +08:00
  094793bbe3
• Rename the nullable disable annotation in the Audio namespace and mark some properties as nullable.
  andy840119 · 2022-07-31 22:00:14 +08:00
  6c964dee30
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Private set on track for safety
  Dean Herbert · 2019-11-12 15:13:47 +09:00
  47be20fa37
• Change Track and TrackManagerPreviewTrack accessibilities
  iiSaLMaN · 2019-11-10 23:09:04 +03:00
  9d61d73ced
• Merge remote-tracking branch 'upstream/master' into fix-network-stalls
  Dean Herbert · 2019-11-06 19:06:28 +09:00
  91bcb5d4a7
• Fix audio preview muting game audio indefinitely when beatmap panel is off-screen
  Dean Herbert · 2019-11-06 15:58:47 +09:00
  c1a6cb1def
• Use LongRunningLoad on network load components
  Dean Herbert · 2019-11-01 19:40:45 +09:00
  ddd58ea3da
• Fix audio preview buttons not correctly handling load failure states

  Closes #4593.

  Dean Herbert · 2019-05-23 12:07:49 +09:00
  372c5b081c
• Enable more stringent inspectcode style inspections
  Dean Herbert · 2019-02-27 21:25:40 +09:00
  c8793911a8
• Fix crossthread operations due to Track.Completed
  smoogipoo · 2019-02-27 16:52:34 +09:00
  30815ace62
• Merge remote-tracking branch 'ppy/master' into notify_track_completion_failure
  Roman Kapustin · 2019-02-03 16:14:04 +03:00
  71efbcf603
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Stop PreviewTrack on Completed event
  Roman Kapustin · 2018-11-17 15:23:52 +03:00
  befe57e12e
• Apply some code review
  Dean Herbert · 2018-06-22 12:33:30 +09:00
  4b2b1f51f9
• Add testcases
  smoogipoo · 2018-06-21 19:31:07 +09:00
  1932399521
• XMLDoc all the things
  smoogipoo · 2018-06-21 18:54:50 +09:00
  63a6fc2596
• Rework preview tracks to reduce usage complexities
  smoogipoo · 2018-06-21 18:40:27 +09:00
  b2066c5d73
• Make PreviewTrack.owner private
  Roman Kapustin · 2018-06-02 22:06:45 +03:00
  9b69e1825d
• Make PreviewTrack a component and use LoadComponentAsync
  Roman Kapustin · 2018-06-01 23:36:25 +03:00
  330ce19041
• Get rid of PreviewTrackManager.onTrackStart and PreviewTrackManager.onTrackStop delegates
  Roman Kapustin · 2018-06-01 21:36:30 +03:00
  5566732664
• PreviewTrack.Owner
  Roman Kapustin · 2018-06-01 21:06:37 +03:00
  88ac427ba6
• Introduce PreviewTrack class
  Roman Kapustin · 2018-05-25 00:37:53 +03:00
  498244a308