736 Commits

• Fix intermittent collection dropdown tests
  Dan Balasescu · 2025-09-23 18:23:41 +09:00
  37e661b27e
• Add test coverage
  Bartłomiej Dach · 2025-09-03 12:05:03 +02:00
  15d73ce07e
• Fix test
  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  1319a5499b
• Fix tests (they're using LocalisableStrings now)
  Denis Titovets · 2025-07-10 21:58:05 +03:00
  d5fe7e20be
• Fix tests #2
  Denis Titovets · 2025-07-09 18:14:34 +03:00
  7c6f0d1d11
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Fix SHOCKING test

  What the actual heck is that magic number stupidity.
  
  I'm not looking into why the test falls over so badly that it apparently
  dies on some main menu logic just because assertions fail, because the
  main menu logic is for hold-to-song-select-v2 and is thus temporary.

  Bartłomiej Dach · 2025-06-13 10:34:14 +02:00
  f4bf2ae7a5
• Fix flaky collections test
  Dan Balasescu · 2025-06-09 21:53:19 +09:00
  83ce468c57
• Add debounce to difficulty calculation operations in churn scenarios
  Dean Herbert · 2025-05-19 16:16:33 +09:00
  192a1642d4
• Fix test in old song select not working on Apple platforms
  Salman Alshamrani · 2025-05-03 05:38:00 +03:00
  109b29c1da
• Update existing test cases
  Salman Alshamrani · 2025-04-30 02:24:37 +03:00
  dcbb7209df
• Adjust namespaces and naming
  Dean Herbert · 2025-04-22 17:03:28 +09:00
  ec854f7b7f
• Move collection dropdown test coverage to isolated test scene
  Salman Alshamrani · 2025-04-17 09:09:46 -04:00
  a6a8e2a44f
• Fix garbage data in test case
  Bartłomiej Dach · 2025-04-17 11:37:28 +02:00
  5f4afe156f
• Make some test methods static for future reuse
  Dean Herbert · 2025-04-16 19:41:49 +09:00
  2ac1b89037
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Add failing test
  Bartłomiej Dach · 2025-04-16 10:27:05 +02:00
  64b9d4642a
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Reduce bleed in tests to allow them to pass
  Bartłomiej Dach · 2025-04-11 10:13:49 +02:00
  9911e0819e
• Fix carousel handling of bleed areas

  The idea of specifying "bleed" is to make the carousel aware of its
  vertical display area. The top bleed is under the filter control; bottom
  beneath the toolbar. At the end of the day, the point of panel X offset
  incursion, and the scroll target for current selection, should be at the
  centre of the screen.
  
  The fixes match code which already exists in the previous
  implementation. Basically, without incorporating `BleedTop` into
  calculations a second time, the centre position would not match
  expectations (of being the centre including bleed).

  Dean Herbert · 2025-04-11 00:05:51 +09:00
  f9112066d3
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Split tracker into per-system implementations
  Dan Balasescu · 2025-03-25 14:56:12 +09:00
  53ece9396a
• Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  RFC. Another attempt at this.
  
  - Supersedes https://github.com/ppy/osu/pull/31881
  - Supersedes / closes https://github.com/ppy/osu/pull/31355
  - Closes https://github.com/ppy/osu/issues/29861
  
  This is a weird diff because I am feeling rather boxed in by all the
  constraints, namely that:
  
  - Leaderboard state should be global state
  - But the global state is essentially managed by song select and namely
    `BeatmapLeaderboard` itself. That's because trying to e.g. not have
    `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
    leaderboard manager is worse, as it essentially introduces two
    parallel paths of execution that need to be somehow merged into one
    (as in I'd have to somehow sync `LeaderboardManager` responding to
    beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
    hell)
  - Also local leaderboard fetching is data-push (as in the scores can
    change under the leaderboard manager), and online leaderboard fetching
    is data-pull (as in the scores do not change unless the leaderboard
    manager does something). Also online leaderboard fetching can fail.
    Which is why I need to still have the weird setup wherein there's a
    `FetchWithCriteriaAsync()` (because I need to be able to respond to
    online requests taking time, or failing), but also the
    `BeatmapLeaderboard` only uses the public `Scores` bindable to
    actually read the scores (because it needs to respond to new local
    scores arriving).
  - Another thing to think about here is what happens when a retrieval
    fails because e.g. the user requested friend leaderboards without
    having supporter. With how this diff is written, that special
    condition is handled to `BeatmapLeaderboard`, and
    `LeaderboardManager`'s state will remain as whatever it was before
    that scope change was requested, which may be considered good or it
    may not (I imagine it's better to show scores in gameplay than not in
    this case, but maybe I'm wrong?)

  Bartłomiej Dach · 2025-03-21 12:06:16 +01:00
  0209129618
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Add visual test coverage
  Bartłomiej Dach · 2025-03-07 08:51:55 +01:00
  33dccfcec8
• Try to fix test
  Bartłomiej Dach · 2025-03-05 12:32:58 +01:00
  7975c301a8
• Add failing test coverage
  Bartłomiej Dach · 2025-03-05 09:21:47 +01:00
  abc4955e81
• User inheritance to avoid Piece structural nightmare
  Dean Herbert · 2025-02-18 16:52:18 +09:00
  88ec204d26
• Merge branch 'master' into carousel-v2-implement-designs
  Dean Herbert · 2025-02-18 15:49:34 +09:00
  40cae4f0a5
• Rename classes for better discoverability / grouping
  Dean Herbert · 2025-02-12 19:34:42 +09:00
  554884710c
• Fix failing test
  Dean Herbert · 2025-02-07 21:46:00 +09:00
  5ace8e911b
• Merge branch 'master' into carousel-v2-implement-designs
  Dean Herbert · 2025-02-07 19:37:06 +09:00
  d8f3dbf988
• Merge pull request #31823 from peppy/carousel-v2-optimisation-pass

  Refactor grouping to be much more efficient

  Bartłomiej Dach · 2025-02-07 10:44:53 +01:00
  a068d88b84
• Merge pull request #31824 from peppy/carousel-v2-group-click-transfer-keyboard

  Always transfer keyboard selection on activation

  Bartłomiej Dach · 2025-02-07 10:12:10 +01:00
  ae179c8feb
• Reduce number of beatmaps added in selection test

  This is because with the new keyboard selection logic, adding too many
  can cause the re-added selection to be off-screen in the headless test
  setup.

  Dean Herbert · 2025-02-07 17:02:53 +09:00
  cef9d2eac5
• Always transfer keyboard selection on activation
  Dean Herbert · 2025-02-07 17:02:53 +09:00
  c935c3154b
• Use random generation in carousel stress test
  Dean Herbert · 2025-02-07 16:09:35 +09:00
  75ef6f6a0e
• Remove stray [Solo]s
  Dean Herbert · 2025-02-07 15:30:31 +09:00
  aa329f397e
• Adjust tests in line with new expectations
  Dean Herbert · 2025-02-07 15:27:28 +09:00
  d505c529cd
• Merge branch 'master' into carousel-v2-spacing
  Dean Herbert · 2025-02-07 14:34:59 +09:00
  1cf375e329
• Merge pull request #31801 from peppy/carousel-v2-artist-grouping

  Add support for grouping by artist to beatmap carousel v2

  Bartłomiej Dach · 2025-02-06 13:13:35 +01:00
  91bc23e39e
• Merge branch 'master' into carousel-v2-spacing
  Dean Herbert · 2025-02-06 17:30:49 +09:00
  33035f0206
• Refactor selection and activation handling

  I had a bit of a struggle getting header traversal logic to work well.
  The constraints I had in place were a bit weird:
  
  - Group panels should toggle or potentially fall into the prev/next
    group
  - Set panels should just traverse around them
  
  The current method of using `CheckValidForGroupSelection` return type
  for traversal did not mesh with the above two cases. Just trust me on
  this one since it's quite hard to explain in words.
  
  After some re-thinking, I've gone with a simpler approach with one
  important change to UX: Now when group traversing with a beatmap set
  header currently keyboard focused, the first operation will be to reset
  keyboard selection to the selected beatmap, rather than traverse.
  
  I find this non-offensive – at most it means a user will need to press
  their group traversal key one extra time.
  
  I've also changed group headers to always toggle expansion when doing
  group traversal with them selected.
  
  To make all this work, the meaning of `Activation` has changed somewhat.
  It is now the primary path for carousel implementations to change
  selection of an item. It is what the `Drawable` panels call when they
  are clicked.
  
  Selection changes are not performed implicitly by `Carousel` – an
  implementation should decide when it actually wants to change the
  selection, usually in `HandleItemActivated`.
  
  Having less things mutating `CurrentSelection` is better in my eyes, as
  we see this variable as only being mutated internally when utmost
  required (ie the user has requested the change). With this change,
  `CurrentSelection` can no longer become of a non-`T` type (in the
  beatmap carousel implementation at least).
  
  This might pave a path forward for making `CurrentSelection` typed, but
  that comes with a few other concerns so I'll look at that as a
  follow-up.

  Dean Herbert · 2025-02-06 17:02:44 +09:00
  024fbde0fd
• Move selected retrieval functions to base class
  Dean Herbert · 2025-02-06 16:48:17 +09:00
  4026ca84f8
• Add test coverage of artist grouping
  Dean Herbert · 2025-02-06 16:48:17 +09:00
  a25e1f4f9b
• Fix helper method in carousel test scene
  Salman Alshamrani · 2025-02-06 02:44:52 -05:00
  aa9727c020
• Reorganise tests to make more logical when manually testing
  Dean Herbert · 2025-02-06 15:09:41 +09:00
  bf377e081a
• Move metadata randomisation local to usage
  Dean Herbert · 2025-02-06 14:07:50 +09:00
  0257b8c2ff
• Fix carousel tests failing due to X offsets
  Salman Alshamrani · 2025-02-05 22:25:39 -05:00
  5e894a6f7e