osu-lazer

Refactor hit windows class structure to reduce rigidity

This change pulls back a significant degree of overspecialisation and
rigidity in the class structure of `HitWindows` to make subsequent
changes to hit windows, whose purpose is to improve replay playback
accuracy, possible to do cleanly.

Notably:

- `HitWindows` is full abstract now. In a few use cases, and as a
  reference for ruleset implementors, `DefaultHitWindows` is provided as
  a separate class instead.

  This fixes the weirdness wherein `HitWindows` always declared 6 fields
  for result types but some of them would never be set to a non-zero
  value or read.

- `HitWindow.GetRanges()` is deleted because it is overspecialised and
  prevents being able to adjust hitwindows by ±0.5ms cleanly which will
  be required later.

  The fallout of this is that the assertion that used `GetRanges()` in
  the `HitWindows` ctor must use something else now, and the closest
  thing to it was `GetAllAvailableWindows()`, which didn't return
  the miss window - so I made it return the miss window and fixed the
  one consumer that didn't want it (bar hit error meter) to skip it.

- Diff also contains some clean-up around `DifficultyRange` to unify
  handling of it.

Bartłomiej Dach · 2025-06-25 08:40:12 +02:00

8b542e5442

Add flag to allow backwards seeks in tests

Dean Herbert · 2024-02-29 23:05:28 +08:00

4184a5c1ef

Generalize Bezier curves to BSplines of Nth degree

Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00

926636cc03

Merge branch 'master' into taiko-hitsounding-final-attempt

Bartłomiej Dach · 2023-07-08 18:10:04 +02:00

055e4a78f0

Add sample trigger tests covering rewinding of gameplay

Dean Herbert · 2023-07-06 19:08:42 +09:00

7a3a14e50d

Fix weird test assertion output

Dean Herbert · 2023-07-05 18:44:27 +09:00

51b0d18c04

Fix errors in tests due to mismatching NRT annotations

Bartłomiej Dach · 2023-06-20 21:57:32 +02:00

2f77675fe7

Update test expectations

Dean Herbert · 2023-06-20 21:02:34 +09:00

92e89c7df7

Use IGameplayClock to ensure our clock source is correct

Dean Herbert · 2023-06-20 20:47:56 +09:00

04dad6c6e8

Update new usages of "soft" to use the new constant

Dean Herbert · 2023-05-24 14:04:10 +09:00

e68ba6366c

Merge branch 'master' into sample-set-controls

Dean Herbert · 2023-05-24 14:03:04 +09:00

298989ffd2

remove all test usages of SampleControlPoint

OliBomby · 2023-04-26 14:21:52 +02:00

c6fc180659

Update assertion to also check GameplayClockContainer's current time

Dean Herbert · 2023-02-22 15:26:09 +09:00

f61fbcf3fc

Seek using GameplayClockContainer

Dean Herbert · 2023-02-22 14:41:20 +09:00

a511e64fa5

Update slider sample source asserts to match expected behaviour

As pointed out in review, if the current time is after the end of the
slider, the correct hit object to use for sample retrieval is the object
itself, not any nested object.

Dean Herbert · 2023-02-21 14:04:38 +09:00

9321ec29dc

Add wait steps to ensure frame-stable clock has caught up before checking state

Dean Herbert · 2023-02-21 14:04:19 +09:00

e686b4393e

Merge branch 'master' into fix-taiko-drum-nested-sample-detection

Bartłomiej Dach · 2023-02-16 19:43:02 +01:00

2fdf1fd876

Add one more assert to keep coverage from previous implementation

Bartłomiej Dach · 2023-02-16 19:02:51 +01:00

5bdc5dfadd

Add test coverage of GameplaySampleTriggerSource not considering nested objects