1804 Commits

• Demonstrate failure in test
  Bartłomiej Dach · 2025-09-13 10:50:33 +09:00
  a9c021ce04
• Always show the same number of placeholder digits in argon judgement counter when it is vertical
  Bartłomiej Dach · 2025-09-03 13:42:17 +02:00
  98c3437174
• Fix abysmal code quality
  Bartłomiej Dach · 2025-09-03 13:23:12 +02:00
  a56f81a731
• Merge branch 'master' into argon-judgement-counter
  Bartłomiej Dach · 2025-09-03 13:01:57 +02:00
  dac534e22a
• Add test coverage and fix one more fail case
  Dean Herbert · 2025-08-26 18:41:14 +09:00
  2ccb65aa65
• Merge pull request #34643 from frenzibyte/leaderboard-resize

  Fix leaderboard not resizing correctly

  Dean Herbert · 2025-08-21 13:33:24 +09:00
  41885c0fc0
• Add test for scores with long score/combo numbers
  Salman Alshamrani · 2025-08-18 13:46:51 +03:00
  bb5933ef80
• Merge pull request #34612 from frenzibyte/auto-beatmap-offset

  Add setting for adjusting beatmap offset automatically based on last play

  Dean Herbert · 2025-08-15 23:33:32 +09:00
  99dc2bb58f
• Merge pull request #34628 from bdach/show-results-on-failed-replay

  Show indicator in replay player once replay fails

  Dean Herbert · 2025-08-15 19:33:47 +09:00
  a14d7a23bd
• Merge pull request #34662 from bdach/refetch-leaderboard-on-retry

  Refetch leaderboard when (slow) retrying a beatmap

  Dean Herbert · 2025-08-15 18:29:17 +09:00
  46744c6f15
• Remove failing test

  Test was added in 5495c2090a to exercise a
  previous version of the hotfix-workaround of not allowing seeking back.
  Now that the hotfix-workaround also encompasses seeking *forward*, which
  breaks another 100 tests, thus requiring the hotfix-workaround to be
  turned off for tests, this situation is just completely out of
  control. So I'm just removing the test because ugh.

  Bartłomiej Dach · 2025-08-15 10:01:10 +02:00
  126d0c6bdb
• Add failing test
  Bartłomiej Dach · 2025-08-14 14:18:25 +02:00
  116a45c9cb
• Add failing test case
  Salman Alshamrani · 2025-08-14 13:47:58 +03:00
  69b6166e58
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Add ability to resize leaderboard in tests
  Salman Alshamrani · 2025-08-13 12:51:09 +03:00
  62803af1de
• Show indicator in replay player once replay fails

  This indicator allows the player to either rewind to an earlier part of
  the replay, or to proceed to results. It also plays a shortened variant
  of the failure animation SFX.

  Bartłomiej Dach · 2025-08-12 14:25:58 +02:00
  35a472ae39
• Merge pull request #34592 from Hiviexd/feature/argon-unstable-rate-counter

  Add "Argon" unstable rate counter

  Bartłomiej Dach · 2025-08-12 14:06:39 +02:00
  4bed784a20
• Fix test scene doing very weird things for (seemingly) no reason
  Bartłomiej Dach · 2025-08-12 13:21:16 +02:00
  e3f2ffe19c
• Update test coverage
  Salman Alshamrani · 2025-08-12 11:05:53 +03:00
  cd416214f2
• add extra test
  Hivie · 2025-08-11 14:13:05 +01:00
  2cab4350ca
• Remove bindable added only for tests
  Dean Herbert · 2025-08-11 21:07:55 +09:00
  e93d15ef0e
• Add back comment regarding bad bindable casting
  Dean Herbert · 2025-08-11 20:57:01 +09:00
  9d6a0208f1
• Merge branch 'master' into game-leaderboard-redesign
  Dean Herbert · 2025-08-11 19:20:13 +09:00
  2ff8393603
• Add test coverage
  Salman Alshamrani · 2025-08-11 10:37:31 +03:00
  b351f0187d
• refactor tests to use both UR counter variants
  Hivie · 2025-08-09 22:34:57 +01:00
  2af8066c4d
• Merge pull request #33530 from JackArmstrong22/fix-negative-zero-audio-offset

  Fix beatmap offset control potentially reporting negative zero

  Dean Herbert · 2025-07-23 16:54:33 +09:00
  9f6b156d0c
• Add test coverage of incorrect formatting output

  Fix a cosmetic UI issue where -0.0 is displayed when clicking the Calibrate using last play button.
  
  Removed changes to AudioOffsetAdjustControl and added check to ToStandardFormattedString for if floatValue is 0

  Dean Herbert · 2025-07-23 14:47:38 +09:00
  44531794a1
• Rewrite gameplay leaderboard test scene to be usable

  At some point during the leaderboard data refactor, this test scene
  became completely unusable. This change rewrites it to use
  `SoloGameplayLeaderboardProvider` to be able to witness the user score
  being resorted and advancing through the leaderboard.

  Salman Alshamrani · 2025-07-22 23:58:06 +03:00
  84a36b1bfa
• Fix tests
  Bartłomiej Dach · 2025-07-22 10:11:16 +02:00
  b9bda61e27
• Store pause timestamps (rounded to ms) instead of general count
  Bartłomiej Dach · 2025-07-22 09:26:12 +02:00
  d8900defd3
• Track count of times gameplay was paused on ScoreInfo
  Bartłomiej Dach · 2025-07-07 11:00:30 +02:00
  f082b60c9b
• Fix player settings no longer collapsing correctly

  Regressed with https://github.com/ppy/osu/pull/33621 for obvious
  reasons. Tachyon doing its job, caught this before hitting a proper
  release.

  Dean Herbert · 2025-06-30 16:57:51 +09:00
  d1c0d58f2e
• Merge pull request #33670 from bdach/ensure-replays-are-played-to-end

  Ensure partial failed replays are played to their end

  Dean Herbert · 2025-06-30 15:56:13 +09:00
  768d44596a
• Fix flaky TestSceneGameplaySamplePlayback test

  See: https://github.com/ppy/osu/actions/runs/15924307907/job/44920278903
  
  Similar null-checks within `Update()` are present in the
  `PlayerTestScene` superclass.

  Dan Balasescu · 2025-06-29 00:24:12 +09:00
  5c89644d58
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Add failing test scene
  Bartłomiej Dach · 2025-06-12 14:03:52 +02:00
  e59f9b1aa7
• Merge pull request #33630 from peppy/leaderboard-always-expand-setting

  Add a skin-level setting to leaderboard to allow disabling automatic collapsing

  Bartłomiej Dach · 2025-06-12 11:16:17 +02:00
  d13676fcc6
• Combine two similar flags into one
  Dean Herbert · 2025-06-12 17:27:23 +09:00
  ebfc3c9ccf
• Adjust tests based on changed behaviour

  Calibration no longer goes away on missing / invalid scores.

  Dean Herbert · 2025-06-11 22:47:47 +09:00
  90877a079c
• Adjust commentary to not suck

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2025-06-11 15:55:08 +09:00
  38ad48bb35
• Allow using previous valid score for offset calibration when subsequent retries are too short

  As proposed in https://github.com/ppy/osu/discussions/33572.
  
  Note that this won't work if you leave to song select. We could make
  that work but it would require further global faffing and I don't think
  it's worth the effort.

  Dean Herbert · 2025-06-11 15:26:02 +09:00
  cdb2f216f2
• Disallow placing gameplay leaderboard in skins outside player

  Closes https://github.com/ppy/osu/issues/33542.
  
  For a diff this simple this took much more hemming and hawing because
  things are a bit annoying here from a few angles:
  
  - The only way that is considered idiomatic right now for a skin
    component to not be applicable to a screen is to require a dependency
    from DI that is only provided by applicable screens.
    `DrawableGameplayLeaderboard` has a few of those dependencies, but the
    scope of all the usages makes it so that the only really viable one to
    use here is `IGameplayLeaderboardProvider` itself (see: visual tests,
    and also the usage of multiplayer spectator, where the leaderboard is
    *not* under a player instance).
  
  - The smelly part of this is that the `Player` inheritance hierarchy
    must ensure that *every* non-abstract class has an
    `IGameplayLeaderboardProvider` cached. It is not trivial - if not
    straight up impossible - to force this via some `Player` level
    abstract method, because such a method would need to somehow
    accommodate all possible leaderboard providers. That however also
    means that every possible future `Player` implementor *must inherently
    know* to also cache a leaderboard provider lest it die at runtime. I
    don't love that, but I also don't see better alternatives.
  
  - Speaking of which, I also noticed that solo spectator and playlists
    don't have gameplay leaderboards. At all. Which I don't believe to be
    something that I broke with the leaderboard work - I'm pretty sure
    that was the pre-existing state - however I don't see any reason why
    they *couldn't* receive gameplay leaderboards. I'm not doing that
    here, though, just leaving TODOs for later.

  Bartłomiej Dach · 2025-06-09 13:11:29 +02:00
  6416f59c7b
• Fix general confusion in which combo should be read on which gameplay leaderboard

  Closes https://github.com/ppy/osu/issues/33455.
  
  The fundamental misunderstanding and source of confusion in
  https://github.com/ppy/osu/pull/33062 is that solo wants to show
  *maximum combo*, and multiplayer wants to show *current combo*, for
  their own, valid reasons. Which is spelled out explicitly in this
  change.

  Bartłomiej Dach · 2025-06-06 10:08:01 +02:00
  a92a659662
• Fix replays being misrecorded if an action is pressed and released in one update frame

  Closes https://github.com/ppy/osu/issues/33465 probably.
  
  This reverts the replay frame de-duplication logic to what it was before
  https://github.com/ppy/osu/pull/33148#discussion_r2091549388.
  
  I don't have good reproduction steps. I tried to write a test case for
  this that isn't just "press and release a key in the same frame",
  thinking that maybe there was some loophole in the osu! touch input
  mapper that may produce this situation artificially, but I could not in
  many configurations. So I have to assume that this just *can happen*
  organically.

  Bartłomiej Dach · 2025-06-06 09:10:51 +02:00
  12cc8e38da
• Mark some more recent flaky tests
  Dean Herbert · 2025-06-03 16:23:31 +09:00
  ef29eda3e0
• Fix rider EAP new naming inspections
  Dean Herbert · 2025-05-25 20:39:55 +09:00
  5e3fd7a42a
• Expose total scores count from backend
  Salman Alshamrani · 2025-05-22 00:57:49 +03:00
  6bc407310e
• Merge pull request #32972 from bdach/multiplayer-position-indicator

  Add non-skinnable position indicator to multiplayer player

  Dean Herbert · 2025-05-13 20:53:15 +09:00
  3ce5389558
• Fix test not showing immediately useful state

  Also standardises the testing leaderboard provider component for
  (immediate) future use.

  Dean Herbert · 2025-05-13 15:53:47 +09:00
  1d7f922068
• Merge pull request #33075 from bdach/do-not-allow-reading-garbage-from-hitwindows

  Fix `HitWindows.WindowFor()` returning values for invalid results

  Dean Herbert · 2025-05-09 22:24:26 +09:00
  afe8ab842d