19 Commits

• Fix "spins per minute" shows up early #31173

  Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.
  
  Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

  Rudi Herouard · 2025-04-13 23:35:44 +02:00
  7cdbc2c20a
• Update usage of MathUtils
  Dean Herbert · 2024-03-06 12:13:12 +08:00
  b53b752e54
• Fix incorrect assertion placement in spinner rotation tracker

  Checking the delta after the application of rate is not correct. The
  delta is in screen-space *before* the rate from rate-changing mods were
  applied; the point of the application of the rate is to compensate for
  the fact that the spinner is still judged in "track time" - but the goal
  is to keep the spinner's difficulty *independent* of rate, which means
  that with DT active the user's spin is "twice as effective" to
  compensate for the fact that the spinner is twice as short in real time.
  
  In another formulation, with DT active, the user gets to record replay
  frames "half as often" as in normal gameplay.

  Bartłomiej Dach · 2023-10-30 21:28:29 +01:00
  e5b51f769c
• Merge pull request #25157 from peppy/spinner-anti-cheese-final

  Fix spinner cheese by accounting for spin directionality

  Bartłomiej Dach · 2023-10-24 08:13:32 +02:00
  0e5a521695
• Add SpinnerSpinHistory and tests
  Dean Herbert · 2023-10-17 20:10:22 +09:00
  af7180a5b5
• Bypass Parent nullability checks for now
  Dean Herbert · 2023-10-17 17:48:45 +09:00
  5341a335a6
• Fix incorrect initial rotation transfer value

  Should have been removed as part of https://github.com/ppy/osu/pull/24360.

  Dean Herbert · 2023-10-16 19:34:55 +09:00
  0bb95cfa88
• Tidy up lastAngle usage and add assertion of maximum delta
  Dean Herbert · 2023-10-16 19:34:22 +09:00
  10bab61441
• Rename RateAdjustedRotation to TotalRotation
  Dean Herbert · 2023-10-16 18:25:03 +09:00
  159b24acf7
• Fix large instantaneous delta on first frame

  Happens when the first update frame comes in before any mouse input.

  Dan Balasescu · 2023-10-16 18:17:11 +09:00
  84be714d6b
• Change spinner rotation animation to match input 1:1
  Dean Herbert · 2023-07-25 19:21:20 +09:00
  2e9379474d
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Apply nullability to osu! skinning classes
  Dean Herbert · 2022-11-09 13:37:09 +09:00
  82ff142b1b
• Change NonGameplayAdjustments to GameplayAdjustments and convert TrueGameplayRate to extension method
  Dean Herbert · 2022-09-06 22:26:46 +09:00
  bc1212f4e6
• Move all usage of GameplayClock to IGameplayClock
  Dean Herbert · 2022-08-15 18:30:53 +09:00
  c8764cb333
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Adjust namespace
  ekrctb · 2020-12-04 20:21:53 +09:00
  245be2c5ed
• Move piece files in Osu ruleset
  ekrctb · 2020-12-04 20:11:35 +09:00
  a12b049154