147 Commits

• Apply flooring and half-millisecond-adjustments to hit windows

  This is a "two-birds-with-one-stone" change, which addresses both
  https://github.com/ppy/osu/issues/28744 and
  https://github.com/ppy/osu/issues/11311 simultaneously.
  
  - The replay stability issue caused by time instants being rounded to
    nearest integer is fixed by this, because flooring and
    subtracting/adding 0.5 from the hit window threshold makes it
    impossible for a judgement to switch to anything else after replay
    rounding is applied - all hit windows are always a full integer plus
    0.5 milliseconds, which immunizes them to rounding-to-full-ms issues.
  
  - The direction of applying the 0.5 adjustment additionally fixes the
    disparity with stable - in osu! and taiko 0.5 is subtracted as
    hit window ranges in those rulesets are exclusive on stable, while in
    mania 0.5 is added, as the hit window ranges there are *inclusive* on
    stable.
  
  As should be obvious, this materially changes hit windows. To what degree
  this is a *significant* change is up for discussion; I would say "no"
  since hitting half a millisecond changes would require 2000fps input
  recording, and we're still timestamping inputs using the update thread's
  clock, that gives a 1ms resolution at best.
  
  In the worst case, in osu! and taiko, this can change a hit window range
  by 1.5ms (e.g. 300.9ms -> floored to 300ms -> 299.5ms after subtraction
  of the half). It's more than the best-case resolution of input
  timestamps, but not by much. Considering how cleanly this resolves the
  issues in question, I see it as an acceptable tradeoff.

  Bartłomiej Dach · 2025-06-25 11:44:13 +02:00
  0f078ee550
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Make RankFromScore()'s dictionary param readonly

  Just to make sure nobody tries any "funny" business.

  Bartłomiej Dach · 2024-01-22 19:56:30 +01:00
  cb8ec48717
• Change S rank to require no miss
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  c8521b49cd
• Use SliderTailHit result for slider tails (non-classic-mod)
  Dan Balasescu · 2023-12-30 10:38:47 +09:00
  17a531209c
• Adjust comment regarding slider tail
  Dan Balasescu · 2023-12-24 00:45:22 +09:00
  7437d21f49
• Remove unused using
  Dan Balasescu · 2023-12-24 00:08:15 +09:00
  8b11bcc6ea
• Add combo end bonus to HP
  Dan Balasescu · 2023-12-23 23:51:12 +09:00
  00090bc527
• remove HP density
  Dan Balasescu · 2023-12-23 23:36:15 +09:00
  d1000b2e6c
• Add basic consideration of density for HP drain
  Dan Balasescu · 2023-12-22 18:08:26 +09:00
  a0185508b7
• Use classic HP values for non-classic osu! HP drain
  Dan Balasescu · 2023-12-22 02:16:46 +09:00
  3f6dad5502
• Change osu ruleset to use new HP algorithm by default
  Dan Balasescu · 2023-12-17 19:33:04 +09:00
  4b9aefa6f2
• Use HitWindows data directly for computing effective OD
  Bartłomiej Dach · 2023-12-14 20:41:12 +01:00
  0f4d054bfe
• Merge pull request #24166 from Zyfarok/scorev3

  Modify osu! standardised scoring to introduce a combo exponent

  Dan Balasescu · 2023-12-12 17:38:44 +09:00
  987fe9322e
• Encapsulate common HP logic from osu and catch HP calculations
  Dan Balasescu · 2023-11-24 18:32:06 +09:00
  8314f656a3
• Remove legacy implementations (moved to osu-tools)
  Dan Balasescu · 2023-11-24 15:43:57 +09:00
  c126c46e2d
• Merge branch 'master' into scorev3
  Bartłomiej Dach · 2023-11-24 10:37:10 +09:00
  ca37e1afc2
• Merge branch 'master' into hp-drain-fix-breaks
  Bartłomiej Dach · 2023-11-23 10:31:42 +09:00
  d4519f74ab
• Add note about break calculation method
  Dean Herbert · 2023-11-17 18:49:19 +09:00
  fd3508254b
• Use switch statement for type matching
  Dean Herbert · 2023-11-17 18:45:16 +09:00
  2ab84fdaa3
• Move default value out of switch statement
  Dean Herbert · 2023-11-17 18:43:31 +09:00
  a556caae43
• Remove unused values
  Dean Herbert · 2023-11-17 18:41:09 +09:00
  c9c8ed7c77
• Refactor fail reason output to not perform string interpolation unless hooked
  Dean Herbert · 2023-11-16 15:29:32 +09:00
  3c513d0b62
• Remove unused using refs
  Dean Herbert · 2023-11-16 15:14:32 +09:00
  265ae6fd30
• Fix osu! and base HP processor break time implementation
  Dan Balasescu · 2023-11-14 01:11:17 +09:00
  e3137d575b
• Improve commenting around small tick/large tick health
  Dan Balasescu · 2023-11-13 14:06:34 +09:00
  35d4c483d7
• Add option to disable combo end
  Dan Balasescu · 2023-11-13 14:06:24 +09:00
  65b41138a3
• Cleanup
  Dan Balasescu · 2023-11-13 13:46:47 +09:00
  98e6b7744b
• Disallow legacy health processor from being used for gameplay
  Dan Balasescu · 2023-11-13 13:12:46 +09:00
  929570656d
• Add flag for combo end bonus to legacy processor
  Dan Balasescu · 2023-11-13 12:59:36 +09:00
  5fd55e55c0
• Add some notes
  Dan Balasescu · 2023-11-10 19:09:09 +09:00
  793d90e396
• Implement OsuHealthProcessor following osu-stable
  Dan Balasescu · 2023-11-10 18:41:02 +09:00
  12e5766d50
• Add legacy reference health processor
  Dan Balasescu · 2023-11-10 18:40:21 +09:00
  fecc6f580b
• Remove unused usings
  Dean Herbert · 2023-08-22 16:07:48 +09:00
  bbe4635a50
• Scoring : Remove ComputeTotalScore overide in OsuScoreProcessor
  Zyf · 2023-07-15 15:22:59 +02:00
  ecb633f8fb
• Add back required override to make AccuracyHeatmap work
  Dean Herbert · 2023-06-01 13:26:47 +09:00
  e830b96e61
• Rename parameters
  Dan Balasescu · 2023-05-19 17:27:02 +09:00
  30a296bd09
• Refactor for safety
  Dan Balasescu · 2023-05-19 14:37:26 +09:00
  d74bf2a096
• Avoid NaN values during ApplyBeatmap processing()
  Dan Balasescu · 2023-05-19 14:14:34 +09:00
  2ae34530f7
• Remove ClassicScoreMultiplier and DefaultScoreProcessor
  Dan Balasescu · 2023-05-19 12:24:52 +09:00
  8b56a3f87d
• Reimplement classic scoring mode
  Dan Balasescu · 2023-05-09 20:21:38 +09:00
  a7b623f52a
• Initial implementation of ScoreV2
  Dan Balasescu · 2023-05-09 19:33:33 +09:00
  3c3c812ed6
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Fix sliders not dimming correctly due to modified miss window
  Dean Herbert · 2022-10-05 14:25:04 +09:00
  56d424003d
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove unnecessary ctor arguments
  Dan Balasescu · 2022-03-15 12:34:58 +09:00
  daac933498
• Prevent incorrect usages by hard-typing ctor type
  Dan Balasescu · 2022-03-15 09:11:59 +09:00
  59d57a44d4
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Add per-ruleset score multipliers for classic scoring
  Dan Balasescu · 2022-03-10 10:26:09 +09:00
  c36badab4b