56 Commits

• Change OsuModRelax hit leniency to be the same as in stable
  StanR · 2024-12-26 18:13:09 +05:00
  94d56d3584
• Use private interface rather than weird inheritance
  Bartłomiej Dach · 2024-02-13 10:20:06 +01:00
  22e9c4a3b5
• only use LegacyReplayPressHandler on legacy replays
  James Wilson · 2024-02-13 00:34:06 +00:00
  5101979ac0
• add inline comment for supposedly backwards ternary
  tsunyoku · 2024-02-12 18:00:05 +00:00
  cc733ea809
• refactor down and wasLeft management into respective PressHandler classes
  tsunyoku · 2024-02-12 17:45:00 +00:00
  2a02566283
• handle key presses when watching legacy relax replays
  tsunyoku · 2024-02-12 12:51:35 +00:00
  581ae2f679
• Fix relax mod not handling objects close to a previous slider's follow area
  Salman Ahmed · 2024-01-28 23:11:42 +03:00
  ee4fe1c068
• Fix relax mod not considering full follow area radius when automatically holding sliders

  Closes https://github.com/ppy/osu/issues/25947.
  
  Regressed in https://github.com/ppy/osu/pull/25776 with the changes to
  `DrawableSliderBall`.
  
  I would have liked to include tests, but relax mod is a bit untestable,
  because it disengages completely in the presence of a replay:
  
  	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game.Rulesets.Osu/Mods/OsuModRelax.cs#L49-L58
  
  Additionally, `RulesetInputManager` disengages completely from parent
  inputs when there is a replay active:
  
  	https://github.com/ppy/osu/blob/7e09164d7084265536570ac7036d7244934b651c/osu.Game/Rulesets/UI/RulesetInputManager.cs#L116
  
  which means there is really no easy way to control positional input
  while still having relax logic work. So I'm hoping the fix could be
  considered obvious enough to not require test coverage.

  Bartłomiej Dach · 2023-12-22 12:50:42 +01:00
  7e557152fb
• Add IHasNoTimedInputs interface to scope change further
  Dean Herbert · 2023-06-06 22:22:42 +09:00
  247fa088db
• Expose the actual KeyBindingInputManager

  Turns out that `CreateInputManager` is called more than once, and some
  mods (ie. `InputBlockingMod`) rely on consuming the "main" one. So let's
  go back to accessing and exposing in `DrawableOsuRuleset` rather than
  storing out own reference.

  Dean Herbert · 2023-02-14 18:10:26 +09:00
  c540d78fbc
• Expose and consume OsuInputManager explicitly
  Dean Herbert · 2023-02-14 17:36:07 +09:00
  5ec5222d8a
• Rename property and add xmldoc
  Dean Herbert · 2022-10-10 15:42:08 +09:00
  5a5f3af27d
• Change ruleset mod description types
  naoei · 2022-08-10 16:09:11 -04:00
  3e38baca3c
• Mark the property as non-nullable.
  andy840119 · 2022-07-31 21:43:16 +08:00
  632577389d
• Mark the property as nullable and add some assert check.
  為什麼 · 2022-07-26 23:58:50 +08:00
  9134525111
• Mark the property as nullable or non-nullable.
  為什麼 · 2022-07-26 23:52:08 +08:00
  deb39bd330
• Remove nullable disable annotation in the Osu ruleset.
  為什麼 · 2022-07-26 23:25:28 +08:00
  e28584da89
• make Single Tap incompatible with Autoplay, Cinema and Relax
  James · 2022-07-12 23:18:20 +01:00
  20d2b86193
• fix mod incompatibility between repel and relax
  Gabe Livengood · 2022-07-12 08:43:48 -04:00
  b96734e31a
• Add missed incompatilibity rules
  Dean Herbert · 2022-07-12 15:19:06 +09:00
  fa626a82b3
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• fixed autoplay not showing compat, + relax compat
  Supersonicboss1 · 2022-05-04 22:25:34 +01:00
  81b4622620
• Rename "Aim Assist" to "Magnetised" to better suit the mod's behaviour

  As proposed in https://github.com/ppy/osu/discussions/17375.

  Dean Herbert · 2022-04-01 12:15:52 +09:00
  a987cda30d
• Use .Concat() instead of chained Append

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Noah M · 2022-03-18 14:24:36 -05:00
  78869c462a
• Make Relax and Aim assist mods incompatible
  Noah M · 2022-03-18 14:12:36 -05:00
  b4a8defe1a
• Don't override previous value

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  PercyDan · 2022-02-12 11:15:03 +08:00
  639d813d06
• Simplify code
  PercyDan54 · 2022-02-12 10:06:43 +08:00
  053f41d755
• Ignore short spinners for relax mod
  PercyDan54 · 2022-02-12 09:28:50 +08:00
  2ed3d58531
• Rename to IHasDuration
  Dean Herbert · 2020-05-27 12:38:39 +09:00
  cbd563e80b
• Add back missing line
  Dean Herbert · 2020-04-21 16:06:40 +09:00
  1f0b7465e2
• Fix relax replays playing back incorrectly
  Dean Herbert · 2020-04-21 15:28:25 +09:00
  5e3fad86cf
• Fix relax mod pressing too many keys
  Dean Herbert · 2020-03-31 15:17:27 +09:00
  8a998d600d
• Add a sane key up delay to relax mod
  Dean Herbert · 2020-02-14 17:13:50 +09:00
  61a7f04efb
• Move public methods up
  Dean Herbert · 2020-02-14 17:03:23 +09:00
  4ce687d608
• Fix 2B maps not playing correctly with relax mod enabled
  Dean Herbert · 2020-02-14 17:00:55 +09:00
  cd2d1b0669
• Improve overall readability of OsuModeRelax
  Dean Herbert · 2020-02-14 16:58:56 +09:00
  9ea6912520
• Fix other potential nullref cases that rider missed
  smoogipoo · 2019-09-02 18:31:33 +09:00
  8302658186
• Move blocking fail logic into a base class
  Salman Ahmed · 2019-07-02 01:47:39 +03:00
  a8e8650ddd
• Hide health bar in relax mod
  iiSaLMaN · 2019-06-29 04:26:24 +03:00
  9c9334a8ba
• Fix all "Maintainability" CodeFactor issues
  Arphox · 2019-06-11 10:28:16 +02:00
  07e17518e9
• Fix typo
  Dean Herbert · 2019-03-20 11:22:34 +09:00
  3b7a76aa4e
• Rename RulesetContainer to DrawableRuleset
  Dean Herbert · 2019-03-19 23:47:31 +09:00
  baea7230bc
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Replace usage of now removed TriggerKeyPress and similar methods.
  ekrctb · 2018-09-19 11:36:55 +09:00
  a3e6973b41
• Fix mania throwing an exception on start of map
  Dean Herbert · 2018-08-30 14:58:00 +09:00
  68a79f895a
• Block user input
  Dean Herbert · 2018-08-17 19:33:14 +09:00
  442f6795bc
• Clean up logic and variables
  Dean Herbert · 2018-08-16 18:18:15 +09:00
  bc22a28fef
• Only process alive objects
  Dean Herbert · 2018-08-16 18:18:08 +09:00
  870f6bea47
• Fix overclick in certain situations
  tgi74000 · 2018-08-05 09:58:15 +02:00
  924bf9174c
• Remove IUpdatableByHitObject completely
  tgi74000 · 2018-08-05 09:52:19 +02:00
  b1d1a2400b