28 Commits

• Abstract out common implementation of BeatSnapGrid
  Dean Herbert · 2023-10-17 16:42:52 +09:00
  1b9acdf55c
• Use a DrawablePool for mania's beat snap grid

  I'm not sure what the cause of the issue is, but I'm also not sure why
  it wasn't using `DrawablePool` (was it not around back then?).
  
  Either way, switching to a proper pool fixes things just fine.
  
  Resolves https://github.com/ppy/osu/issues/25009.

  Dean Herbert · 2023-10-10 13:36:31 +09:00
  1a60d6ade5
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• Fix incorrect colouring of beat snap grids (mania and catch)
  Dean Herbert · 2023-06-07 12:25:34 +09:00
  6d446d3e97
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Clean up unused resolved properties
  Dean Herbert · 2021-12-03 18:49:49 +09:00
  1eed2436e6
• Always use LifetimeEntry to manage hit objects in HitObjectContainer

  Previously, non-pooled DHOs were immediately added as children of the HOC when Add is called. Also, non-pooled DHOs were always attached to the HOC as children.
  New behavior is that non-pooled DHOs are only added after CheckChildLifetime, and only attached to the HOC while the DHOs are alive.
  
  - LifetimeManagementContainer inheritance of HOC is removed, as it is now all DHOs are "unmanaged" (previously `AddInternal(false)`).
  - The signature of `Clear` is changed, and it is now always not disposing the children immediately.

  ekrctb · 2021-04-29 14:38:01 +09:00
  d262956146
• Update existing implementations
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  a3dc1d5730
• Remove necessity for custom mania interface caching
  Dean Herbert · 2020-05-27 23:15:16 +09:00
  6be5917eb0
• Fix incorrect alpha application to lines on rewinding
  Dean Herbert · 2020-05-22 12:45:37 +09:00
  ce35d09e7d
• Remove left-over function
  Dean Herbert · 2020-05-22 12:28:01 +09:00
  d529a2aefa
• Fix test failures
  Dean Herbert · 2020-05-20 15:01:32 +09:00
  0bc3073d49
• Fix logic results in infinite loop on default timing point return
  Dean Herbert · 2020-05-20 14:55:36 +09:00
  d31a59b074
• Add xmldoc and address some code quality concerns
  Dean Herbert · 2020-05-19 23:05:08 +09:00
  85156c62ef
• Move load method up
  Dean Herbert · 2020-05-19 23:02:20 +09:00
  c28a9bdb80
• Fix time value not being updated for next timing point
  Dean Herbert · 2020-05-19 23:01:36 +09:00
  a6f3dc53f7
• Add very basic pooling of grid lines
  Dean Herbert · 2020-05-19 19:07:35 +09:00
  d56466e2b9
• Construct online visible lines
  Dean Herbert · 2020-05-18 21:27:26 +09:00
  406f39e8bf
• Simplify colouring logic
  Dean Herbert · 2020-05-18 19:48:51 +09:00
  b35b150f38
• Remove Grid class
  Dean Herbert · 2020-05-18 17:52:04 +09:00
  16e85ae0b1
• Move grids to inside columns
  Dean Herbert · 2020-05-18 17:47:52 +09:00
  d9bb90078b
• Add comment about gray usage
  smoogipoo · 2020-05-15 15:56:32 +09:00
  238d87f976
• Add const
  smoogipoo · 2020-05-15 15:51:54 +09:00
  1c6c128d11
• Always fully display one beat
  smoogipoo · 2020-05-15 15:49:50 +09:00
  392d44e1fb
• Fix flashing when changing beat divisor
  smoogipoo · 2020-05-14 19:58:39 +09:00
  0e33494074
• Only update alive lines
  smoogipoo · 2020-05-14 19:55:14 +09:00
  42c3d892cd
• Add initial beat snap grid implementation
  smoogipoo · 2020-05-14 19:17:24 +09:00
  16585f767e