77 Commits

• Fix banana showers causing fails when hp is at 0
  Dan Balasescu · 2024-03-20 17:31:33 +09:00
  bf5640049a
• Fix missing tiny droplet not triggering fail with perfect on

  Stable does this:
  
      https://github.com/peppy/osu-stable-reference/blob/46cd3a10af7cc6cc96f4eba92ef1812dc8c3a27e/osu!/GameplayElements/HitObjectManagerFruits.cs#L98-L102
  
  I'd rather not say what I think about it doing that, since it's likely
  to be unpublishable, but to approximate that, just make it so that
  only the "default fail condition" is beholden to the weird ebbs
  and flows of what the ruleset wants. This appears to fix the problem
  case and I'm hoping it doesn't break something else but I'm like 50/50
  on it happening anyway at this point. Just gotta add tests add nauseam.

  Bartłomiej Dach · 2024-02-14 14:21:48 +01:00
  2c0a5b7ef5
• Fix catch health processor allowing fail on tiny droplet

  Closes https://github.com/ppy/osu/issues/27159.
  
  In today's episode of "just stable things"...

  Bartłomiej Dach · 2024-02-14 09:02:33 +01:00
  f53bce8ff7
• Make RankFromScore()'s dictionary param readonly

  Just to make sure nobody tries any "funny" business.

  Bartłomiej Dach · 2024-01-22 19:56:30 +01:00
  cb8ec48717
• Change S rank to require no miss
  Dean Herbert · 2024-01-22 21:43:32 +09:00
  c8521b49cd
• Change catch scoring to match score V2
  Bartłomiej Dach · 2024-01-05 20:46:11 +01:00
  8295ad1feb
• Expose only as one method
  Dan Balasescu · 2023-12-21 14:58:23 +09:00
  6b4b2a57fc
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Add ScoreProcessor methods to override numeric result
  Dan Balasescu · 2023-12-19 13:50:31 +09:00
  c1b55c7fac
• Adjust catch score grade cutoffs
  Dan Balasescu · 2023-11-29 19:05:31 +09:00
  295a1b01d6
• Encapsulate common HP logic from osu and catch HP calculations
  Dan Balasescu · 2023-11-24 18:32:06 +09:00
  8314f656a3
• Remove legacy implementations (moved to osu-tools)
  Dan Balasescu · 2023-11-24 15:43:57 +09:00
  c126c46e2d
• Use better break calculation
  Dan Balasescu · 2023-11-24 13:49:28 +09:00
  4ba6450c77
• Add CatchHealthProcessor, following legacy calculations
  Dan Balasescu · 2023-11-24 13:49:28 +09:00
  acf3de5e25
• Implement legacy catch health processor
  Dan Balasescu · 2023-11-24 13:49:28 +09:00
  62a04a93c8
• Remove catch tiny droplet portion
  Dan Balasescu · 2023-05-23 15:36:34 +09:00
  c291d6fc82
• Rename parameters
  Dan Balasescu · 2023-05-19 17:27:02 +09:00
  30a296bd09
• Add score processor statistics to replay header
  Dan Balasescu · 2023-05-19 16:29:24 +09:00
  6c6f8621c1
• Refactor for safety
  Dan Balasescu · 2023-05-19 14:37:26 +09:00
  d74bf2a096
• Avoid NaN values during ApplyBeatmap processing()
  Dan Balasescu · 2023-05-19 14:14:34 +09:00
  2ae34530f7
• Fix TestSceneScoring and incorrect combo calculations
  Dan Balasescu · 2023-05-19 14:09:19 +09:00
  7cbf48ffcf
• Remove ClassicScoreMultiplier and DefaultScoreProcessor
  Dan Balasescu · 2023-05-19 12:24:52 +09:00
  8b56a3f87d
• Reimplement classic scoring mode
  Dan Balasescu · 2023-05-09 20:21:38 +09:00
  a7b623f52a
• Initial implementation of ScoreV2
  Dan Balasescu · 2023-05-09 19:33:33 +09:00
  3c3c812ed6
• Remove #nullable disable from misc Catch files
  ekrctb · 2023-01-15 17:29:35 +09:00
  b08a1e3a0b
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove unnecessary ctor arguments
  Dan Balasescu · 2022-03-15 12:34:58 +09:00
  daac933498
• Prevent incorrect usages by hard-typing ctor type
  Dan Balasescu · 2022-03-15 09:11:59 +09:00
  59d57a44d4
• Require ScoreProcessor to receive ruleset
  Dan Balasescu · 2022-03-14 15:51:10 +09:00
  3fff7f4b7e
• Add per-ruleset score multipliers for classic scoring
  Dan Balasescu · 2022-03-10 10:26:09 +09:00
  c36badab4b
• Remove bogus CatchHitWindows

  `CatchHitWindows` were a vestige from the past, and were not actually
  used anywhere except for the hit error meter test, giving off an
  appearance that the hit error meter was working properly.
  `CatchHitObject` actually specifies empty hit windows.

  Bartłomiej Dach · 2021-06-07 13:16:07 +02:00
  122a624b7f
• Make osu/taiko/catch use Ok+Great
  smoogipoo · 2020-09-29 17:16:55 +09:00
  f439c1afbc
• Update judgement processors with new hit results
  smoogipoo · 2020-09-29 16:33:38 +09:00
  31fae045fa
• Implement break/gameplay start times
  smoogipoo · 2019-12-26 15:00:58 +09:00
  522847987b
• Simplify scoreprocesor/healthprocessor implementations
  smoogipoo · 2019-12-26 14:59:49 +09:00
  90cb9d9162
• Separate score and health parts of ScoreProcessor
  smoogipoo · 2019-12-19 20:03:14 +09:00
  76f2fb378f
• Remove abstract ScoreProcessor class
  smoogipoo · 2019-12-11 17:25:06 +09:00
  48f1dad4aa
• Refactor HitWindows for legibility
  Dean Herbert · 2019-09-06 15:24:14 +09:00
  f925e781a9
• Apply more cases/fix some existing ones
  smoogipoo · 2019-05-07 13:23:09 +09:00
  13b9b04bb8
• Rename method + add xmldoc
  smoogipoo · 2019-04-22 18:08:15 +09:00
  aeae759fcd
• Make hp work + cleanup
  smoogipoo · 2019-04-22 18:02:49 +09:00
  4edb17a88a
• Make catch provide some HP at DrainRate=10
  smoogipoo · 2019-04-22 17:24:22 +09:00
  78c844e259
• Implement approximate hp increase for catch
  smoogipoo · 2019-04-22 16:59:14 +09:00
  d7919544fe
• Fix typo
  Dean Herbert · 2019-03-20 11:22:34 +09:00
  3b7a76aa4e
• Rename RulesetContainer to DrawableRuleset
  Dean Herbert · 2019-03-19 23:47:31 +09:00
  baea7230bc
• Merge remote-tracking branch 'upstream/master' into fix-replay-import-statistics
  Dean Herbert · 2019-02-04 12:15:53 +09:00
  2d7c23dd9f
• Update licence header (and remove year)
  Dean Herbert · 2019-01-24 17:43:03 +09:00
  8617aaa2a7
• Fix imported replays having excess statistics
  Dean Herbert · 2019-01-03 14:01:20 +09:00
  aec3753863
• Implement hit windows
  smoogipoo · 2018-12-27 22:39:15 +09:00
  b64932f6db