1524 Commits

• Fix standardised score conversion failing for scores set with 0.0x mod mutliplier

  Closes https://github.com/ppy/osu/issues/26073.

  Bartłomiej Dach · 2023-12-23 13:28:39 +01:00
  3a2ed3677b
• Add extra safety against returning negative total score in conversion operation
  Bartłomiej Dach · 2023-12-23 13:07:29 +01:00
  007ea51e20
• Merge branch 'master' into add-score-version
  Bartłomiej Dach · 2023-12-21 13:06:53 +01:00
  fbf19ea598
• Add versioning of local scores

  For any potential future usage

  Dean Herbert · 2023-12-21 18:37:15 +09:00
  a4baa0a716
• Add accuracy conversion, fix usages
  Dan Balasescu · 2023-12-21 15:09:56 +09:00
  eb072a1d24
• Expose only as one method
  Dan Balasescu · 2023-12-21 14:58:23 +09:00
  6b4b2a57fc
• Relocate HitResult numeric score to ScoreProcessor
  Dan Balasescu · 2023-12-21 14:52:31 +09:00
  4e3b994142
• Merge branch 'master' into mania-scorev2-values
  Bartłomiej Dach · 2023-12-20 15:54:31 +01:00
  8c06d3873d
• Update total score conversion
  Dan Balasescu · 2023-12-20 20:03:13 +09:00
  38d6b7f45b
• Merge pull request #25876 from bdach/fix-standardised-score-conversion

  Fix osu! standardised score conversion sometimes exceeding bounds

  Dan Balasescu · 2023-12-20 18:54:33 +09:00
  72274041eb
• Use safer fix for now
  Bartłomiej Dach · 2023-12-19 17:25:15 +01:00
  3f41c20ac6
• Change default values of new object counts to -1 to identify non-processed values
  Dean Herbert · 2023-12-19 18:20:02 +09:00
  f09c6b8c1b
• Roll back incorrect change in ShouldMigrateToNewStandardised()
  Bartłomiej Dach · 2023-12-19 08:13:02 +01:00
  ddb67c87a8
• Run score conversion for previously-imported scores
  Bartłomiej Dach · 2023-12-18 22:27:51 +01:00
  9c8df4e6d1
• Fix osu! standardised score conversion sometimes exceeding bounds

  Co-authored-by: Zyf <zyfarok@gmail.com>
  
  Closes https://github.com/ppy/osu/issues/25860
  
  Users reported that some stable scores would convert to large negative
  total scores in lazer after the introduction of combo exponent. Those
  large negative total scores were actually mangled NaNs.
  
  The root cause of this was the following calculation going below zero
  unexpectedly:
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L323
  
  which then propagates negative numbers onward until
  
  	https://github.com/ppy/osu/blob/8e8d9b2cd96be4c4b3d8f1f01dc013fc9d41f765/osu.Game/Database/StandardisedScoreMigrationTools.cs#L337
  
  which yields a NaN due to attempting to take the square root of a
  negative number.
  
  To fix, clamp `comboPortionInScoreV1` to sane limits: to
  `comboPortionFromLongestComboInScoreV1` from below, and to
  `maximumAchievableComboPortionInScoreV1` from above. This is a less
  direct fix than perhaps imagined, but it seems like a better one as it
  will also affect the calculation of both the lower and the upper
  estimate of the score.

  Bartłomiej Dach · 2023-12-18 22:05:19 +01:00
  017003deea
• Extract common method for determining stable import usability of directory
  Bartłomiej Dach · 2023-12-15 15:42:19 +01:00
  b384c9f938
• Bump version number
  Dan Balasescu · 2023-12-13 17:38:59 +09:00
  812f52e793
• Merge branch 'master' into mania-convert-song-select-keycount
  Dan Balasescu · 2023-12-13 13:53:50 +09:00
  6ed5613c22
• Add object counts to IBeatmapDifficultyInfo
  Dan Balasescu · 2023-12-09 22:31:51 +09:00
  767d5c8018
• Account for legacyAccScore in score conversion
  Zyf · 2023-11-24 23:07:27 +01:00
  71e5654b64
• Fix scoring-conversion when miss-count is 0
  Zyf · 2023-11-24 22:05:24 +01:00
  27f9dfccc4
• Merge branch 'master' into scorev3
  Bartłomiej Dach · 2023-11-24 10:37:10 +09:00
  ca37e1afc2
• Rename and comment everything in score migration code

  Hopefully, _hopefully_, makes all this a little bit less inscrutable.

  Bartłomiej Dach · 2023-11-24 10:34:13 +09:00
  7590bae445
• Scoring conversion: remove mention of v3 + improve comments
  Clément Burgelin (Zyfarok) · 2023-11-21 14:26:07 +01:00
  901e45b6a4
• Fix: update score migration of special case to match the new score

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Clément Burgelin (Zyf) · 2023-11-21 11:27:03 +01:00
  16acec335f
• Fix incorrect legacy conversion when B-splines are used
  Bartłomiej Dach · 2023-11-20 15:08:58 +09:00
  6d7d826b8b
• Fix syntax
  Clément Burgelin (Zyfarok) · 2023-11-20 03:05:46 +01:00
  1f88658bad
• Scoring : change formula parameters to match survey results
  Zyf · 2023-11-20 00:02:58 +01:00
  432b88674b
• Merge remote-tracking branch 'upstream/master' into scorev3
  Zyf · 2023-11-19 23:53:05 +01:00
  cadd9b4ace
• Generalize Bezier curves to BSplines of Nth degree
  Thomas Müller-Höhne · 2023-11-11 13:32:53 +01:00
  926636cc03
• Merge pull request #24794 from bdach/score-encoding-cleanup

  Correctly handle multiple online score ID types

  Dean Herbert · 2023-10-28 02:29:56 +09:00
  5a9d4170e8
• Fix skin editor freezing game if opened during active gameplay
  Bartłomiej Dach · 2023-10-27 14:34:30 +02:00
  5ad962070c
• Remove IScoreInfo : IHasNamedFiles inheritance
  Bartłomiej Dach · 2023-10-26 14:58:33 +02:00
  526ee6e140
• Merge branch 'master' into score-encoding-cleanup
  Bartłomiej Dach · 2023-10-26 09:04:05 +02:00
  ca4b09f8ef
• Add backwards migration of catch dash binding
  Bartłomiej Dach · 2023-10-17 09:43:40 +02:00
  4cfc95c673
• Add migration to remove duplicate bindings
  Bartłomiej Dach · 2023-10-16 22:20:26 +02:00
  9c6166ec3d
• Add LegacyOnlineID with backwards migration
  Bartłomiej Dach · 2023-10-16 11:20:02 +02:00
  c1a817fec6
• Merge branch 'master' into fix-legacy-score-multipliers-2
  Dan Balasescu · 2023-10-04 01:19:33 +09:00
  a120ea8464
• Fix legacy beatmap importer not always handling nested paths correctly

  Addresses https://github.com/ppy/osu/discussions/24989.

  Dean Herbert · 2023-10-03 16:01:17 +09:00
  b234a453da
• Update score conversion to consider legacy multiplier
  Dan Balasescu · 2023-10-02 16:56:15 +09:00
  b9ab4a2b7c
• Merge branch 'master' into fix-batch-import-score-missing-notifications
  Bartłomiej Dach · 2023-09-27 17:06:47 +02:00
  0769d0f49f
• Merge branch 'master' into better-erroring-score-import-fail
  Bartłomiej Dach · 2023-09-27 14:34:14 +02:00
  934ac1b640
• Don't show replay import "missing beatmap" notifications during stable import

  Closes https://github.com/ppy/osu/issues/24926.

  Dean Herbert · 2023-09-27 17:04:43 +09:00
  2481c0b64b
• Merge branch 'master' into split-legacy-scoring-attribs
  Dean Herbert · 2023-09-26 15:52:27 +09:00
  0dcf7a2fa9
• Improve notification display when score import fails
  Dean Herbert · 2023-09-26 15:00:56 +09:00
  d1d82d2b49
• Fix notification text sets overwriting each other
  Bartłomiej Dach · 2023-09-19 11:12:58 +02:00
  ed9039f60f
• Pass ArchiveReader instead of Stream to simplify resolution code
  Dean Herbert · 2023-09-19 17:49:15 +09:00
  f726c38215
• Adjust sizing slightly to remove need for CollapsibleButtonContainerSlim
  Dean Herbert · 2023-09-19 17:20:58 +09:00
  7f30354e61
• Add comment mentioning why hover is disabled on the notification type
  Dean Herbert · 2023-09-19 16:35:22 +09:00
  0555d22eb8
• Auto-close notification after successful download
  Bartłomiej Dach · 2023-09-18 14:56:06 +02:00
  25e43bd7d7