Dean Herbert
a35551ecd9
Merge pull request #30383 from CloneWith/feature/placeholder-hoverbk
...
Add hover background back to `ClickablePlaceholder`
2024-10-22 18:17:36 +09:00
Dean Herbert
16bc188ba7
Refactor code to read better (and adjust lenience to match stable)
2024-10-22 18:08:25 +09:00
Dean Herbert
e1a950e2d3
Fix beatmap selection being lost during update process
...
Broke due to something changing in the way we handle realm things in the
carousel. The deselection happens in `updateBeatmapSet` so we need to
store / check the original selection before this occurs.
Doesn't seem this had test coverage? Probably implies that the overhead
of adding a test was very large, so maybe best to leave it that way.
2024-10-22 17:53:34 +09:00
Bartłomiej Dach
9258916fa8
Merge pull request #30263 from frenzibyte/editor-slider-touch-support-1
...
Fix drawing slider with touch inserts a random control point at beginning
2024-10-22 10:29:30 +02:00
Dean Herbert
13fba9f92e
Adjust glow slightly
2024-10-22 17:16:09 +09:00
Bartłomiej Dach
03683e28be
Merge branch 'master' into editor-slider-touch-support-1
2024-10-22 09:31:03 +02:00
Dan Balasescu
1bdae2af41
Merge pull request #30379 from peppy/dont-delete-scores
...
Don't delete scores when deleting beatmaps
2024-10-22 14:22:14 +09:00
EvT
17cd411567
Added search box to ChannelGroup Private Message
2024-10-22 01:33:53 +03:00
Dean Herbert
cbaee98674
Don't delete scores when deleting beatmaps
...
The score model's spec allows for null `BeatmapInfo` so the reasoning of
the inline comment is no longer valid. We match based on hash these
days.
2024-10-22 01:39:05 +09:00
Bartłomiej Dach
455ed0607f
Merge pull request #30346 from wezwery/perfect-combo-and-accuracy-highlighted
...
Highlight maximum combo and accuracy on user best score display to match web
2024-10-21 15:34:03 +02:00
CloneWith
9940be818d
Add hover color back to ClickablePlaceholder
2024-10-21 21:09:26 +08:00
Bartłomiej Dach
dbc2e78dd9
Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted
...
Closes https://github.com/ppy/osu/issues/30324 .
2024-10-21 14:48:57 +02:00
Bartłomiej Dach
d6497640d9
Add failing test case
2024-10-21 14:44:09 +02:00
Bartłomiej Dach
1e03bd11a3
Fix test compile failures
2024-10-21 13:57:34 +02:00
Bartłomiej Dach
0a15eec7de
Remove unused using directive
2024-10-21 13:52:17 +02:00
Bartłomiej Dach
22c3a25575
Merge pull request #30326 from jhk2601/barrel_roll_fix
...
Fix cursor rotating with barrel roll mod active
2024-10-21 13:51:28 +02:00
Bartłomiej Dach
e89a4561ab
Fix playfield skinning layer no longer correctly rotating with the playfield
...
Closes https://github.com/ppy/osu/issues/30353 .
Regressed in
4a39873e2a
2024-10-21 13:49:12 +02:00
Bartłomiej Dach
3111844809
Merge pull request #30373 from smoogipoo/tone-down-ternary-warning
...
Change convert-to-ternary warning to hint
2024-10-21 12:51:46 +02:00
Bartłomiej Dach
a90ad63493
Change property type
...
Nobody is supposed to be using `ColourInfo` directly, really.
2024-10-21 12:47:41 +02:00
Bartłomiej Dach
59e9ed7bac
Add test coverage
2024-10-21 12:44:01 +02:00
Bartłomiej Dach
8349226d9f
Merge branch 'master' into barrel_roll_fix
2024-10-21 12:33:37 +02:00
StanR
acf282dddd
Fix effectiveMissCount being calculated wrong
2024-10-21 15:06:34 +05:00
StanR
bcb997028e
Refactor and add comments
2024-10-21 14:38:03 +05:00
Dan Balasescu
fc0ec20db9
Change convert-to-ternary warning to hint
2024-10-21 18:26:42 +09:00
finadoggie
98800fea71
Fix variables being used before being assigned
...
slightly miffed by the lack of build errors but oh well
2024-10-21 00:34:26 -07:00
finadoggie
5907c2a1c4
Only clamp estimated miss count with relevant statistics
2024-10-20 22:47:02 -07:00
finadoggie
3778246a55
Addressed code quality concerns
2024-10-20 22:15:15 -07:00
finadoggie
e31e10d616
merge effectivemisscount functions
...
having two functions was unnecessary
2024-10-20 21:47:01 -07:00
finadoggie
31e0853641
add large tick misses back into effectivemisscount
2024-10-20 21:39:15 -07:00
finadoggie
6d4cb608ab
Revert "use LargeTickHit instead of LargeTickMiss"
...
This reverts commit 1337b7eb41
2024-10-19 05:43:10 -07:00
Wezwery
47936c7b02
Add blank line to TopScoreStatisticsSection.cs:238
2024-10-19 13:41:36 +03:00
Wezwery
df90b726b9
Add highlight to combo and accuracy when max.
2024-10-19 03:08:08 +03:00
TaterToes
5fe074a0f9
Merge branch 'master' into seekingControlPointFix
2024-10-18 10:59:57 -04:00
Bartłomiej Dach
00b2bdd0af
Merge pull request #30334 from SupDos/argonsongprogress-absolute-size
...
Add "Use relative size" setting to argon & default song progress
2024-10-18 13:35:26 +02:00
Bartłomiej Dach
05e2f6db8e
Add preselection indicator for better visibility what will be selected
2024-10-18 13:23:37 +02:00
TaterToes
1cc6309656
attempt to fix formatting
2024-10-18 07:21:05 -04:00
TaterToes
b35b16dc10
Merge branch 'ppy:master' into seekingControlPointFix
2024-10-18 06:07:57 -04:00
Bartłomiej Dach
6576131d58
Merge pull request #30320 from smoogipoo/refactor-bat-component
...
Refactor `BeatmapAttributeText` to compute values on the fly
2024-10-18 11:56:53 +02:00
Bartłomiej Dach
47f10693c4
Add relative size toggle to DefaultSongProgress too
2024-10-18 11:43:03 +02:00
Dan Balasescu
083644b713
Refactor a bit
2024-10-18 18:40:25 +09:00
Bartłomiej Dach
bb4f3c71e0
Add localisation support for "use relative size" setting label
2024-10-18 11:39:55 +02:00
Bartłomiej Dach
8e01020f3e
Merge branch 'master' into refactor-bat-component
2024-10-18 10:50:21 +02:00
Bartłomiej Dach
2ef5fa367b
Merge pull request #30337 from peppy/update-dependencies
...
Update dependencies
2024-10-18 10:50:03 +02:00
Dan Balasescu
e27aa0c761
Return empty strings rather than erroring
...
Preventing malicious actors from permanently destroying games via skins.
2024-10-18 17:18:01 +09:00
Dan Balasescu
2de5e3392e
Only add as many values as are replaced
2024-10-18 17:16:42 +09:00
Bartłomiej Dach
8b4565b3d9
Silence nullref inspection in test
2024-10-18 09:42:08 +02:00
Dean Herbert
7ca5f91c15
Update signalr exceptions in line with deprecated ctor
2024-10-18 16:20:07 +09:00
Dean Herbert
ca2bd640b4
Update all dependencies (except realm, nunit, moq and deepclone)
2024-10-18 16:20:07 +09:00
Bartłomiej Dach
8804769da1
Use better exception messaging
2024-10-18 08:51:01 +02:00
Bartłomiej Dach
b455b9ad09
Discard unused argument
2024-10-18 08:39:23 +02:00
