Dean Herbert
0e4db9b439
Add safety in RectangularPositionSnapGrid that size is greater than zero
...
Would crash otherwise
2023-07-28 16:25:40 +09:00
Dean Herbert
57e51f4d5b
Merge pull request #24357 from peppy/tournament-fix-null-population
...
Fix startup tournament population not recovering from null beatmaps
2023-07-28 14:31:48 +09:00
Dean Herbert
c824b2dedf
Merge pull request #24377 from ILW8/fix-tournament-switcher-height
...
Allow scrolling in tournament setup screen to avoid information ending up off-screen
2023-07-28 14:27:55 +09:00
Dao Heng Liu
c7717da232
make SetupScreen scrollable
2023-07-28 14:18:48 +09:00
Bartłomiej Dach
780b8f0ec8
Merge branch 'master' into tournament-fix-null-population
2023-07-27 22:36:11 +02:00
Bartłomiej Dach
b7ddb5c946
Remove fallbacks to empty APIBeatmap on population failure
...
Was causing there to be two kinds of missing `TournamentBeatmap`s: one
with missing `Beatmap == null`, and one with `Beatmap == new
APIBeatmap()`. In particular, they would appear differently in UI
(either as "unknown - unknown", or the intensely enigmatic " - ").
2023-07-27 22:33:00 +02:00
Bartłomiej Dach
3c923b9e81
Fix even more missed nullability-related inspections
2023-07-27 22:10:41 +02:00
Bartłomiej Dach
22163020c3
Merge pull request #24367 from peppy/fix-replay-export-from-results
...
Fix attempting to export replay from results screen after play not working
2023-07-27 20:47:07 +02:00
Dean Herbert
e702e0a23e
Avoid intercepting temporary files in new test
2023-07-27 17:44:36 +09:00
Dean Herbert
1e9b927b50
Fix some missed null checks
2023-07-27 17:41:27 +09:00
Bartłomiej Dach
057bac39dd
Merge pull request #24375 from peppy/add-back-mode-select-enter-close
...
Add back the ability to close mod select using enter key
2023-07-26 22:43:38 +02:00
Bartłomiej Dach
973e6ded2a
Update wrong comment, too
2023-07-26 21:56:04 +02:00
Bartłomiej Dach
992f78b158
Use more consistent way of closing overlay
2023-07-26 21:54:35 +02:00
Bartłomiej Dach
f66093d3cf
Revert failing test to prior assertions too
2023-07-26 21:51:32 +02:00
Bartłomiej Dach
7bc3edb05a
Fix code quality inspection
2023-07-26 20:52:03 +02:00
Dean Herbert
8d5efc9612
Add back the ability to close mod select using enter key
...
I've seen this brought up a few times (with people thinking
the fact it's not working is a bug) so we'll need to keep this
behaviour for now.
2023-07-27 02:36:25 +09:00
Dean Herbert
fa4992f05a
Apply NRT and avoid throws from null RoundBeatmap.Beatmaps
2023-07-26 17:49:07 +09:00
Dean Herbert
4889864478
Fix files references not correctly being copied after replay import in Player
2023-07-26 15:22:00 +09:00
Dean Herbert
e26afc2b89
Fix ReplayDownloadButton handling key repeat
2023-07-26 15:21:43 +09:00
Dean Herbert
2dace742a3
Add test coverage of score arriving on disk when exporting from results screen after play
2023-07-26 15:21:43 +09:00
Bartłomiej Dach
0b5be51ee0
Merge pull request #24358 from peppy/song-select-drain-length
...
Show break time in tooltip at song select
2023-07-25 23:22:18 +02:00
Bartłomiej Dach
57ccf82f34
Merge branch 'master' into song-select-drain-length
2023-07-25 22:40:45 +02:00
Bartłomiej Dach
653f01f4ce
Merge pull request #24359 from peppy/fix-unknown-mod-test-failure
...
Fix `TestSceneUnknownMod` failing due to null reference
2023-07-25 22:40:03 +02:00
Bartłomiej Dach
5214efca5a
Merge pull request #24208 from peppy/menu-star-fountains
...
Add kiai fountains to main menu
2023-07-25 22:39:07 +02:00
Bartłomiej Dach
c6099edb88
Rename test to match class
2023-07-25 22:18:31 +02:00
Bartłomiej Dach
3b11559fd0
Revert "Show only the break length instead of total minute breaks"
...
This reverts commit 9edaa6909e
2023-07-25 22:17:55 +02:00
Bartłomiej Dach
3b9f250c1b
Merge branch 'master' into menu-star-fountains
2023-07-25 21:58:13 +02:00
Bartłomiej Dach
7c78fcd6f5
Merge pull request #24305 from chayleaf/fix-taiko-hd-hit-overlap
...
Fix alive hitobjects blocking hits in taiko with HD
2023-07-25 21:20:29 +02:00
Bartłomiej Dach
0b7b70fd9c
Merge branch 'master' into fix-taiko-hd-hit-overlap
2023-07-25 20:11:43 +02:00
Bartłomiej Dach
7e98d319d8
Use update-invariant way of checking for second press on same frame
...
Fixes the same issue that 970ea50269
2023-07-25 20:07:03 +02:00
Bartłomiej Dach
b86defbeb1
Merge pull request #24288 from peppy/fix-editor-blueprint-input-extension
...
Fix editor blueprints being selectable for too long when hit markers are enabled
2023-07-25 20:05:40 +02:00
Bartłomiej Dach
5cedd428bb
Add test covering blocking of second hit on same frame
2023-07-25 20:05:37 +02:00
Bartłomiej Dach
e95f9cdd98
Merge branch 'master' into fix-editor-blueprint-input-extension
2023-07-25 19:29:36 +02:00
Bartłomiej Dach
a6da45a99b
Merge pull request #24356 from peppy/fix-scheduler-screen-selection-alignment
...
Fix misalignment of selection box on schedule screen
2023-07-25 19:21:56 +02:00
Bartłomiej Dach
d75e6f78d6
Adjust cyclic selection test to hitcircle lifetime adjustments
...
As it turns out, the tightening of hitcircle lifetimes in editor caused
the test to fail, since the objects were too far apart and at the
starting time of the test, the first object was fully faded out and as
such not alive, therefore leading cyclic selection to fail to select it.
To fix, bring all three objects closer together time-wise so that this
does not happen and the test can continue to exercise its original
behaviour.
2023-07-25 18:54:13 +02:00
Bartłomiej Dach
72db0c17ca
Merge branch 'master' into fix-scheduler-screen-selection-alignment
2023-07-25 18:44:44 +02:00
Bartłomiej Dach
43876ba2b0
Privatise currentMatchSelectionBox
...
Because nobody else should need to do anything as cursed as what
`ScheduleScreen` was doing (which is 95% of the reason why the selection
box even broke there).
2023-07-25 18:41:54 +02:00
Bartłomiej Dach
2c0e419d86
Merge pull request #24284 from ILW8/tourney-dangerous-action-confirm
...
Add confirmation dialog when performing dangerous actions in tournament client
2023-07-25 18:22:17 +02:00
Dean Herbert
c1d93607e0
Fix TestSceneUnknownMod failing due to null reference
2023-07-25 19:06:13 +09:00
Dean Herbert
0130c356ed
Cache IDialogOverlay in a simpler way
2023-07-25 18:33:41 +09:00
Dean Herbert
2c5a329b04
Merge branch 'master' into tourney-dangerous-action-confirm
2023-07-25 18:27:58 +09:00
Dean Herbert
eac6271bd0
Add new property to avoid overlapping usages
2023-07-25 18:14:03 +09:00
Dean Herbert
2f7d38d98b
Merge branch 'master' into fix-editor-blueprint-input-extension
2023-07-25 18:14:02 +09:00
Dean Herbert
ec1b0884f7
Merge pull request #24331 from ILW8/tourney-fix-screen-auto-switch
...
Fix auto advance screens sometimes not advancing
2023-07-25 17:53:27 +09:00
Dean Herbert
43107f8cf0
Fix skin mapping not working for menu fountains
2023-07-25 17:46:05 +09:00
Dean Herbert
7d5305c5e8
Merge branch 'master' into tourney-fix-screen-auto-switch
2023-07-25 17:18:43 +09:00
Dean Herbert
c84381d802
Separate out each type of scheduled operation and refactor tidy-up code
2023-07-25 17:18:13 +09:00
Dean Herbert
9edaa6909e
Show only the break length instead of total minute breaks
2023-07-25 17:02:27 +09:00
Dean Herbert
480163ec2e
Show drain length in length tooltip at song select
2023-07-25 16:58:53 +09:00
Dean Herbert
9cfe9164fa
Add helper method to get drain length (and rename some usages)
2023-07-25 16:58:41 +09:00
