71 Commits

• Revert unintentional behavior change of random mod

  Actually, using OsuPlayfield.BASE_SIZE.Y makes a touch more sense since it is the short side of the playfield, but I guess it is better to preserve replays than to introduce pointless breaking changes.

  Henry Lin · 2022-03-25 15:13:25 +08:00
  e44db4e726
• Convert the position modifier to stateless methods
  Henry Lin · 2022-03-10 11:53:03 +08:00
  3a71d81775
• Move OsuHitObjectPositionModifier to Utils/
  Henry Lin · 2022-03-09 21:52:15 +08:00
  e8dbed738e
• Rename identifiers to remove references to random mod
  Henry Lin · 2022-03-09 20:52:11 +08:00
  6a507ca11b
• Extract hit object positioning logic to a separate class

  It is intentional to not rename the identifiers at this point to produce a cleaner diff.

  Henry Lin · 2022-03-09 20:36:31 +08:00
  37328f8d24
• Attempt to merge conditional expression

  Hoping to fix CI error, caused by older R# version.

  Dan Balasescu · 2022-03-09 17:46:42 +09:00
  353b251d38
• Apply nullable to OsuModRandom rather than using jetbrains annotations
  Dean Herbert · 2022-03-09 16:58:36 +09:00
  75c6a676b4
• Merge getAbsoluteAngle into computeRandomisedPosition
  Henry Lin · 2022-03-09 13:27:33 +08:00
  e3cf2c6acd
• Rename Distance to DistanceFromPrevious
  Henry Lin · 2022-03-09 13:09:33 +08:00
  3ced5e7904
• Add xmldoc
  Henry Lin · 2022-03-08 12:07:10 +08:00
  ae1c65c38d
• Extract a major part of ApplyToBeatmap to a new method
  Henry Lin · 2022-03-08 11:50:30 +08:00
  8cfeffc085
• Separate randomisation and object positioning logic
  Henry Lin · 2022-03-08 11:45:16 +08:00
  ded84cab3f
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Reorganise functions to order more logically (hitcircle before slider methods)
  Dean Herbert · 2021-07-13 19:37:17 +09:00
  4314946e10
• Use switch for pattern matching
  Dean Herbert · 2021-07-13 19:37:02 +09:00
  6b663037e4
• Rename variable
  Bartłomiej Dach · 2021-07-11 16:49:23 +02:00
  63dedb36de
• Rename constant to reflect its purpose
  Bartłomiej Dach · 2021-07-11 16:46:30 +02:00
  7aecafeecb
• Refactor hit object clamping
  Henry Lin · 2021-07-11 22:01:28 +08:00
  c181a724c6
• Rewrite method again to hopefully help readability
  Bartłomiej Dach · 2021-07-10 12:13:36 +02:00
  e10b7867c1
• Rename getSliderBoundingBox and add comments
  Henry Lin · 2021-07-05 09:16:01 +08:00
  eecf4af029
• Fixed slider bounding box calculation
  Henry Lin · 2021-07-01 11:20:55 +08:00
  c69455cfd0
• Move special case handling back to moveSliderIntoPlayfield
  Henry Lin · 2021-07-01 11:03:22 +08:00
  7585f1f790
• Rename shift_object_count to objects_to_shift_before_slider
  Henry Lin · 2021-07-01 11:03:22 +08:00
  6e1839fcf2
• Use Math.Clamp instead of MathHelper.Clamp
  Henry Lin · 2021-07-01 11:03:22 +08:00
  328dcb4d6b
• Refactor and rename getMinSliderMargin to getSliderBoundingBox.
  Henry Lin · 2021-07-01 11:03:22 +08:00
  3c1f0452a2
• Fixed an exception when clamping large sliders
  Henry Lin · 2021-06-30 10:35:06 +08:00
  3f185a0622
• Use IndexInCurrentCombo
  Henry Lin · 2021-06-29 14:25:45 +08:00
  8d1eae7c70
• Take circle radius into account when clamping to playfield
  Henry Lin · 2021-06-29 13:36:30 +08:00
  2722565204
• Added comments
  Henry Lin · 2021-06-29 12:56:05 +08:00
  0c5777c2c8
• Osu random mod improvements

  - Reduce "jump streams" by increasing maximum jump angle and variance in jump angle
  - Reduce weird jumps to sliders by shifting hit circles in front of sliders

  Henry Lin · 2021-06-29 12:33:40 +08:00
  96e09605d8
• Rename VectorUtils to OsuHitObjectGenerationUtils
  Henry Lin · 2021-06-25 09:43:14 +08:00
  26086ca1ef
• Rename VectorHelper to VectorUtils
  Henry Lin · 2021-06-24 22:00:19 +08:00
  3fcda83713
• Extract utility methods into helper class; Better xmldoc and naming
  Henry Lin · 2021-06-24 13:19:42 +08:00
  2268d7f8a5
• Replace and obsolete Ranked flag with IsUserPlayable
  Dean Herbert · 2021-06-09 14:17:03 +09:00
  d0e9f8ef90
• Remove repeat and simplify getMinSliderMargin
  Pasi4K5 · 2021-06-05 17:13:08 +02:00
  b214f2ae0e
• Use SliderPath.GetPathToProgress for getting the SliderPath's positions
  Pasi4K5 · 2021-06-05 17:04:58 +02:00
  f59263932a
• Rename iteration variable
  Pasi4K5 · 2021-06-04 17:22:36 +02:00
  b4f190c6ff
• Fix System.ArgumentException caused by sliders bigger than the playfield
  Pasi4K5 · 2021-06-04 16:50:27 +02:00
  32e41048ff
• Add comment for slider_path_checking_rate
  Pasi4K5 · 2021-06-04 16:26:40 +02:00
  6357d1363c
• Replace Vector2 methods with math operators
  Pasi4K5 · 2021-06-04 16:23:03 +02:00
  a0a6f3ef81
• Rework slider positioning
  Pasi4K5 · 2021-06-04 16:17:54 +02:00
  9f2a9608f2
• Move seed to base class
  Pasi4K5 · 2021-06-03 18:16:11 +02:00
  7a4fc9ffc8
• Add comments explaining the usage of shiftNestedObjects()
  Pasi4K5 · 2021-05-26 20:50:31 +02:00
  d5de5ae640
• Move second call to shiftNestedObjects to a more understandable location
  Dean Herbert · 2021-05-26 16:48:16 +09:00
  a08a4aa911
• Simplify naming
  Dean Herbert · 2021-05-26 16:44:44 +09:00
  d6c4be207b
• Move distanceToPrev inside randomisation function
  Dean Herbert · 2021-05-26 16:44:05 +09:00
  ad3e4287cd
• Make random generator a field to avoid passing around internally
  Dean Herbert · 2021-05-26 16:42:20 +09:00
  6ca9b37c28
• Simplify previous object handling by using a class instead of struct
  Dean Herbert · 2021-05-26 16:42:20 +09:00
  6181b1ac92
• Change internal to public
  Dean Herbert · 2021-05-26 16:31:25 +09:00
  c5ff052096
• Remove redundant parameter and unused setters
  Pasi4K5 · 2021-05-25 21:42:26 +02:00
  c85d5513be