70127 Commits

This Branch

This Branch

All Branches

• Fix retry button on storage unavailable dialog not reopening realm if retry succeeds

  Related: https://github.com/ppy/osu/issues/30539
  
  When starting up the game with a data location that points to an
  unavailable external device, a new realm file is created in the default
  location. Eventually a popup is shown that informs the user that the
  external storage is unavailable, and the user has an option to try the
  storage again. The button that invokes said option would check said
  storage correctly, but would not do anything about realm, which means
  the previously opened empty realm that is placed in the default location
  would remain open, which means the retry essentially doesn't work
  because the user's stuff isn't there after the retry.
  
  To fix this, take out a `BlockAllOperations()`, which will flush all
  open realms, and re-open the realm on the external location if the
  custom storage restore succeeds.

  Bartłomiej Dach · 2024-11-08 09:28:14 +01:00
  091d02b3a8
• Merge pull request #30543 from smoogipoo/fix-ci-report

  Fix up + improve CI test reporting workflow

  Bartłomiej Dach · 2024-11-08 08:37:22 +01:00
  ce9c74af85
• Fix CI test report workflow
  Dan Balasescu · 2024-11-08 11:55:24 +09:00
  233560b867
• Merge pull request #30535 from bdach/fix-hud-shifting-when-flipped-drawables-present

  Fix HUD elements shifting in unintended manner when partially off-screen flipped skin elements are present

  Dan Balasescu · 2024-11-08 01:55:03 +09:00
  8bd65d9938
• Fix HUD elements shifting in unintended manner when partially off-screen flipped skin elements are present

  Closes https://github.com/ppy/osu/issues/30286.

  Bartłomiej Dach · 2024-11-07 14:01:34 +01:00
  b0c6042b2a
• Merge pull request #30525 from smoogipoo/multiplayer-refactor

  Replace `MultiplayerRoomComposite` with local bindings

  Dean Herbert · 2024-11-07 19:53:44 +09:00
  54288c350a
• Skip diffcalc job if target is not valid

  Same as all other jobs... Just so that it doesn't appear as "completed"
  in the workflow list.

  Dan Balasescu · 2024-11-07 19:15:58 +09:00
  cb2e5ac2c4
• Merge pull request #30526 from smoogipoo/fix-beatmap-recommender-test

  Fix intermittent beatmap recommendations test

  Dean Herbert · 2024-11-07 18:40:31 +09:00
  aad9f4078e
• Update xmldoc and make realm transactions more obvious
  Dean Herbert · 2024-11-07 18:31:06 +09:00
  c7d0a7dde2
• Make class partial
  Dan Balasescu · 2024-11-07 17:28:31 +09:00
  4d7fd236c5
• Fix tests not working by forgoing beatmap updates
  Dan Balasescu · 2024-11-07 17:26:10 +09:00
  bd630c189e
• Fix intermittent beatmap recommendations test
  Dan Balasescu · 2024-11-06 21:12:16 +09:00
  35d004cdc2
• Merge pull request #30423 from nekodex/ruleset-selection-duck-tweak

  Increase ducking duration when selecting Mania ruleset

  Dean Herbert · 2024-11-06 18:56:26 +09:00
  35397d90af
• Update resources
  Dean Herbert · 2024-11-06 18:54:52 +09:00
  da95a1a2f1
• Merge branch 'master' into ruleset-selection-duck-tweak
  Dean Herbert · 2024-11-06 18:54:48 +09:00
  366c0f664f
• Fix up tests
  Dan Balasescu · 2024-11-06 16:35:11 +09:00
  9f08b37792
• Replace MultiplayerRoomComposite with local bindings
  Dan Balasescu · 2024-11-06 15:31:27 +09:00
  788ecc1e7b
• Merge pull request #30505 from peppy/editor-hide-breaks

  Add ability to hide breaks from timeline

  Bartłomiej Dach · 2024-11-06 06:54:49 +01:00
  2699ebb50d
• Merge pull request #30509 from bdach/encode-0-01-svs

  Fix effect point scroll speeds below 0.1x not being encoded properly

  Dan Balasescu · 2024-11-06 14:33:19 +09:00
  8aed5784ba
• Merge pull request #30511 from bdach/fix-taiko-drum-roll-editor-weirdness

  Fix drum roll editor blueprint size & input handling

  Dan Balasescu · 2024-11-06 14:26:54 +09:00
  5db52e1027
• Update GHA
  Dan Balasescu · 2024-11-06 14:02:01 +09:00
  4b9f9b9be5
• Merge pull request #30518 from Givikap120/ensure_correct_misscount
  Dan Balasescu · 2024-11-06 13:07:36 +09:00
  9b6d31b249
• reset to miss instead of 0
  Givikap120 · 2024-11-05 22:15:18 +02:00
  f3251bfcfd
• Update OsuPerformanceCalculator.cs
  Givikap120 · 2024-11-05 22:08:43 +02:00
  ec046651b2
• Fix drum roll editor blueprint size & input handling
  Bartłomiej Dach · 2024-11-05 13:12:01 +01:00
  5668c62446
• Fix effect point scroll speeds below 0.1x not being encoded properly

  Closes https://github.com/ppy/osu/issues/30472.
  
  Caused by mismatching bounds between
  
  	https://github.com/ppy/osu/blob/2bd12e14dbc7fd6fe29c6db53923c7da1d4b7557/osu.Game/Beatmaps/ControlPoints/EffectControlPoint.cs#L22-L26
  
  and
  
  	https://github.com/ppy/osu/blob/2bd12e14dbc7fd6fe29c6db53923c7da1d4b7557/osu.Game/Beatmaps/ControlPoints/DifficultyControlPoint.cs#L21-L28

  Bartłomiej Dach · 2024-11-05 11:56:19 +01:00
  23f3890293
• Fix LegacyBeatmapEncoderTest swapping expected/actual values around

  Was making test output look confusing.

  Bartłomiej Dach · 2024-11-05 11:51:59 +01:00
  0e8dce5527
• Add failing test case
  Bartłomiej Dach · 2024-11-05 11:51:07 +01:00
  48ce4fdd16
• Merge pull request #30467 from cdwcgt/friend-add

  Add the ability to add/remove friends in `UserProfileHeader`

  Bartłomiej Dach · 2024-11-05 10:25:27 +01:00
  2bd12e14db
• add AddFriendResponse
  cdwcgt · 2024-11-05 15:55:42 +08:00
  c576fd8448
• Handle response to get accurate mutual state immediately
  Dean Herbert · 2024-11-05 16:20:55 +09:00
  1fcdf67806
• Update status and count immediately after friend request completes
  Dean Herbert · 2024-11-05 14:53:54 +09:00
  0087270b7e
• Merge pull request #30496 from bdach/copy-link-to-score

  Add context menu option to copy link to an online score

  Dean Herbert · 2024-11-05 14:03:47 +09:00
  f21d2de8e8
• Merge pull request #30499 from bdach/search-friends

  Add search textbox to friends display

  Dan Balasescu · 2024-11-05 13:29:59 +09:00
  fcc6319417
• Add ability to hide breaks from timeline

  This was another IRL request from a mapper / team member. The rationale
  here is that it can be very annoying to map with break time enabled if
  you have a large gap in the beatmap you are trying to fill with
  hitobjects, as you are placing objects on top of a very gray area.

  Dean Herbert · 2024-11-05 12:56:19 +09:00
  9d65d394d3
• Remove redundant initialiser
  Bartłomiej Dach · 2024-11-04 14:49:11 +01:00
  74d5de2d13
• Add search textbox in friends display

  Random user feature request that made sense to me because the same thing
  is in currently online display.
  
  Yes web doesn't have this, but web is in a browser where you can Ctrl-F.
  You can't do that in the client.
  
  Design taken out of posterior because I can't be bothered waiting for
  design cycles for this.

  Bartłomiej Dach · 2024-11-04 14:40:30 +01:00
  1dee041448
• Add context menu option to copy link to an online score

  I feel like this may become useful soon enough to help diagnose weird
  issues.

  Bartłomiej Dach · 2024-11-04 13:59:48 +01:00
  6a1893ff3f
• Extract "copy link" text to common localisation
  Bartłomiej Dach · 2024-11-04 13:59:48 +01:00
  51f26993fa
• Remove weird method
  Bartłomiej Dach · 2024-11-04 13:13:23 +01:00
  e064965281
• Merge pull request #30484 from peppy/store-scale-origin-mode

  Remember origin for editor scale/rotation popover

  Bartłomiej Dach · 2024-11-04 12:58:06 +01:00
  00e795cf76
• Adjust colours to actually match web
  Bartłomiej Dach · 2024-11-04 12:02:20 +01:00
  cb833007e0
• Merge pull request #30456 from smoogipoo/revert-taiko-convert-diffcalc-change

  Bring back convert nerf to fix overweighted taiko difficulty

  Dean Herbert · 2024-11-04 20:00:58 +09:00
  2024.1104.0 795477372f
• Merge pull request #30460 from Lawtrohux/t-speed-deviation

  Implement stamina consideration for Mono (single-coloured) patterns.

  Dean Herbert · 2024-11-04 19:38:50 +09:00
  c99c82ab08
• Merge pull request #30482 from peppy/adjust-minimum-scale

  Allow scaling down to 5% in popover scale dialog

  Bartłomiej Dach · 2024-11-04 11:34:42 +01:00
  7d39765f71
• Fix rotation popover potentially crashing due to activating selection origin just before disabling it
  Bartłomiej Dach · 2024-11-04 10:58:48 +01:00
  e2a4a9b300
• Merge pull request #30489 from iSlodinxOsu/loved

  Remove `by the beatmap creator` in `PlayerLoaderStrings`

  Dean Herbert · 2024-11-04 18:39:21 +09:00
  c4a02b7991
• Merge branch 'master' into adjust-minimum-scale
  Bartłomiej Dach · 2024-11-04 10:37:01 +01:00
  d0d28e5bd4
• Fix scale clamps undoing the intended 5% scaling minimum
  Bartłomiej Dach · 2024-11-04 10:36:49 +01:00
  f616c7b752
• Merge pull request #30454 from lukektx/key-reversion-conflict

  Prevent key bind conflict popup when default key is assigned to secondary binding

  Bartłomiej Dach · 2024-11-04 08:56:15 +01:00
  1868549a3f