1
0
mirror of https://github.com/ppy/osu.git synced 2025-03-01 06:52:58 +08:00
Commit Graph

65963 Commits

Author SHA1 Message Date
Mike Will
906560f66d Fix mute button test
Lowering the master volume in the previous test meant that the
volume levels would end up being modified.
2024-02-02 04:06:22 -05:00
Mike Will
29a2890582 fix code quality error #2 2024-02-02 03:47:19 -05:00
Dan Balasescu
8c107b4925
Merge pull request #26950 from bdach/2fa-in-registration
Add 2FA verification screen to registration flow
2024-02-02 17:30:20 +09:00
Mike Will
c60e110976 Try to fix code quality issues raised by workflow 2024-02-02 03:09:19 -05:00
Mike Will
5d9200b4fe Update tests to reflect new restore target volume 2024-02-02 02:59:02 -05:00
Mike Will
f4a2d5f3f4 Round off inaccuracies in the aggregate volume before evaluating 2024-02-02 02:41:58 -05:00
Mike Will
3122211268 Change silence threshold and target restore volume level 2024-02-02 02:12:46 -05:00
Dan Balasescu
108375975d
Merge pull request #26940 from EVAST9919/playfield-mods-alloc
Reduce allocation overhead in `Playfield`
2024-02-02 15:45:46 +09:00
Bartłomiej Dach
091618db1a
Add test coverage of full account creation flow 2024-02-02 07:25:07 +01:00
Bartłomiej Dach
a00cf87925
Add 2FA verification screen to registration flow 2024-02-02 07:25:04 +01:00
Bartłomiej Dach
45f60b035e
Enable NRT in AccountCreationOverlay 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
93d34e4115
Enable NRT in ScreenWarning 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
b58ac7950b
Make game dependency in ScreenEntry optional to unbreak tests 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
bb6387bea0
Enable NRT in ScreenEntry 2024-02-02 07:24:32 +01:00
Bartłomiej Dach
5260b8cae0
Merge pull request #26920 from peppy/2fa-visibility
Give better visibility when the game is pending 2FA
2024-02-02 07:10:45 +01:00
Mike Will
dfd966e039 Improve silence detection in MutedNotification
Instead of checking the master and music volumes separately to
see if they're <= 1%, check the aggregate of the two volumes to
see if it's <= -60 dB.

When muted notification is activated, restore the aggregate volume
level to -30 dB.
2024-02-02 00:48:42 -05:00
Bartłomiej Dach
2ff46daf5e
Also change icon and tooltip text when pending 2FA 2024-02-02 06:40:56 +01:00
Andrei Zavatski
53c5483eba Reduce allocation in Playfield 2024-02-02 04:53:48 +03:00
Loreos7
8dce158a13 localise update-related strings 2024-02-02 04:49:22 +03:00
Loreos7
7884e5808a localise remaining strings 2024-02-02 04:47:13 +03:00
Andrei Zavatski
e00e583bb4 Fix DrawableManiaRuleset performing skin lookup every frame 2024-02-02 03:56:38 +03:00
Salman Ahmed
4dbcb41dd1 Remove unused parameter 2024-02-02 00:44:51 +03:00
Bartłomiej Dach
ea76f7a5d8
Allow pp for Double/Half Time's "adjust pitch" setting 2024-02-01 22:33:49 +01:00
Bartłomiej Dach
96f66aaa2e
Allow pp for Accuracy Challenge
Addresses https://github.com/ppy/osu/discussions/26919.
2024-02-01 22:30:26 +01:00
Bartłomiej Dach
c114fd8f89
Allow pp for Sudden Death and Perfect regardless of "restart on fail" setting
Closes https://github.com/ppy/osu/issues/26844.
2024-02-01 22:28:49 +01:00
Bartłomiej Dach
865f4d76ff
Add unranked indicator to song select footer too 2024-02-01 21:51:41 +01:00
Bartłomiej Dach
f87ab19731
Apply NRT to FooterButtonMods 2024-02-01 21:32:38 +01:00
Bartłomiej Dach
966093f7ce
Transform score multiplier display to also show ranked state 2024-02-01 21:32:37 +01:00
Susko3
f92751a7d2 Don't suggest an update on mobile if it isn't available 2024-02-01 18:56:38 +01:00
Susko3
b9d750cfee Convert to try-get and don't fall back to release URL 2024-02-01 18:55:34 +01:00
Susko3
b0095ee548 Apply NRT 2024-02-01 18:38:18 +01:00
Andrei Zavatski
66350fd148 Refactor UserRankPanel layout 2024-02-01 16:33:54 +03:00
Andrei Zavatski
2bd9dcf646 Rework UserGridPanel to reduce containers nesting 2024-02-01 16:22:07 +03:00
Andrei Zavatski
b0f6a87a2b Add stress test in TestSceneDashboardOverlay 2024-02-01 16:22:07 +03:00
Salman Ahmed
6ab8960fdc Add step for toggling skins in results screen test scene 2024-02-01 16:08:48 +03:00
Salman Ahmed
5bbaeb6836 Play legacy applause sound only when rank is B or higher 2024-02-01 16:08:36 +03:00
syscats
0407b5d84a
use ordinal sorting on each method 2024-02-01 14:03:59 +01:00
Salman Ahmed
35c3f5e250 Merge branch 'master' into fix-results-f-rank 2024-02-01 15:29:07 +03:00
Dean Herbert
bf3746daa8
Show login overlay at main menu when 2FA is required 2024-02-01 21:10:53 +09:00
Dean Herbert
563f4a26b1
Show "failing" icon on user panel when 2FA prompt is present
This gives the user a chance to know it's required.
2024-02-01 21:10:37 +09:00
syscats
7165511754 Use ordinal sorting for artist string comparison 2024-01-31 15:49:31 +01:00
Bartłomiej Dach
f89923aeae
Annotate mods that give pp 2024-01-31 14:59:35 +01:00
Dan Balasescu
0642d74014
Expose as ReadOnlyDictionary 2024-01-31 22:52:57 +09:00
Bartłomiej Dach
e71c95f1fe
Reintroduce IMod.Ranked
What goes around, comes around.
2024-01-31 14:48:35 +01:00
Dean Herbert
7cdedfb6ca
Merge pull request #26889 from peppy/remove-cachebust-online-image
Fix menu banner not updating as often as we want it to
2024-01-31 22:44:39 +09:00
Dean Herbert
4248593289
Fix menu banner not updating as often as we want it to 2024-01-31 22:44:24 +09:00
Dean Herbert
89a5be13e2
Merge pull request #26885 from bdach/slider-end-flip-fail
Fix slider end judgements appearing at incorrect locations when mods that flip playfield are active
2024-01-31 22:39:37 +09:00
Bartłomiej Dach
dfea2ade6d
Revert incorrect end position optimisation
Closes https://github.com/ppy/osu/issues/26867.

Reverts 882f490390
and ce643aa68f.

The applied optimisation may have been valid as long as it was
constrained to `Slider`. But it is not, as `SliderTailCircle` stores a
local copy of the object position. And as the commit message of
ce643aa68f states, this could be bypassed
by some pretty hacky delegation from `SliderTailCircle.Position` to the
slider, but it'd also be pretty hacky because it would make flows like
`PositionBindable` break down.

Long-term solution is to probably remove bindables from hitobjects.
2024-01-31 12:45:42 +01:00
Bartłomiej Dach
a934556bb8
Add failing assertions for head/tail positions after flip 2024-01-31 12:40:03 +01:00
Bartłomiej Dach
f927cb5928
Increase repeat count for better coverage of flip operations 2024-01-31 12:39:48 +01:00