245 Commits

• Dispose previous waveform on track reload
  Salman Ahmed · 2022-12-23 00:35:59 +03:00
  30de9ba795
• Invalidate waveform on track load
  ansel · 2022-12-22 20:49:09 +03:00
  20370bd5ae
• Rewrite waveform invalidation
  ansel · 2022-12-22 15:59:51 +03:00
  d0645ce151
• Clear cached waveform on track change in editor
  ansel · 2022-12-22 01:23:24 +03:00
  66a02374da
• Fix incorrect offset logic for beatmaps without a preview point specified
  Dean Herbert · 2022-10-12 14:47:37 +09:00
  db148d145b
• Rename parameter to read better
  Dean Herbert · 2022-10-12 14:46:35 +09:00
  721bfb5369
• Update WorkingBeatmap.cs
  NotGumballer91 · 2022-10-11 01:48:55 +08:00
  3cd6ce8e3f
• Update WorkingBeatmap.cs
  NotGumballer91 · 2022-10-10 21:03:11 +08:00
  749dc40062
• Merge branch 'master' of https://github.com/ppy/osu into remove-the-nullable-disable-in-the-ruleset

  # Conflicts:
  #	osu.Game.Rulesets.Catch/CatchRuleset.cs
  #	osu.Game.Rulesets.Osu/OsuRuleset.cs
  #	osu.Game.Rulesets.Taiko/TaikoRuleset.cs
  #	osu.Game/Rulesets/Ruleset.cs

  andy840119 · 2022-09-10 10:40:12 +08:00
  e62999fb16
• Fix a couple of oversights regarding track nullability
  Dean Herbert · 2022-08-25 14:45:00 +09:00
  ad3dd1c700
• Allow preparing preview point without looping
  Dean Herbert · 2022-08-17 13:20:24 +09:00
  37799e3b31
• Mark the CreateBeatmapProcessor() as nullable.

  Also, should add the null check in the working beatmap.

  為什麼 · 2022-07-10 10:15:27 +08:00
  57c6763556
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Use Track to ensure its loaded before transferring
  Salman Ahmed · 2022-05-21 16:52:16 +03:00
  a17eed64f9
• Bring back virtual track condition given its cheapness

  Will still keep the override in `ClockBackedTestWorkingBeatmap` because
  it still relies on a local track store and will fail the moment it uses
  a non-virtual track.

  Salman Ahmed · 2022-05-21 16:51:56 +03:00
  a42f5ea34e
• Fix wrong return xmldoc

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2022-05-21 16:43:31 +03:00
  466ed3c791
• Refactor track transferring logic for ability to override and disallow
  Salman Ahmed · 2022-05-20 14:43:07 +03:00
  c78d90ccbd
• Change WorkingBeatmap.GetVirtualTrack to use length provided by BeatmapInfo

  A lot of tests are using test resources that populate the length field,
  but do not populate hitobjects. The general expectation is that
  components should be using the cached length in cases where hitobjects
  are not relevant, but `GetVirtualTrack` was doing its own local
  calculation.
  
  This could cause tests to fail due to `MusicController` changing track
  in the background.

  Dean Herbert · 2022-04-06 14:51:15 +09:00
  552ec5282f
• Fix incorrect Metadata-related null checks
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  df088f96f4
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Revert "Apply NRT to WorkingBeatmap"

  This reverts commit 9e17d7d4e3.

  Dean Herbert · 2021-12-22 19:14:18 +09:00
  bc47801cbb
• Apply NRT to WorkingBeatmap
  Dean Herbert · 2021-12-22 18:41:45 +09:00
  9e17d7d4e3
• Move public accessor properties to top of file
  Dean Herbert · 2021-12-22 18:25:09 +09:00
  53c0a6708f
• Move load methods and rename loadedTrack to match other private fields
  Dean Herbert · 2021-12-22 18:24:51 +09:00
  a5f77a86ef
• Remove RecyclableLazy
  Dean Herbert · 2021-12-22 18:18:12 +09:00
  7344c87b16
• Remove unused load checks
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  f3f491374b
• Reorder methods to hopefully make more sense
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  3c95497ed7
• Enable NRT on IWorkingBeatmap
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  e38e4c0adc
• Remove BeatmapSetInfo and Metadata from interface

  There were very few accesses to this, and after realm they should all be
  done via the `BeatmapInfo`, so let's remove this.

  Dean Herbert · 2021-12-22 18:17:00 +09:00
  967419c9ac
• Simplify WorkingBeatmap in multiple ways

  Just a clean-up pass.

  Dean Herbert · 2021-12-22 18:17:00 +09:00
  1b0af78831
• Convert BeatmapMetadata access to be via a computed property
  Dean Herbert · 2021-12-22 18:17:00 +09:00
  b38b300159
• Use consistent type for mod collection in all overloads
  Bartłomiej Dach · 2021-11-21 11:30:45 +01:00
  bb8e8bc4f0
• Clean up cancellation handling in WorkingBeatmap

  After the recent changes introducing cancellation support to
  `WorkingBeatmap`, it turned out that if the cancellation support was
  used, `GetPlayableBeatmap()` would raise timeout exceptions rather than
  the expected `OperationCanceledException`.
  
  To that end, split off a separate overload for the typical usage, that
  catches `OperationCanceledException` and converts them to beatmap load
  timeout exceptions, and use normal `OperationCanceledException`s in the
  overload that requires a cancellation token to work.

  Bartłomiej Dach · 2021-11-20 17:23:55 +01:00
  6100bf66a6
• Only apply default timeout when debugger not attached
  Dean Herbert · 2021-11-18 23:26:45 +09:00
  bf8507c7b9
• Revert incorrect ordering change
  Bartłomiej Dach · 2021-11-17 22:10:46 +01:00
  1c13b39104
• Merge branch 'master' into beatmap-cancellation-token
  Dean Herbert · 2021-11-17 11:16:10 +09:00
  0715d40ea0
• Add back default timeout to GetPlayableBeatmap
  Dean Herbert · 2021-11-17 11:06:31 +09:00
  13f3e2eea9
• Merge branch 'master' into i-working-beatmap/difficulty-calculator
  Dean Herbert · 2021-11-16 16:19:22 +09:00
  f5c52755c9
• Remove no longer used helper method
  Dean Herbert · 2021-11-16 14:48:02 +09:00
  d2a7670494
• Standardise naming of CancellationToken parameters
  Dean Herbert · 2021-11-16 14:45:51 +09:00
  6cca657a2d
• Merge branch 'master' into beatmap-cancellation-token
  Dean Herbert · 2021-11-16 14:43:13 +09:00
  53c0682a08
• Remove now-unnecessary R# disables
  Dan Balasescu · 2021-11-15 19:40:31 +09:00
  1d87b47fec
• Implement remaining properties via implicit implementation rather than interface methods
  Dean Herbert · 2021-11-15 19:30:46 +09:00
  a90cfb4a2f
• Update DifficultyCalculator to take an IRulesetInfo
  Dean Herbert · 2021-11-15 19:16:48 +09:00
  369b4ba789
• Expose more of WorkingBeatmap via interface
  Dean Herbert · 2021-11-15 18:25:48 +09:00
  a0e25d18cd
• Remove unnecessary TimeSpan timeout parameter (CancellationToken can now be used)
  Dean Herbert · 2021-11-08 14:33:32 +09:00
  97345ac9e6
• Rename CancellationToken variable
  Tollii · 2021-11-07 13:41:54 +01:00
  d5f5d74a89
• Fix PR comments.

  Nitpick, more cancellation token checks.

  Tollii · 2021-11-06 16:03:53 +01:00
  cf0b757b16
• Add support for a provided cancellation token for GetPlayableBeatmap()
  Tollii · 2021-11-05 23:53:48 +01:00
  f0caa10066