Dan Balasescu
cc59434ea4
Fix crash due to being too forgiving of nulls
...
This one is super duper annoying to test, because we already have e.g.
`TestScenePlaylistsScreen`. The only way to test it would be to use an
`OsuGameTestScene`.
Maybe this is okay?
2024-11-21 20:52:34 +09:00
Bartłomiej Dach
2eef920e70
Merge pull request #30805 from smoogipoo/fix-playlists-enter-status
...
Fix playlist room status resetting on enter
2024-11-21 12:50:39 +01:00
Dan Balasescu
dc45816566
Fix inspection
2024-11-21 20:41:14 +09:00
Dan Balasescu
6870c99eb2
Enable NRT for multiplayer and playlists
2024-11-21 20:32:09 +09:00
Bartłomiej Dach
0e4d078beb
Merge branch 'master' into catch-improve-info-on-selected
2024-11-21 12:17:54 +01:00
Bartłomiej Dach
2138729c02
Do not show distance to next/previous object if said object is a banana shower
...
The results of such a display were a little bit nonsensical.
2024-11-21 12:17:43 +01:00
Dan Balasescu
8dbf750446
Fix inspection
2024-11-21 18:38:56 +09:00
Dean Herbert
033b7c17d5
Add back macOS precheck
2024-11-21 18:13:00 +09:00
Dan Balasescu
7018672275
Fix playlist room status resetting on enter
2024-11-21 18:11:41 +09:00
Dan Balasescu
fe8e9d455a
Add failing test
2024-11-21 18:09:39 +09:00
Cadence Ember
37394a5027
Use consistent decimal places in BeatmapAttributeText
2024-11-21 14:04:42 +13:00
Dean Herbert
2c0140f865
Merge pull request #30798 from frenzibyte/fix-precision
...
Add sane precision values to all settings
2024-11-21 03:00:49 +09:00
Dean Herbert
ae98f63b51
Fix beatmap load not continuing when when settings slider is focused
...
Regressed with recent sliderbar focus changes.
Closes #30716 .
2024-11-21 02:28:35 +09:00
Dean Herbert
945139635f
Add failing test case
2024-11-21 02:27:57 +09:00
Salman Alshamrani
40b95901e3
Fix more cases of settings with no defined precision values
2024-11-20 12:11:38 -05:00
Salman Alshamrani
1ef02fec06
Fix "positional hitsounds level" setting not specifying a precision constraint
2024-11-20 12:08:57 -05:00
Dean Herbert
ba21ad2b81
Merge pull request #30795 from bdach/compatibility-export-stability-test-coverage
...
Add test case covering stability of compatibility export operation
2024-11-21 01:43:38 +09:00
Dean Herbert
faa03d9a48
Merge pull request #30794 from Fivoka/Adjust-beat-synced-animation-to-be-smoother-in-skip-and-break-overlay
...
Adjust beat synced animation to be smoother in skip and break overlay
2024-11-21 00:27:09 +09:00
Bartłomiej Dach
dfa32302ac
Add test case covering stability of compatibility export operation
...
This is important as the format will be used more when lazer beatmap
submission comes online, and its stability is a useful property for
that.
Included archive contains an `.osu` with a few fractional-millisecond
timing points and objects, as well as a multi-segment-type slider. That
should cover the range of all possible modifications that the
compatibility exporter currently performs.
2024-11-20 13:26:54 +01:00
Fivoka
7726ca02b0
Changed multiplier from 2 to 3.5
2024-11-20 12:29:29 +01:00
Dean Herbert
fabeb6f838
Merge pull request #30634 from smoogipoo/multiplayer-remove-cmc-and-composite
...
Remove `CachedModelDependencyContainer` and `OnlinePlayComposite` from multiplayer
2024-11-20 19:07:28 +09:00
Dan Balasescu
b1389edbfe
Merge pull request #30755 from bdach/fix-mania-notes-disappearing
...
Fix mania notes disappearing on seek to their end time
2024-11-20 17:55:47 +09:00
Dean Herbert
6fba6de4dc
Merge branch 'master' into multiplayer-remove-cmc-and-composite
2024-11-20 17:24:55 +09:00
Dean Herbert
c6d08daee8
Remove MultiplayerMatchSubScreen
flaky test attribute
...
Didn't really work to fix these tests due to the sticky nature of the
failure. Also I can no longer reproduce locally, so the hope is that
these are fixed by https://github.com/ppy/osu/pull/30634 .
2024-11-20 17:11:49 +09:00
Dean Herbert
03de518484
Fix missing updateRoomPlaylist
call
2024-11-20 16:56:22 +09:00
Dean Herbert
50089c027e
Update framework
2024-11-20 16:40:33 +09:00
Dean Herbert
b4077fc8a2
Use !FrameworkEnvironment.UseSDL3
instead of removing warning altogether
2024-11-20 16:28:11 +09:00
Dan Balasescu
53f0befc05
Merge pull request #30402 from peppy/import-paused-visibility
...
Update notification text when import is paused due to gameplay
2024-11-20 16:00:13 +09:00
Dean Herbert
b070a50ac9
Merge pull request #30718 from frenzibyte/initial-key-counter-state
...
Fix key counter not updating activation state on initial load
2024-11-20 15:39:44 +09:00
Dan Balasescu
9ac877606b
Fix inspection issues
2024-11-20 12:32:42 +09:00
Darius Wattimena
a8e14b6625
Align inspector info more to how it is shown for osu
2024-11-19 19:54:12 +01:00
Dan Balasescu
a5327aa562
Use properties instead of fields
2024-11-19 18:48:30 +09:00
Bartłomiej Dach
273095fd82
Merge pull request #30757 from peppy/fix-scroll-absolute-pos
...
Fix right click scroll at song select not quite matching scrollbar position
2024-11-19 10:40:00 +01:00
Darius Wattimena
111f029ead
Added a custom hitobject inspector for catch additionally show the x value of prev and next
2024-11-18 23:53:01 +01:00
Darius Wattimena
16158710f9
Made reading of ReadCurrentDistanceSnap public
2024-11-18 23:49:40 +01:00
Dean Herbert
a529cef28b
Merge pull request #30743 from peppy/collection-scroll-etc
...
Further UX improvements to collection management
2024-11-19 00:32:16 +09:00
Dean Herbert
1d6eb9abf4
Merge pull request #30756 from bdach/reset-new-combo-state
...
Deactivate new combo toggle on deselecting objects
2024-11-18 23:54:57 +09:00
Dean Herbert
a2af4cbb50
Fix right click scroll at song select not quite matching scrollbar position
...
Closes https://github.com/ppy/osu/issues/30744 .
2024-11-18 23:54:56 +09:00
Bartłomiej Dach
307c2e15a4
Merge branch 'master' into collection-scroll-etc
2024-11-18 15:35:19 +01:00
Bartłomiej Dach
22b082d968
Fix not being able to scroll to new collection text box when list overflows
2024-11-18 15:28:30 +01:00
Bartłomiej Dach
259e9ecf65
Deactivate new combo toggle on deselecting objects
...
Closes https://github.com/ppy/osu/issues/30713 .
Was a point of discussion doing review:
https://github.com/ppy/osu/pull/30214#discussion_r1798833139
Given it got pointed out immediately for something so minor, I'm
inclined to believe it's a rather undesirable change.
2024-11-18 15:13:32 +01:00
Bartłomiej Dach
15a8cfe685
Fix mania notes disappearing on seek to their end time
2024-11-18 14:37:09 +01:00
Salman Alshamrani
0b52080a52
Handle logged out user
2024-11-18 06:47:22 -05:00
Salman Alshamrani
74daf85e48
Replace bindable with an event
2024-11-18 06:47:22 -05:00
StanR
4066186b24
Scale beatmap cards down by ~0.8
2024-11-18 14:48:51 +05:00
Bartłomiej Dach
28fb0bf909
Merge pull request #30747 from smoogipoo/remove-maui-workflow
...
Build Android with non-maui workflow
2024-11-18 10:16:34 +01:00
StanR
dcf4674c6c
Scale down beatmap cards in profile overlay
2024-11-18 14:01:17 +05:00
Dan Balasescu
02deb39335
Make android build on non-maui workflow
2024-11-18 17:20:11 +09:00
Dean Herbert
ebc2cc3570
Ensure cleanup tasks are run even on a cancelled / exceptioned import task
2024-11-18 16:51:46 +09:00
Dean Herbert
5ce1f7679b
Add search bar to collection management dialog
2024-11-18 16:32:56 +09:00