1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 18:10:04 +08:00
Commit Graph

54820 Commits

Author SHA1 Message Date
OliBomby
91e6f4c4ee fix TestPerfectCurveChangeToBezier 2022-08-19 19:31:47 +02:00
OliBomby
d1519343f6 Improved visual tests for slider splitting 2022-08-19 18:29:01 +02:00
Dean Herbert
339f0b0cd2 Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-19 23:01:09 +09:00
Jay L
c1da509119 round numerical value
this is painfully annoying me
2022-08-19 23:23:40 +10:00
Jay L
faf143b11a fix comment 2022-08-19 23:15:38 +10:00
Dan Balasescu
4ef8e00a78
Merge pull request #19851 from peppy/update-framework
Update framework and resources
2022-08-19 22:03:55 +09:00
Jay L
b30fba1430 emc attribute 2022-08-19 22:57:40 +10:00
Jay L
fea31cc895 introduce effective misscount, accuracy rescale 2022-08-19 22:57:28 +10:00
Dean Herbert
7bf318541c Reword comment to hopefully read better 2022-08-19 20:57:55 +09:00
Dean Herbert
c3c44c19cd Use CompositeComponent in various locations 2022-08-19 20:43:15 +09:00
Dean Herbert
41321521e5 Update resources 2022-08-19 20:40:05 +09:00
Dean Herbert
426c4c9bf7 Update framework 2022-08-19 20:39:53 +09:00
Dean Herbert
3f0da14065 Delay start operation by one frame to allow children to see initial start time 2022-08-19 17:39:51 +09:00
vun
f3e1287f04 Remove redundant using statement 2022-08-19 16:19:45 +08:00
vun
684efefb50 Add FirstHitObject as a property of encoding classes 2022-08-19 16:13:36 +08:00
vun
a26de0a10f Add HitType property to MonoStreak 2022-08-19 16:05:34 +08:00
vun
51176e9577 Naming changes 2022-08-19 15:45:43 +08:00
vun
5dcd4ce7c5 Naming changes 2022-08-19 15:31:03 +08:00
Jamie Taylor
41408a3106
Add audio feedback for text selection 2022-08-19 15:51:27 +09:00
OliBomby
89eb0a4079 Added TestScene for slider splitting 2022-08-19 01:10:54 +02:00
its5Q
4c24d8ed58 Improve string consistency 2022-08-19 03:17:05 +10:00
Dean Herbert
e7d4962128
Merge branch 'master' into no-gameplay-clock-gameplay-offset 2022-08-19 01:50:14 +09:00
Dean Herbert
3eb1cda6aa Reorganise call order of Start / Reset to make more sense 2022-08-19 01:46:36 +09:00
Dean Herbert
15d49b0357 Update TestSceneSpectator to user new assert style 2022-08-19 01:46:19 +09:00
Dean Herbert
1d774f3f12 Remove redundant ProcessFrame calls
Of note, I'm not sure whether the `IsPaused` check was meaningful, but
it's not reimplemented in the new `FramedBeatmapClock`.
2022-08-19 01:39:02 +09:00
Dean Herbert
7bc96431a7 Remove unnecessary virtual spec from GameplayClockContainer.Seek 2022-08-19 01:39:01 +09:00
Dean Herbert
0e228791c0 Remove unnecessary Reset call in MultiSpectatorScreen 2022-08-19 01:39:01 +09:00
Dean Herbert
cc86909633 Increase lenience on TestSceneLeadIn tests
I've gone through these in detail and can't find an issue with the
actual flow of things. For whatever reason, the new structure has a
slightly higher delay, likely due to performing less `Seek` calls
(previously a `Seek` was called after the clock start which may have
been making this more accurate on the first `Player.Update`).

I don't think it really matters that this is slightly off, but we'll see
how this plays out.
2022-08-19 01:39:00 +09:00
Bartłomiej Dach
bc851c174b
Merge pull request #19836 from peppy/split-offset-clock
Split `OffsetCorrectionClock` out of `MasterGameplayClockContainer`
2022-08-18 18:26:51 +02:00
Bartłomiej Dach
4ad782b5a0
Merge branch 'master' into split-offset-clock 2022-08-18 17:52:45 +02:00
Dean Herbert
0f0b4fdfec
Merge pull request #19838 from peppy/test-scene-lead-in-updates
Update `TestSceneLeadIn` to use new assert style
2022-08-18 20:55:55 +09:00
Dean Herbert
2eba8650ca Update TestSceneLeadIn to use new assert style 2022-08-18 19:26:19 +09:00
Dean Herbert
43879633db Ensure setting a StartTime on a GameplayClockContainer always resets to the new time 2022-08-18 18:54:10 +09:00
Dean Herbert
343efa1d11 Split OffsetCorrectionClock out of MasterGameplayClockContainer 2022-08-18 18:54:10 +09:00
Dean Herbert
2c6fd1ec6e Fix `GameplayClockContainer potentially resetting external seeks 2022-08-18 18:54:10 +09:00
Dean Herbert
728cd96508 Update TestSceneLeadIn to use new assert style 2022-08-18 18:54:10 +09:00
Dean Herbert
bcc153f738 Add xmldoc and reorganise FramedBeatmapClock 2022-08-18 18:54:10 +09:00
Dean Herbert
6003afafc7 Use FramedBeatmapClock in GameplayClockContainer 2022-08-18 18:54:10 +09:00
Dean Herbert
32e127a6fa Add FramedBeatmapClock
Expose `IsCoupled` in `FramedBeatmapClock` for now to provide editor compatibility
2022-08-18 18:54:10 +09:00
Dan Balasescu
fa167b1d12
Merge pull request #19779 from peppy/no-gameplay-clock
Remove all remaining usage of `GameplayClock`
2022-08-18 18:52:57 +09:00
Dean Herbert
3e34959a6e
Merge pull request #19833 from smoogipoo/fix-backwards-asserts
Fix some backwards asserts
2022-08-18 18:42:23 +09:00
Dan Balasescu
5d8d584afb Fix some backwards asserts 2022-08-18 18:08:46 +09:00
Dan Balasescu
c4dee1cf6d
Merge pull request #19832 from peppy/fix-taiko-span-blueprint-overlay
Fix taiko blueprints displaying incorrectly for drum rolls
2022-08-18 17:57:14 +09:00
Dan Balasescu
8480703e0b
Merge pull request #19831 from peppy/fix-zero-length-taiko-spans
Fix taiko drum rolls with zero length being placeable in editor
2022-08-18 17:56:46 +09:00
Dean Herbert
ad28bfc9b2 Fix taiko blueprints displaying incorrectly for drum rolls 2022-08-18 17:18:11 +09:00
Dean Herbert
48fac9f8a5 Fix taiko drum rolls with zero length being placeable in editor
Addresses https://github.com/ppy/osu/discussions/19808.
2022-08-18 16:50:36 +09:00
Dean Herbert
8d026eeeea
Merge pull request #19827 from smoogipoo/upgrade-analyser
Upgrade LocalisationAnalyser and disable warning
2022-08-18 16:35:34 +09:00
Dean Herbert
bb46f72f9e Fix Pippidon crash on empty beatmap conversion 2022-08-18 16:17:50 +09:00
Dean Herbert
b0a740071e Centralise logging of failed ruleset loads 2022-08-18 16:14:38 +09:00
Dean Herbert
e0edaf996f Test ruleset compatibility during initial startup to avoid runtime errors
As we continue to break the ruleset API, it makes more sense to
proactively check known changes and bail early during ruleset loading to
avoid a user experiencing a crash at a random point during execution.

This is a RFC and needs to be tested against known broken rulesets.
There might be some other calls we want to add in addition to the ones
I've listed.
2022-08-18 16:03:38 +09:00