1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-07 18:07:28 +08:00
Commit Graph

46029 Commits

Author SHA1 Message Date
Bartłomiej Dach
6a1c27d67a
Merge branch 'master' into fix-more-null 2021-11-06 15:36:15 +01:00
Bartłomiej Dach
c40f887492
Remove unnecessary local variable 2021-11-06 15:20:29 +01:00
Salman Ahmed
b85bdd6089
Merge pull request #15488 from peppy/update-cached-buffered-container-usage
Update usages of `BufferedContainer` in line with framework changes
2021-11-06 11:09:42 +03:00
Salman Ahmed
34c8e53e94
Merge branch 'master' into update-cached-buffered-container-usage 2021-11-06 09:38:55 +03:00
Dean Herbert
2b3907db4b Update framework 2021-11-06 14:33:45 +09:00
Salman Ahmed
51e7b9950e Define local current bindable to bind value change instead 2021-11-05 18:07:14 +03:00
Dan Balasescu
858e2a081e
Merge pull request #15489 from peppy/manager-not-importer
Allow downloads via interface types (and remove `IModelManager:IModelImporter`)
2021-11-05 18:30:06 +09:00
Dean Herbert
6c385ccd29 Move second generic to abstract model downloader rather than interface type 2021-11-05 17:37:05 +09:00
Dean Herbert
99df37f32d Add input generic type to IModelDownloader 2021-11-05 17:02:45 +09:00
Dean Herbert
1fe9bca819 Change ModelDownloader's requirement to an IModelImporter rather than IModelManager 2021-11-05 16:47:18 +09:00
Dean Herbert
b90f44493c Remove importer inheritance from IModelManager
Now only exists in legacy implementations, to reduce inheritance
complexity of interfaces which are going to be used going forwards.
2021-11-05 16:45:38 +09:00
Salman Ahmed
f013a1e37f Move CreateContent() to BDL 2021-11-05 10:13:42 +03:00
Dan Balasescu
9e06da6cbb
Merge pull request #15463 from peppy/beatmap-refactor/to-model-removal-2
Remove all remaining calls to `ToBeatmapInfo`/`ToBeatmapSetInfo`
2021-11-05 16:06:17 +09:00
Dean Herbert
6399c695e8 Update usages of BufferedContainer in line with framework changes 2021-11-05 15:54:49 +09:00
Salman Ahmed
3a3ec1436b Re-enable possible null refernece exception inspections and move code 2021-11-05 09:14:50 +03:00
Salman Ahmed
b723975767 Replace pragma with add/remove => throw 2021-11-05 09:10:38 +03:00
Dean Herbert
9f9ef570ee Also propagate Status in temporary BeatmapInfo usage 2021-11-05 14:44:58 +09:00
Dan Balasescu
9e2c33d908
Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 13:16:32 +09:00
Dan Balasescu
9b5ed791b5
Merge pull request #15459 from peppy/beatmap-refactor/remove-online-info
Remove `IOnlineInfo` implementations from database models
2021-11-05 13:16:21 +09:00
Dean Herbert
5721f1b2f3
Merge pull request #15479 from jaswon/skinnable-diagonal-scale
Fix scaling of skin components being too sensitive after rotation
2021-11-05 13:11:11 +09:00
Dan Balasescu
acb06d4a99
Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 12:46:02 +09:00
Salman Ahmed
f528488aa2 Mark as non-null and move current bind to BDL instead 2021-11-05 05:42:19 +03:00
Salman Ahmed
2764ad90ea
Merge branch 'master' into fix-more-null 2021-11-05 05:14:22 +03:00
Salman Ahmed
4245af28e1 Disable other false-positive null inspections with comment 2021-11-05 04:50:58 +03:00
Dean Herbert
fc59e20c14
Merge pull request #15478 from bdach/fix-labelled-drawable-descriptions 2021-11-05 10:13:11 +09:00
Salman Ahmed
36d99a2e34 Move action to private named method to avoid null inspection 2021-11-05 03:51:08 +03:00
Salman Ahmed
6197ef426d Disable another "code heurstically unreachable" with comment 2021-11-05 03:50:17 +03:00
Salman Ahmed
af6ae1cce5 Remove hacky code with explicit pragma disable 2021-11-05 03:49:35 +03:00
Jason Won
9e7d559f55 fix aspect locked scaling of skin components 2021-11-04 17:10:41 -04:00
Bartłomiej Dach
4c8d6a77be
Fix labelled drawable descriptions not showing 2021-11-04 21:44:08 +01:00
Bartłomiej Dach
9246adc349
Add failing test coverage for labelled drawable description visible 2021-11-04 21:43:20 +01:00
Dean Herbert
e5d229f005 Merge branch 'beatmap-refactor/remove-online-info' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:43 +09:00
Dean Herbert
630d63101d Merge branch 'master' into beatmap-refactor/to-model-removal-2 2021-11-05 01:16:42 +09:00
Dean Herbert
7049d0de66 Merge branch 'master' into beatmap-refactor/remove-online-info 2021-11-05 01:16:11 +09:00
Salman Ahmed
78ed77805f
Merge pull request #15468 from smoogipoo/upgrade-nvika
Use official nvika package again
2021-11-04 15:16:03 +03:00
Salman Ahmed
9846596c02
Merge branch 'master' into upgrade-nvika 2021-11-04 14:48:42 +03:00
Dan Balasescu
66509264ff
Merge pull request #15467 from peppy/update-framework
Update framework
2021-11-04 20:19:56 +09:00
Salman Ahmed
4b46833ee9
Merge branch 'master' into upgrade-nvika 2021-11-04 13:53:30 +03:00
Salman Ahmed
aa2711e6ec
Merge branch 'master' into update-framework 2021-11-04 13:51:57 +03:00
Dan Balasescu
f12a2c7767
Merge pull request #15458 from peppy/beatmap-refactor/playlist-use-api-beatmap-extended
Refactor `PlaylistItem` to allow `Beatmap` to be an interfaced type
2021-11-04 19:23:33 +09:00
smoogipoo
30635fb476 Use official nvika package again 2021-11-04 19:19:00 +09:00
Dean Herbert
28e9b9a25f Update framework 2021-11-04 19:01:39 +09:00
Dan Balasescu
45dcf187b9
Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended 2021-11-04 18:59:04 +09:00
Dean Herbert
df3c3a32ce Fix unintentionally broken background update logic 2021-11-04 18:07:39 +09:00
Dan Balasescu
388c074c15
Merge pull request #15464 from peppy/fix-crash-on-gameplay
Fix crash on gameplay startup if beatmap has no background
2021-11-04 18:07:10 +09:00
Dean Herbert
b80c02b757 Fix crash on gameplay startup if beatmap has no background 2021-11-04 17:24:40 +09:00
Dean Herbert
eb17d897a3 Finally, remove the To* methods as they have no usages 2021-11-04 17:09:53 +09:00
Dean Herbert
08d94f864f Update ScoresContainer to not use ToBeatmapInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
7bab487621 Remove usage of ToBeatmapInfo in APIScoreInfo.CreateScoreInfo 2021-11-04 17:09:53 +09:00
Dean Herbert
8a873bd6b1 Merge branch 'beatmap-refactor/playlist-use-api-beatmap-extended' into beatmap-refactor/to-model-removal-2 2021-11-04 17:09:51 +09:00