1423 Commits

• Add type parameter to pool retrieval method
  Dan Balasescu · 2026-01-28 13:42:58 +09:00
  c1fc1edd9c
• Add metadata endpoint to refresh friend listing (#36386)

  Alternative to / closes https://github.com/ppy/osu/pull/36341
  See also: https://github.com/ppy/osu-server-spectator/pull/415
  
  This is a simple solution by adding a spectator endpoint to refresh the
  friend listing. A more complicated form of this is to make
  adding/removing friends only via spectator, but that would require
  osu-web changes too.

  Dan Balasescu · 2026-01-19 18:34:00 +09:00
  e62a01cf77
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-12-17 13:33:34 +09:00
  67e0348fa8
• Adjust vote-to-skip to be explicit about states
  Dan Balasescu · 2025-12-06 13:23:16 +09:00
  2be50d917a
• Fix failing tests after disallowing object placements before first timing point
  Bartłomiej Dach · 2025-12-05 09:52:32 +01:00
  66ebce8c12
• Merge branch 'master' into new-playlists-song-select
  Dan Balasescu · 2025-11-18 14:08:12 +09:00
  a30f08be80
• Fix several issues with incorrect sample playback (#35685)

  * Add failing test coverage for layered hit samples not playing in mania when beatmap is converted
  
  Adding the `osu.Game.Rulesets.Osu` reference to the mania test project
  is required so that `HitObjectSampleTest` base logic doesn't die on
  
  https://github.com/ppy/osu/blob/f0aeeeea966f06add12cf2bca3dd48dac8573e82/osu.Game/Tests/Beatmaps/HitObjectSampleTest.cs#L88-L91
  
  * Fix layered hit sounds not playing on converted beatmaps in mania
  
  Compare
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/HitObject.cs#L476-L477.
  
  In case of converted beatmaps, the last condition there
  (`BeatmapManager.Current.PlayMode != PlayModes.OsuMania`) fails,
  and thus layered hitsounds are allowed to play.
  
  * Add failing test coverage for mania beatmap conversion assigning wrong samples to spinners
  
  * Fix mania beatmap conversion assigning wrong samples to spinners
  
  A spinner is never `IHasRepeats`. It was a dead condition, leading to
  the hitobject generating fallback `NodeSamples`, which in particular
  feature a silent tail which stable doesn't do.
  
  Noticeably, stable also appears to force the head of the generated hold
  note to have no addition sounds:
  
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/Mania/SpinnerMania.cs#L86-L89
  
  * Add failing test coverage for file hit sample not falling back to plain samples if file missing
  
  * Allow `FileHitSampleInfo` to fall back to standard samples if the file is not found (or not allowed to be looked up)
  
  I'm honestly not 100% as to how closely this matches stable because I
  reached the point wherein I'd rather not look at stable code anymore, so
  as long as this passes tests I'm fine to wait for someone else to report
  new breakage.
  
  * Use alternative workaround for lack of osu! ruleset assembly in mania test project
  
  * Fix encode stability test failures

  Bartłomiej Dach · 2025-11-15 16:19:08 +09:00
  bd4ed49c06
• Suffix introp methods with "Intro"
  Dan Balasescu · 2025-11-04 11:05:41 +09:00
  f4049c7ec1
• Resolve CI inspections
  Dan Balasescu · 2025-10-31 21:48:24 +09:00
  a9ca4634fc
• Add simple multiplayer skip overlay
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  b20a41c1e8
• Add support for vote-to-skip in multiplayer
  Dan Balasescu · 2025-10-31 21:39:41 +09:00
  373162df02
• Add interop models
  Dan Balasescu · 2025-10-30 19:04:49 +09:00
  a435dfe93e
• Add very simple countdown timer for quick play stages (#35433)
  Dean Herbert · 2025-10-24 23:07:04 +09:00
  1af462b692
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-17 19:01:28 +09:00
  4be29425a0
• Add initial screen + test structure
  Dan Balasescu · 2025-10-17 09:16:46 +09:00
  bfa45a23ce
• Use new implementation in ScreenTestScene
  Dan Balasescu · 2025-10-16 20:37:24 +09:00
  c80fe7ab82
• Merge pull request #35251 from smoogipoo/fix-broken-tests

  Fix test failures during individual runs

  Dean Herbert · 2025-10-09 17:09:01 +09:00
  2136d95087
• Fix test failures during individual runs
  Dan Balasescu · 2025-10-09 16:34:55 +09:00
  6eaf91d31a
• Fix test scene leaks through RealmRulesetStore/RealmAccess
  Dan Balasescu · 2025-10-09 15:28:15 +09:00
  79c367d208
• Add ability to jump in quick play
  Dan Balasescu · 2025-09-30 18:38:30 +09:00
  e636a09e0f
• Fix incorrect default room types
  Dan Balasescu · 2025-09-24 14:28:04 +09:00
  83dafb4ef9
• Add stage-changing helper, use in test scenes
  Dan Balasescu · 2025-09-24 14:28:01 +09:00
  9df3bd9a98
• Set initial matchmaking room state
  Dan Balasescu · 2025-09-24 13:42:55 +09:00
  597a06ac38
• Attempt to fix intermittent test
  Dan Balasescu · 2025-09-23 15:09:45 +09:00
  3789010dd5
• Merge branch 'master' into matchmaking
  Dean Herbert · 2025-09-11 15:11:01 +09:00
  619a6e7321
• Query for available pools for selection (#131)
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  e0c11504a2
• Separate IMatchmakingClient and IMultiplayerClient

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  3786efaa5e
• Add matchmaking
  Dan Balasescu · 2025-09-07 16:17:27 +09:00
  111b98ef8e
• Replace old-skin with retro skin in tests
  clayton · 2025-09-05 21:21:52 +09:00
  3c1c537b1b
• Add matchmaking model types required for server-side deploy
  Dan Balasescu · 2025-09-04 18:26:56 +09:00
  815bf9c37b
• Merge branch 'master' into pinned-rooms
  Dean Herbert · 2025-09-01 16:01:50 +09:00
  4e976cff6a
• Move footer to ScreenTestScene
  Dan Balasescu · 2025-08-29 17:49:48 +09:00
  04ba5aa575
• Update tests
  Bartłomiej Dach · 2025-08-22 12:44:08 +02:00
  03e7e2b0d8
• Ignore more potentially incorrect data from BASS

  This is still a workaround but arguably it's something we could leave in
  place without much loss. I think this at least feels better than the
  previous code.
  
  Notably, you could argue the test coverage of the fail case is lower
  since made it implicit that all tests will avoid the "backwards seek"
  detections.  But we never really had tests correctly- fail on the original
  so I don't see any loss of value.

  Dean Herbert · 2025-08-14 19:20:30 +09:00
  82906300b4
• Remove bindable added only for tests
  Dean Herbert · 2025-08-11 21:07:55 +09:00
  e93d15ef0e
• Fix leak due to missing Game disposal
  Dan Balasescu · 2025-07-09 03:37:02 +09:00
  74516a1eaa
• Update existing tests to work with Song Select v2
  Dean Herbert · 2025-07-01 17:25:38 +09:00
  397b9b3994
• Fix flaky tests due to async disposal
  Dan Balasescu · 2025-06-27 19:43:26 +09:00
  c53a7aa2fc
• Attempt to fix flaky tests by removing finaliser
  Dan Balasescu · 2025-06-03 18:02:37 +09:00
  b152b786a5
• Add failing test case
  Bartłomiej Dach · 2025-05-16 12:45:47 +02:00
  8854db0264
• Add test cases covering correct legacy replay playback with respect to hitwindow treatment

  This continues on https://github.com/ppy/osu/pull/32770 via adding test
  cases which cover treatment of hit windows in stable in osu!, taiko, and
  mania. The test cases are exportable to beatmap `.osu` files and replay
  `.osr` files for stable crosscheck by setting `ExportLocation` on the
  test scene classes to a non-null path.
  
  For the most part, osu! and taiko ground truth matches previous findings
  - hit windows in those rulesets are floored to the nearest integer.
  The real "star" of this diff is mania, because:
  
  - The hit windows in mania depend on:
    - overall difficulty (as expected)
    - whether Score V2 is active
    - if Score V2 is not active, the hit windows also depend on whether
      the map was converted from another ruleset or not
  
  - Regardless of all aforementioned factors, mania hitwindows are *not
    symmetrical*. Due to what *appears* to be a straight-up bug, it is
    *not possible to achieve a MEH / 50 hit result when hitting late*.
    There is specific code that coerces late hits beyond 100 hit window
    range to full misses:
  
       https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L737-L751
  
  Note that despite the fact that I'm PRing these test cases, none of this
  is a promise that all of stable behaviours will be returning unchanged
  when I PR something to actually do something about this and the other
  issue of replay instability. This is just coverage, to be used for
  awareness of what's still broken. The extent of how much stable is going
  to be humored here going forward will be subject to negotiation.

  Bartłomiej Dach · 2025-04-15 13:22:06 +02:00
  82b2a92894
• Abstractify test scene

  I think in this case it's genuinely reasonable to use abstracts to
  reduce boilerplate.

  Bartłomiej Dach · 2025-04-11 12:09:53 +02:00
  30bb8e335c
• Clone countdown objects in test client

  Beyond isolation, this stuff is also used to test (de-)serialisation.
  Much-of-a-muchness in this case since it isn't too thoroughly tested,
  but best do it anyway.

  Dan Balasescu · 2025-04-08 18:42:25 +09:00
  874ec49590
• Add failing countdown start test
  Dan Balasescu · 2025-04-08 18:35:22 +09:00
  968fe6e618
• Replace RoomID change with test-local fixes
  Dan Balasescu · 2025-03-31 16:32:32 +09:00
  74d234a7de
• Fix tests
  Bartłomiej Dach · 2025-03-27 12:39:19 +01:00
  2ba621550c
• Add tests for multiplayer implementation
  Dan Balasescu · 2025-03-25 16:03:56 +09:00
  a1894c9193
• Split tracker into per-system implementations
  Dan Balasescu · 2025-03-25 14:56:12 +09:00
  53ece9396a
• Refactor tracker to be a bit more stateless

  Removes storage of `selectedBeatmap` that was referenced through
  multiple class-level methods.
  
  To expound a bit, this structure felt better (or otherwise passing
  `APIBeatmap` through methods) alongside removal of the `#nullable
  disable`, otherwise each method would check `selectedBeatmap != null`.

  Dan Balasescu · 2025-03-25 14:23:05 +09:00
  72b56146ee
• Replace superfluous method with concrete implementation
  Dan Balasescu · 2025-03-19 15:32:29 +09:00
  23fa3060b2