38 Commits

• Fix carousel items becoming incorrectly selected due to bindable leakage (#36414)

  As discussed in discord. Fixed from multiple angles.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-01-22 01:06:40 +09:00
  10dc1314f6
• Add support for showing which beatmaps in a set are currently filtered out
  Bartłomiej Dach · 2025-12-30 12:39:32 +01:00
  e07b828f30
• Add minimal spread display control for beatmap set panels
  Bartłomiej Dach · 2025-12-30 12:39:18 +01:00
  e2a245b049
• Rename localised string
  Dean Herbert · 2025-11-21 17:13:44 +09:00
  98e7a10e1e
• Merge branch 'master' into rename-delete-button
  Dean Herbert · 2025-11-21 17:11:24 +09:00
  e99b9984d0
• Move realm collection writes off of update thread (#35681)

  Probably closes https://github.com/ppy/osu/issues/35650.
  
  Realm slow, episode 23894. I can't reproduce freezes as big as the video
  in the issue is showing but 'realm slow' is 99% the culprit, because
  affected user's database is not small.

  Bartłomiej Dach · 2025-11-11 20:29:39 +09:00
  cb9d9734d6
• Use proper string key
  Loreos7 · 2025-11-09 17:48:19 +03:00
  1df640898f
• Move Delete... button to CommonStrings
  Loreos7 · 2025-11-05 15:56:07 +03:00
  6a6c7ad3ba
• Slightly delay retrieval of working beatmaps in song select panels

  Beatmap panels can be visible for very brief instants.
  `PanelSetBackground` has a backstop to prevent expensive background
  loads which is based on the position of the panel relative to centre of
  screen.
  
  However, retrieving the working beatmap that *precedes* any of that
  expensive background load logic, is *also* expensive, and *always* runs
  even if a panel is visible on screen for only a brief second. Therefore,
  by moving some of that background load delay towards delaying retrieving
  the working beatmap, we can save on doing even more work, which has
  beneficial implications for performance.

  Bartłomiej Dach · 2025-10-22 11:00:20 +02:00
  4ebd97b804
• Restore original delete button name
  Loreos7 · 2025-10-18 19:17:08 +03:00
  1ec6735a35
• Use consistent ordering of update button on carousel beatmap panels

  Closes https://github.com/ppy/osu/issues/34810.
  
  The reason why I touched it in this direction and not the other is only
  because the standalone panel positioning of the button was touched last
  in 92ed964627, thus I changed the set
  panel to match that.

  Bartłomiej Dach · 2025-10-01 13:49:54 +02:00
  ccf3151172
• Apply suggested rename
  Bartłomiej Dach · 2025-08-29 09:58:56 +02:00
  526ee32268
• Support beatmap sets being split apart by the active group mode in beatmap carousel
  Bartłomiej Dach · 2025-08-28 13:09:08 +02:00
  8dd131f17e
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-28 19:12:34 +03:00
  6936533522
• Add back "edit" context menu item on set panel headers

  Not sure how I feel about this. If it seems incorrect let's just not.
  
  As proposed in https://github.com/ppy/osu/discussions/34119.

  Dean Herbert · 2025-07-25 17:51:13 +09:00
  91f01ea015
• Merge branch 'master' into ssv2-localisation
  Denis Titovets · 2025-07-25 11:36:52 +03:00
  4b73afd195
• Refactor song select panel background layout and rendering
  Salman Alshamrani · 2025-07-21 05:18:15 +03:00
  078b924611
• Remove duplicate `LocalisableString's
  Denis Titovets · 2025-07-09 16:31:51 +03:00
  7c9c2061ad
• Fully localise SSV2
  Denis Titovets · 2025-07-09 15:07:07 +03:00
  1f052bb195
• Increase margin in PanelBeatmap to improve legibility
  jyc76 · 2025-06-23 17:24:26 +09:00
  cef6445e2b
• Add localisation to Collections string on SongSelect
  diquoks · 2025-06-21 14:05:20 +03:00
  3192eaa2a2
• Store input padding adjustments in CarouselItem to allow more reliable inflation
  Dean Herbert · 2025-06-02 19:11:47 +09:00
  90b9fb0809
• SongSelectV2: Fix input gap between last beatmap panel in set and next set panel
  Bartłomiej Dach · 2025-05-30 19:13:42 +02:00
  f462c683ee
• SongSelectV2: Add back ability to manage collections from beatmap / set panel context menus
  Dean Herbert · 2025-05-30 15:04:42 +09:00
  2bbd1ee384
• Decrease height of set headers and standalone beatmap panels

  They felt too chunky.

  Dean Herbert · 2025-05-29 18:28:35 +09:00
  129dc2e173
• Use more consistent ordering between beatmap & beatmapset panels
  Bartłomiej Dach · 2025-05-26 07:54:25 +02:00
  2d9cc382c8
• Add back two missing actions for beatmap set headers
  Dean Herbert · 2025-05-24 11:28:12 +09:00
  a1426eb8be
• Add context menus to new carousel panels

  This changes the flow of actions (yet again.. sorry) to standardise what
  is shown on the beatmap options button in the footer and the context
  menus.
  
  This is something I wanted from the start – for devices where right
  click is not available, it's always preferable to have a second method
  of accessing actions which isn't the context menu.
  
  Collection actions are missing for now, as they will come in a second
  pass which includes tidying things up further.
  
  Fix formatting
  
  Duplicate menu items between implementations

  Dean Herbert · 2025-05-23 16:02:13 +09:00
  891f0c469f
• Add property to allow disabling status pill animation
  Salman Alshamrani · 2025-05-21 00:37:08 +09:00
  c565b76b6e
• Update song select panel metrics in line with standard specifications and apply minor adjustments
  Salman Alshamrani · 2025-04-17 08:21:32 -04:00
  9e2a05a1fb
• Rename song select v2 classes and namespaces

  This aims to bring some conformity to naming to make it easier to
  understand component structure for new components.
  
  Renames are pulled out of the song select v2 changes and are more
  relevant there due to many new classes being added.
  
  - `V2` suffix is dropped, with v2 components being moved to a relevant V2 namespace.
  - Related classes have a prefix of the area they are used.
  - Experimenting with using partial/nested classes in the song select v2 implementation.
    Not committing to this yet but want to see how it plays out.
  - Moved base carousel components to a generic namespace to avoid confusion with actual beatmap carousel implementation.

  Dean Herbert · 2025-04-16 18:34:53 +09:00
  0aff50fbf5
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Remove unnecessary customisation settings in DifficultySpectrumDisplay
  Dean Herbert · 2025-03-19 19:31:57 +09:00
  cfb14fbca6
• Adjust set panel display and animations slightly
  Dean Herbert · 2025-02-28 22:54:00 +09:00
  38de3566b1
• Tidy up remaining common code
  Dean Herbert · 2025-02-18 16:52:19 +09:00
  7e1984452f
• Move PanelXOffset to init property rather than ctor

  Feels better to me.

  Dean Herbert · 2025-02-18 16:52:18 +09:00
  5de9584171
• User inheritance to avoid Piece structural nightmare
  Dean Herbert · 2025-02-18 16:52:18 +09:00
  88ec204d26
• Rename classes for better discoverability / grouping
  Dean Herbert · 2025-02-12 19:34:42 +09:00
  554884710c