2762 Commits

• Adjust contract of Ruleset.GetValidHitResults() to always enumerate all results used
  Bartłomiej Dach · 2026-02-09 12:48:53 +01:00
  15c49a729e
• Publicise Ruleset.GetValidHitResults()
  Bartłomiej Dach · 2026-02-09 12:00:30 +01:00
  3678ea0d0f
• Apply new inspections from 2026.1EAP1

  Nothing really egregious here so not bothering with PR review. One dodgy
  bug which has been
  [reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
  and temporarily ignored.

  Dean Herbert · 2026-01-26 15:12:52 +09:00
  f1f4a0001b
• Update game settings to use new form controls
  Salman Alshamrani · 2026-01-14 02:15:10 -05:00
  e548cd40dc
• Set Ranked to true for ManiaModCover
  James Wilson · 2025-12-16 09:28:30 +00:00
  83f9eba1d1
• Fix skin editor sometimes dropping anchor/origin specification on paste (#35957)

  * Add failing test for copy->paste not being idempotent
  
  * Ensure all elements on default skins use fixed anchors
  
  `UsesFixedAnchor` defaults to false, i.e. closest anchors. Combined with
  manual anchor / origin specs on some drawables, this would get default
  skins into impossible states wherein a drawable would use "closest
  anchor" but also explicitly specify anchor / origin that aren't closest,
  which horribly fails on attempting to copy and paste.
  
  Frankly shocked this has gone unnoticed for this long, and I regret not
  vetoing this "feature" more every time I see its tentacles spread to
  produce breakage of levels yet unseen.
  
  Does this commit contain major levels of suck? For sure. Do I have any
  better ideas that wouldn't consist of a multi-day rewrite or deletion of
  this "feature"? No.
  
  * Fix skin editor always applying closest anchor / origin on paste regardless of whether the component uses fixed anchor
  
  Self-explanatory. Should close https://github.com/ppy/osu/issues/29111
  along with previous commit.

  Bartłomiej Dach · 2025-12-11 13:40:48 +09:00
  c4f7dee82b
• Add basic colour indication as to when placements are valid

  Unsure about this one, but I find the preceding commit to be very
  lacking in explaining to the user why the editor don't work. Shining
  some things red may help aid understanding.

  Bartłomiej Dach · 2025-12-04 14:37:56 +01:00
  c6cc92315c
• Disallow placing hit objects before first timing point

  Because they can break stable. See
  https://github.com/ppy/osu/issues/31591#issuecomment-3575270120 for
  detailed rationale.

  Bartłomiej Dach · 2025-12-04 14:15:52 +01:00
  12170df80a
• Fix several issues with editor timestamps for objects with fractional start times in osu!mania (#35829)

  * Fix mania editor timestamp generation being culture-dependent
  
  Mostly closes https://github.com/ppy/osu/issues/35809.
  
  * Add failing test for notes with fractions
  
  * Round note time when copying out timestamp & apply half-millisecond tolerance when parsing
  
  Closes the rest of https://github.com/ppy/osu/issues/35809.
  
  One issue here was that while the timestamp generation would allow
  fractional object timestamps to be output, the parsing (via
  `selection_regex`) would *reject* fractional timestamps, therefore
  making lazer incompatible even with itself.
  
  The other is that rounding is probably fine to do anyway for
  interoperability with stable. I'd hope nobody actually *needs*
  sub-millisecond precision but I'm ready to be proven wrong by some
  aspire jokester.
  
  * Specify invariant culture when writing out combo indices to editor timestamp in other rulesets
  
  Pretty sure this is just a much-of-muchness because it's integers but
  might as well if I'm spending time here already.

  Bartłomiej Dach · 2025-11-28 08:21:13 +09:00
  a8f058141b
• Fix several issues with incorrect sample playback (#35685)

  * Add failing test coverage for layered hit samples not playing in mania when beatmap is converted
  
  Adding the `osu.Game.Rulesets.Osu` reference to the mania test project
  is required so that `HitObjectSampleTest` base logic doesn't die on
  
  https://github.com/ppy/osu/blob/f0aeeeea966f06add12cf2bca3dd48dac8573e82/osu.Game/Tests/Beatmaps/HitObjectSampleTest.cs#L88-L91
  
  * Fix layered hit sounds not playing on converted beatmaps in mania
  
  Compare
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/HitObject.cs#L476-L477.
  
  In case of converted beatmaps, the last condition there
  (`BeatmapManager.Current.PlayMode != PlayModes.OsuMania`) fails,
  and thus layered hitsounds are allowed to play.
  
  * Add failing test coverage for mania beatmap conversion assigning wrong samples to spinners
  
  * Fix mania beatmap conversion assigning wrong samples to spinners
  
  A spinner is never `IHasRepeats`. It was a dead condition, leading to
  the hitobject generating fallback `NodeSamples`, which in particular
  feature a silent tail which stable doesn't do.
  
  Noticeably, stable also appears to force the head of the generated hold
  note to have no addition sounds:
  
  https://github.com/peppy/osu-stable-reference/blob/f9e58b4864a10f801393199e7652b2192c7342c3/osu!/GameplayElements/HitObjects/Mania/SpinnerMania.cs#L86-L89
  
  * Add failing test coverage for file hit sample not falling back to plain samples if file missing
  
  * Allow `FileHitSampleInfo` to fall back to standard samples if the file is not found (or not allowed to be looked up)
  
  I'm honestly not 100% as to how closely this matches stable because I
  reached the point wherein I'd rather not look at stable code anymore, so
  as long as this passes tests I'm fine to wait for someone else to report
  new breakage.
  
  * Use alternative workaround for lack of osu! ruleset assembly in mania test project
  
  * Fix encode stability test failures

  Bartłomiej Dach · 2025-11-15 16:19:08 +09:00
  bd4ed49c06
• Merge pull request #35249 from dnfd1/mania-difficultychange-limits

  Adjust extended OD limits for mania difficulty change mod to reflect HR and EZ values

  Dean Herbert · 2025-10-28 15:05:26 +09:00
  98829bf857
• Fix Hold Off mod changing scroll speed in rare scenarios (#35265)

  Reported (in a rather confusing manner) in
  https://discord.com/channels/188630481301012481/1097318920991559880/1426084740783538268.
  
  The relevant bit here is the following logic:
  
  	https://github.com/ppy/osu/blob/32c60bfb36ae428e6fe56b077d9397c6bc57dd30/osu.Game/Rulesets/UI/Scrolling/DrawableScrollingRuleset.cs#L111-L118
  
  which mania enables.

  Bartłomiej Dach · 2025-10-16 21:09:52 +09:00
  a2bae15db1
• add inline comment to explain larger limits
  dnfd1 · 2025-10-09 05:21:08 -07:00
  0d68e5eeeb
• Round OD limits to -15 and 15
  dnfd1 · 2025-10-09 05:13:17 -07:00
  faad1753a4
• Override OD setting to set extended limits for mania EZ and HR
  dnfd1 · 2025-10-08 21:26:45 -07:00
  cab0b3451f
• Merge branch 'master' into pp-dev
  Dean Herbert · 2025-10-07 16:11:54 +09:00
  bda5737135
• Fix osu!mania legacy skin WidthForNoteHeightScale not being used (#35050)

  * Add osu!mania legacy skin widthForNoteHeightScale
  
  * Ensure WidthForNoteHeightScale correctly defaults to MinimumColumnWidth

  qinvvv · 2025-09-19 10:53:25 +09:00
  b91ff8a5c5
• Merge branch 'master' into pp-dev
  Dan Balasescu · 2025-09-07 19:22:08 +09:00
  ffab8342f2
• Add "retro" default skin
  clayton · 2025-09-05 21:21:52 +09:00
  6af48975b0
• Do not pass a whole bunch of InputKey.None down three levels for no reason
  Bartłomiej Dach · 2025-09-03 07:51:52 +02:00
  dc5794dceb
• Change deafult keys to none
  Krystian Ptach-Żurakowski · 2025-09-02 17:53:31 +02:00
  4a193e96e0
• Better secondary keybinds for 10K
  Krystian Ptach-Żurakowski · 2025-08-31 21:19:26 +02:00
  c7f1210281
• Code quality
  Krystian Ptach-Żurakowski · 2025-08-30 20:36:29 +02:00
  08ad27459e
• Add Secondary Keys for Mania
  Krystian Ptach-Żurakowski · 2025-08-30 20:35:51 +02:00
  2fb481e2ee
• refactor(ManiaFilterCriteria): exclude converted beatmaps from long note filter
  Binwalker · 2025-08-26 21:36:20 +09:00
  6a82b7331f
• fix(ManiaFilterCriteria): converted beatmaps are not included
  Binwalker · 2025-08-26 21:36:20 +09:00
  556c2469bf
• feat(ManiaFilterCriteria): add long note ratio filter for mania
  Binwalker · 2025-08-26 21:36:19 +09:00
  68677200f3
• Add and use new mod icon assets
  Bartłomiej Dach · 2025-08-21 09:00:44 +02:00
  92016a7d9b
• Merge pull request #34584 from Hiviexd/verify/refactor-verifier-context

  Refactor `BeatmapVerifierContext`

  Dean Herbert · 2025-08-14 02:28:57 +09:00
  75c72b150e
• initial pass on updated verifier context usage across most checks
  Hivie · 2025-08-11 14:57:14 +01:00
  fd6cf680b9
• Merge branch 'master' into osu!mania-touch-on-desktop
  Salman Alshamrani · 2025-08-11 11:15:16 +03:00
  2d1ca7dacc
• Allow enabling osu!mania touch overlay on non-mobile platforms
  AeroKoder · 2025-08-11 11:09:58 +03:00
  ef972e4a04
• Merge pull request #34500 from frenzibyte/mania-long-notes-sound-broken

  Prevent playing sliding sounds in hold notes when beatmap is not converted

  Bartłomiej Dach · 2025-08-05 11:41:22 +02:00
  619fe60dd1
• Fix grammar in comment
  Bartłomiej Dach · 2025-08-05 10:48:17 +02:00
  50daae399b
• Fix special cases of mania beatmaps not playing sliding samples

  Apparently mania sliders are a thing. See https://github.com/ppy/osu/pull/34500#issuecomment-3150610188

  Salman Alshamrani · 2025-08-05 10:25:39 +03:00
  03dae97ff3
• Clarify "invert" mod cannot possibly play sliding samples
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  6d43ae8ac1
• Fix "no release" mod not playing sliding samples in converted beatmaps
  Salman Alshamrani · 2025-08-04 12:27:57 +03:00
  d216256fdf
• Only play hold note sliding samples when beatmap is converted
  Salman Alshamrani · 2025-08-04 12:27:55 +03:00
  4171c3a241
• Adjust some formatting to read better
  Dean Herbert · 2025-08-04 18:20:56 +09:00
  af290ddc0c
• Simplify redundant code
  Bartłomiej Dach · 2025-08-01 12:12:20 +02:00
  b22ca878ba
• Fix mania classic mod impact on hit window not being displayed
  Bartłomiej Dach · 2025-08-01 12:00:41 +02:00
  81cf577670
• Adjust displayed precision to match stable
  Bartłomiej Dach · 2025-08-01 12:00:25 +02:00
  21ef184ae3
• Show effect of beatmap attributes on gameplay metrics in mania
  Bartłomiej Dach · 2025-08-01 11:27:36 +02:00
  e899f0df42
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• remove unused var
  Hivie · 2025-07-28 12:38:16 +01:00
  d5b0c5404c
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8