72935 Commits

This Branch

This Branch

All Branches

• Adjust variables for legibility

  I found the previous way things were written a bit awkward. Easier to
  just enforce non-null here.

  Dean Herbert · 2025-04-26 05:18:24 +09:00
  0301463810
• Fix TriangleSkin not always returning a container for GlobalSkinnableContainerLookup

  We have other safeties which mean that this is not an issue during
  gameplay, but in the new `TestSceneHUDOverlayRulesetLayouts` it became
  apparent that allowing this to fallback (via `null` return) could lead
  to weirdness.

  Dean Herbert · 2025-04-26 05:14:36 +09:00
  54e0e1420f
• Fix filename not matching test scene
  Dean Herbert · 2025-04-26 04:51:03 +09:00
  0287ca285c
• Remove (currently) unused resolved dependency
  Bartłomiej Dach · 2025-04-24 13:23:00 +02:00
  9818f859cb
• Add test scene coverage of HUD layouts on various ruleset/skin combinations

  As time goes on, default skin layouts are getting more and more
  complicated because of per-ruleset overrides. This was already sort of
  apparent in https://github.com/ppy/osu/pull/31527, and I'm about to make
  it worse, so before I do, this is a test scene that is supposed to make
  it easier to check all possible combinations at a glance.

  Bartłomiej Dach · 2025-04-24 12:50:34 +02:00
  33f45b0a6d
• Merge pull request #32937 from bdach/ternary-selection-fixes

  Fix multiple issues with editor ternary toggle state management

  Dean Herbert · 2025-04-24 19:23:00 +09:00
  a0044116f3
• Merge pull request #32936 from bdach/fix-present-score-dying

  Fix presenting score potentially dying due to deleted beatmap

  Dean Herbert · 2025-04-24 19:17:43 +09:00
  fbb7460322
• Fix deselecting single item from a multiple selection not updating ternary states correctly

  I'm not sure why this condition was written this obtusely, but
  importantly it was also wrong. It fires when the selection contains
  multiple items and only some are removed from it, like when
  ctrl-click-unselecting an item from a multiple selection.

  Bartłomiej Dach · 2025-04-24 09:25:36 +02:00
  5a3ff11710
• Reset sample ternary states on deselection

  Closes https://github.com/ppy/osu/issues/32928.
  
  Appears to match stable:
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4137-L4143
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L1615-L1618
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameModes/Edit/Modes/EditorModeCompose.cs#L4323

  Bartłomiej Dach · 2025-04-24 09:25:27 +02:00
  5c04f427a5
• Fix code quality
  Bartłomiej Dach · 2025-04-24 08:54:10 +02:00
  72dd3513fc
• Fix presenting score potentially dying due to deleted beatmap

  - Closes https://github.com/ppy/osu/issues/27168
  - Closes https://github.com/ppy/osu/issues/32930
  
  It's a little manual (if you perform any of the scenarios in the issues
  above on this branch, the first click will re-import the beatmap but not
  start the replay, and only the second will play it), but maybe fine?

  Bartłomiej Dach · 2025-04-24 08:47:08 +02:00
  c52dce0f38
• Merge pull request #32922 from peppy/fix-tablet-adjust-precision

  Fix tablet settings adjusting with too much precision

  Dean Herbert · 2025-04-24 15:23:56 +09:00
  4a95973b6e
• Merge pull request #32915 from peppy/carousel-update-handling

  Add basic support for beatmap updates in `BeatmapCarousel`

  Bartłomiej Dach · 2025-04-23 13:10:25 +02:00
  7cf8207e6e
• Merge pull request #32924 from smoogipoo/fix-mp-results-background

  Show true beatmap background when viewing historical multiplayer results

  Bartłomiej Dach · 2025-04-23 12:42:00 +02:00
  212e7a1170
• Fix beatmap wedge test failures

  Started failing after 5ad28a792b, I'm
  guessing.

  Bartłomiej Dach · 2025-04-23 12:20:17 +02:00
  618ab4fec6
• Move implementation to base class
  Dan Balasescu · 2025-04-23 18:27:59 +09:00
  655861752d
• Merge pull request #32909 from bdach/fix-daily-challenge-marker

  Fix daily challenge marker text spacing

  Dean Herbert · 2025-04-23 18:24:56 +09:00
  0adda23988
• Ensure online ID has a valid online value before preferring it
  Dean Herbert · 2025-04-23 18:21:17 +09:00
  1488a49dae
• Remove online ID equality TODO and add explanation as to why it's not required
  Dean Herbert · 2025-04-23 18:13:13 +09:00
  73773aa69a
• Maintain selection using OnlineID as a priority
  Dean Herbert · 2025-04-23 18:01:49 +09:00
  414150e9e0
• Merge pull request #32842 from frenzibyte/song-select-v2-wedges-title

  Add song select beatmap title wedge

  Dean Herbert · 2025-04-23 17:39:03 +09:00
  ddb4c0e24f
• Merge pull request #32843 from frenzibyte/song-select-v2-wedges-metadata

  Add song select beatmap metadata wedge

  Dean Herbert · 2025-04-23 17:36:12 +09:00
  f945298bde
• Fix "mapped by" line showing stupid display when switching to default beatmap
  Dean Herbert · 2025-04-23 17:34:59 +09:00
  5ad28a792b
• Simplify and fix naming of statistic class
  Dean Herbert · 2025-04-23 17:32:18 +09:00
  4290f2d4fd
• Fix animations and alignment of tiny statistics
  Dean Herbert · 2025-04-23 17:20:52 +09:00
  9372ba02d1
• Remove silly bindable flow that only exists for testing purposes
  Dean Herbert · 2025-04-23 17:08:48 +09:00
  c11220df9b
• Improve star rating colour animations to match
  Dean Herbert · 2025-04-23 17:04:53 +09:00
  f6d7e29396
• Define constant for difficulty colour cutoff
  Dean Herbert · 2025-04-23 16:57:41 +09:00
  3f719125e6
• Merge pull request #32923 from smoogipoo/keep-settings-on-room-update

  Keep multiplayer settings open during room updates

  Bartłomiej Dach · 2025-04-23 09:47:56 +02:00
  059f6ef35c
• Show true beatmap background when viewing historical multiplayer results
  Dan Balasescu · 2025-04-23 16:28:44 +09:00
  65cf1a4b7c
• Merge pull request #32913 from peppy/leaderboard-fetch-refactor

  Remove `LeaderboardManager` return value and simplify flow further

  Bartłomiej Dach · 2025-04-23 09:27:12 +02:00
  7636573e21
• Adjust tests and transitions
  Dean Herbert · 2025-04-23 16:23:37 +09:00
  883df07ff6
• Keep multiplayer settings open during room updates
  Dan Balasescu · 2025-04-23 16:05:35 +09:00
  5ea408f3a1
• Add failing test
  Dan Balasescu · 2025-04-23 16:04:38 +09:00
  eafb52ffb4
• Fix increased spacing on fps counter tooltip
  Bartłomiej Dach · 2025-04-23 08:55:41 +02:00
  3f98dd93ed
• Fix fps counter test scene being half broken
  Bartłomiej Dach · 2025-04-23 08:55:29 +02:00
  b9fe5079fc
• Fix tablet settings adjusting with too much precision

  Closes https://github.com/ppy/osu/issues/32920.
  
  I don't know if there's going to be other cases of breakage, but from
  what I can tell these settings *not* showing infinite precision
  representations was a bug with the previous implementation of number
  formatting.

  Dean Herbert · 2025-04-23 15:40:41 +09:00
  8d4d9b7bef
• Merge pull request #32912 from bdach/free-mod-button-still-clickable-when-disabled

  Fix free mod selection sub-button being clickable even if the main button isn't

  Dan Balasescu · 2025-04-23 15:37:55 +09:00
  0b694fdef2
• Always refresh leaderboard for now
  Dean Herbert · 2025-04-23 14:51:00 +09:00
  f945abb72e
• Merge pull request #32612 from zihadmahiuddin/feat/block-users

  Implement blocking users

  Dean Herbert · 2025-04-23 14:46:01 +09:00
  8cb1ab4a77
• Remove loading layer
  Dean Herbert · 2025-04-23 13:57:36 +09:00
  83d2189b4f
• Merge branch 'master' into feat/block-users
  Dean Herbert · 2025-04-23 13:55:18 +09:00
  c5748a0eae
• Merge pull request #32918 from Shavixinio/master

  Minor fix to the Easy mod description

  Dean Herbert · 2025-04-23 13:54:35 +09:00
  c75080a991
• Minor fix to the description text
  Shavixinio · 2025-04-22 19:49:34 +02:00
  3b2382ceb0
• Ensure selection is retained over beatmap update
  Dean Herbert · 2025-04-22 21:01:56 +09:00
  615c7b29b5
• Simplify even further by removing all of the superfluous task completion sources
  Bartłomiej Dach · 2025-04-22 13:28:42 +02:00
  4979dd86af
• Add basic support for beatmap updates in BeatmapCarousel
  Dean Herbert · 2025-04-22 20:03:07 +09:00
  6f97667889
• Change equality to allow non-reference comparisons

  This is required to hold selection when beatmaps are updates, as one
  important case.

  Dean Herbert · 2025-04-22 20:03:07 +09:00
  ac67473433
• Add test coverage of carousel update scenarios
  Dean Herbert · 2025-04-22 20:03:06 +09:00
  3472b6af91
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7