osu-lazer

Merge pull request #36500 from peppy/playlist-ssv2-all-mods-display

Fix "ALL MODS" display not displaying in new playlist song select

Bartłomiej Dach · 2026-01-28 09:39:35 +01:00

02fbcaba23

Remove leaking knowledge of freestyle in normal song select component

Dean Herbert · 2026-01-28 16:37:39 +09:00

ca7b850c8c

Merge pull request #36499 from peppy/fix-dropdown-animations

Fix dropdown margins and animations being weird

Bartłomiej Dach · 2026-01-28 08:09:40 +01:00

88e5ac4834

Limit maximum size of mod tooltip to avoid it going offscreen

Dean Herbert · 2026-01-28 16:08:02 +09:00

b9d5606fd4

Combine implementation of mods text drawable

I don't want to have to update things in multiple places with different
code in each place.

This also closes https://github.com/ppy/osu/issues/36412.

Dean Herbert · 2026-01-28 16:02:14 +09:00

c8c91cedfa

Fix mod count overlay flashing when switching freestyle on and off

Dean Herbert · 2026-01-28 15:01:23 +09:00

0c90cf3cef

Fix "ALL MODS" display not displaying in new playlist song select

Closes https://github.com/ppy/osu/issues/36411.

Dean Herbert · 2026-01-28 14:42:41 +09:00

1a0193001d

Fix dropdown margins and animations being weird

This was attempted to be fixed by frenzibyte using some hack workaround
logic, but this is the true fix.

Things were never matching due to `UpdateSize` spamming `Resize`
transforms every frame, causing the fade out to complete before
transforms have reached a final state.

Dean Herbert · 2026-01-28 14:22:41 +09:00

6bdb0e1cbb

Remove workaround for dropdowns animating weirdly

Dean Herbert · 2026-01-28 14:22:31 +09:00

0d3b7ab6be

Merge pull request #36486 from peppy/ui-tweaking

First pass adjustments to new settings design

Bartłomiej Dach · 2026-01-27 14:33:25 +01:00

2026.128.0-tachyon cffeb92248

Fix panel expansion not being set on initial song select load (#36456 )

Closes #36445.

Fixes a regression from #36404

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Eeli Ogata · 2026-01-27 14:32:51 +01:00

2c56419fe9

Apply extracted background in one more location

Bartłomiej Dach · 2026-01-27 12:09:31 +01:00

add67b95c7

Add insult to injury for autosize workaround

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-01-27 19:58:45 +09:00

6fad798227

Add localisation support for "Device:" prefix

Dean Herbert · 2026-01-27 19:03:23 +09:00

60690cbccc

Add back FinishTransforms at what cost

Dean Herbert · 2026-01-27 19:02:28 +09:00

6329e3ee1b

Use enum for background states

Dean Herbert · 2026-01-27 18:58:03 +09:00

fa22d1f202

Remove unnecessary depth change

Dean Herbert · 2026-01-27 18:51:04 +09:00

12eeab581e

Fix mismatching spacing in dropdown form menus

Dean Herbert · 2026-01-27 18:49:53 +09:00

b5e93b98c9

Fix revert button not always matching control's size

Dean Herbert · 2026-01-27 18:36:49 +09:00

786ea35274

Fix border showing for inner text boxes incorrectly

I turned masking back on on these for better visuals (text masking
aligns with rest of elements) but turns out this implicitly makes
borders draw.

Dean Herbert · 2026-01-27 18:36:37 +09:00

d6bf4fd90d

Adjust paddings to give more width to settings

Dean Herbert · 2026-01-27 17:43:28 +09:00

c407e07514

Adjust size and icon of revert-to-default button

Dean Herbert · 2026-01-27 17:06:15 +09:00

ed0051d119

Make binding configuration button bigger

It's one of the more important sections so I want to make it easier to
find.

Dean Herbert · 2026-01-27 17:06:14 +09:00

99ea19d55c

Standardise hover sounds for form elements

Closes #36444.

Dean Herbert · 2026-01-27 17:06:14 +09:00

dba17b1fa6

Add prefix for input device header

Dean Herbert · 2026-01-27 17:06:13 +09:00

fdf28474bf

Standardise animations

Dean Herbert · 2026-01-27 17:06:13 +09:00

42dc73d849

Various metrics and visual tweaks

Dean Herbert · 2026-01-27 17:06:13 +09:00

6983227240

Fix button spacing being weirdly small

Dean Herbert · 2026-01-27 17:06:12 +09:00

585ce682ef

Fix revert button height

Dean Herbert · 2026-01-27 17:06:12 +09:00

3db3b603bc

Make switch buttons look more like old version

Dean Herbert · 2026-01-27 17:06:11 +09:00

1c537a3278

Standardise background across form controls

Dean Herbert · 2026-01-27 17:06:11 +09:00

c88f10ca1b

Increase size of caption text

Dean Herbert · 2026-01-27 03:04:45 +09:00

7fef2ce1de

Remove enabled/disabled text from FormCheckbox

Dean Herbert · 2026-01-27 03:04:45 +09:00

9a5fd0addb

Adjust tooltip response speed and avoid using per-frame transforms

Dean Herbert · 2026-01-27 03:04:45 +09:00

9c0b1a4914

Fix logs failing to export after multiple failure attempts on file locks (#36469 )

Even if one file fails, we usually don't care and still want the archive
to finish exporting.

Closes https://github.com/ppy/osu/issues/36446

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dean Herbert · 2026-01-26 10:10:04 +01:00

acdb4477f7

Merge pull request #36471 from peppy/fix-previous-username-depth

Fix previous usernames display showing underneath other elements

Dean Herbert · 2026-01-26 10:09:39 +01:00

4ff29339ed

Apply new inspections from 2026.1EAP1

Nothing really egregious here so not bothering with PR review. One dodgy
bug which has been
[reported](https://youtrack.jetbrains.com/issue/RIDER-135036/Incorrect-recursive-on-all-execution-paths-inspection)
and temporarily ignored.

Dean Herbert · 2026-01-26 15:12:52 +09:00

f1f4a0001b

Move Traceable to difficulty increasing mods section (#35500 )

TC is a mod that always increases difficulty and is quite similar to HD.
Given we even have diffcalc/pp considerations for it it's time to move
it to the category it belongs.

This doesn't cover any other mods that might need reshuffling too
because TC is the only one that has actual impact on difficulty-based
leaderboards (as in pp) and some people are actively playing it for the
difficulty increase and not just as a fun gimmick.

After a quick search turns out it was difficulty increasing from the
start but was moved to fun in review
https://github.com/ppy/osu/pull/3569#discussion_r300085523 but I don't
really agree with that.

Also as far as I know multimods don't do anything anymore?.. I've put it
into HD multimod for consistency, but can move it to be separate if you
want

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

StanR · 2026-01-25 20:30:01 +09:00

df1dc46603

Fix score tooltips being displayed when hovering freemods status bar on PlaylistsSSV2 (#36413 )

- similar to https://github.com/ppy/osu/pull/36332

Denis Titovets · 2026-01-24 00:10:04 +09:00

2026.124.0-tachyon 84ec4bb866

Merge pull request #36438 from bdach/bypass-test-fails-slider-bar

Work around flaky `TestSceneFirstRunSetupOverlay` tests

Dean Herbert · 2026-01-24 00:01:56 +09:00

9f0f9ef229

Merge pull request #36439 from bdach/late-firing-realm-subs

Locally schedule beatmap skin change callbacks to ensure they fire at valid times

Dean Herbert · 2026-01-23 23:58:13 +09:00

290b141d8f

Merge pull request #36436 from peppy/legacy-health-wrong-flash-texture

Fix legacy health display using incorrect bulge texture when at low HP

Bartłomiej Dach · 2026-01-23 14:01:58 +01:00

7cc025d8f4

Locally schedule beatmap skin change callbacks to ensure they fire at valid times

See CI failures like
https://github.com/ppy/osu/actions/runs/21238110652/job/61110112412?pr=36404#step:5:21.

Hopefully works this time.

Bartłomiej Dach · 2026-01-23 13:41:44 +01:00

978fc91b09

Add some more extra test coverage

Bartłomiej Dach · 2026-01-23 13:18:48 +01:00

259c5708f1

Work around flaky TestSceneFirstRunSetupOverlay tests

See inline commentary. I don't really have any energy left to provide
anything else, other than maybe a demonstration of how this dies in
framework:

diff --git a/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs b/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs
new file mode 100644
index 000000000..c74ce6636
--- /dev/null
+++ b/osu.Framework.Tests/Visual/UserInterface/TestSceneScreenStackUnbindOnExit.cs
@@ -0,0 +1,59 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using NUnit.Framework;
+using osu.Framework.Allocation;
+using osu.Framework.Graphics.UserInterface;
+using osu.Framework.Screens;
+
+namespace osu.Framework.Tests.Visual.UserInterface
+{
+    public partial class TestSceneScreenStackUnbindOnExit : FrameworkTestScene
+    {
+        [Cached]
+        private ScreenStack screenStack = new ScreenStack();
+
+        [Test]
+        public void TestScreenExitUnbindDoesNotInterruptLoadComplete()
+        {
+            AddStep("set up the scenario", () =>
+            {
+                Child = screenStack;
+                screenStack.Push(new Screen());
+                screenStack.Push(new BrokenScreen());
+            });
+            AddUntilStep("wait to get to target screen", () => screenStack.CurrentScreen, Is.InstanceOf<Screen>);
+        }
+
+        private partial class BrokenSlider : BasicSliderBar<float>
+        {
+            [Resolved]
+            private ScreenStack screenStack { get; set; } = null!;
+
+            protected override void LoadComplete()
+            {
+                // exiting the current screen provokes the behaviour of unbinding all bindables in the screen's subtree
+                screenStack.CurrentScreen.Exit();
+
+                // ...but the following calls should still take correct effect inside `SliderBar`
+                // (namely one consisting of propagating `{Min,Max}Value` into `currentNumberInstantaneous`)
+                // so that it doesn't have its internal invariants violated
+                CurrentNumber.MinValue = -10;
+                CurrentNumber.MaxValue = 10;
+
+                // this notably calls `Scheduler.AddOnce(updateValue)` inside, which will happen *in the imminent future, in the same frame as `LoadComplete()` here.
+                // if the above mutations of `{Min,Max}Value` don't correctly propagate inside the slider bar due to an overly eager unbind, this will cause a crash.
+                base.LoadComplete();
+            }
+        }
+
+        private partial class BrokenScreen : Screen
+        {
+            [BackgroundDependencyLoader]
+            private void load()
+            {
+                InternalChild = new BrokenSlider();
+            }
+        }
+    }
+}

I attempted to address what I perceive to be the root issue here which
is that `ScreenStack` is allowed to arbitrarily unbind bindables under
drawables which are by all means still in the scene graph. The attempt
consisted of scheduling the unbind until after children of the screen
stack, but that caused 150 game-side tests to fail, seemingly on
something relevant to bindable leases, so I give up.

Bartłomiej Dach · 2026-01-23 13:07:42 +01:00

b7559f93f2

Update resources

Dean Herbert · 2026-01-23 17:44:17 +09:00

c2604e22c7

Merge pull request #36435 from bdach/sigh

Fix broken percentage formatting in form slider bars

Dean Herbert · 2026-01-23 17:17:20 +09:00

dddd75b7f9

Fix legacy health display using incorrect bulge texture when at low HP

Closes #36432.

Dean Herbert · 2026-01-23 17:10:35 +09:00

d3c9548b52

Fix broken percentage formatting in form slider bars

closes https://github.com/ppy/osu/issues/36428

this one's my bad:
https://github.com/ppy/osu/pull/36195#discussion_r2698388405

Bartłomiej Dach · 2026-01-23 08:01:41 +01:00

225f4d8814

Add failing tests

Bartłomiej Dach · 2026-01-23 07:50:20 +01:00

d80934c344

76441 Commits