1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 13:22:55 +08:00
Commit Graph

57624 Commits

Author SHA1 Message Date
Bartłomiej Dach
006ed6dae4
Merge pull request #21730 from peppy/ui-scale-only-show-one-screen
Only show song select for now at ui scale adjust first run screen
2022-12-20 19:12:01 +01:00
Bartłomiej Dach
bf074adb13
Remove unused using directive 2022-12-20 18:24:26 +01:00
Bartłomiej Dach
8ead606065
Merge branch 'master' into ui-scale-only-show-one-screen 2022-12-20 18:23:37 +01:00
Bartłomiej Dach
a0e9004655
Merge pull request #21731 from peppy/fix-stuck-file-select-overlay
Fix file select popup getting stuck when switching first run screens while selecting
2022-12-20 18:17:28 +01:00
wiskerz76
439b8ac56a Fix file select popup getting stuck when switching first run screens while selecting
Closes #21663
Supersedes #21724
2022-12-20 17:59:23 +09:00
Dean Herbert
c119d41a2d Only show song select for now at ui scale adjust first run screen
Having both was a bit too much. Still not happy with this but it's a bit
less sensory overload.

I think while it's cool being able to show nested screens like this, it
needs more thought to actually be a good experience.
2022-12-20 17:52:56 +09:00
Dean Herbert
ca8d2bec9d
Merge pull request #21723 from bdach/wiki-heading-id-attributes
Add support for block attributes in wiki overlay
2022-12-20 15:16:08 +09:00
Bartłomiej Dach
64a45aa0e0
Merge branch 'master' into wiki-heading-id-attributes 2022-12-20 06:34:47 +01:00
Dean Herbert
66364afe04
Merge pull request #21722 from bdach/markdown-footnote-support
Add Markdown footnote support to wiki overlay
2022-12-20 14:21:03 +09:00
Dean Herbert
4a9b58adda
Merge branch 'master' into markdown-footnote-support 2022-12-20 13:48:35 +09:00
Dean Herbert
f117f76b2f
Merge pull request #21718 from bdach/fix-welcome-screen-buttons
Fix welcome screen language buttons not working
2022-12-20 13:16:19 +09:00
Dean Herbert
2ed1a95975
Merge pull request #21716 from Susko3/remove-Linker.xml 2022-12-20 10:20:35 +09:00
Bartłomiej Dach
30b9f5d92e
Add test coverage for correct operation of flag extension 2022-12-19 21:32:41 +01:00
Bartłomiej Dach
7c282d9def
Enable generic attribute support for wiki markdown containers 2022-12-19 21:32:38 +01:00
Bartłomiej Dach
12aa2e96db
Add test case covering failure 2022-12-19 21:29:10 +01:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management 2022-12-19 20:19:51 +01:00
Bartłomiej Dach
a88812861e
Implement bidirectional footnote link navigation 2022-12-19 19:34:47 +01:00
Bartłomiej Dach
5fb2a83f12
Add failing test case for footnote link navigation 2022-12-19 19:34:45 +01:00
Bartłomiej Dach
3c1a46605e
Set up test for two-way navigation testing 2022-12-19 19:34:42 +01:00
Bartłomiej Dach
73a4310935
Add styling for footnote groups 2022-12-19 19:34:40 +01:00
Bartłomiej Dach
112613c2f0
Add styling for footnote links 2022-12-19 19:28:01 +01:00
Bartłomiej Dach
6e55f2f779
Add test for markdown footnotes 2022-12-19 19:17:05 +01:00
Bartłomiej Dach
0dce899634
Throw on OsuClickableContainer.ClearInternal() invocations
As they may cause critical failure due to getting rid of the `Content`.
2022-12-19 18:25:45 +01:00
Bartłomiej Dach
186ccc64fd
Fix welcome screen language buttons not working 2022-12-19 18:19:26 +01:00
Susko3
36c620287b Remove no longer needed Linker.xml configurations for mobile projects 2022-12-19 18:11:05 +01:00
Bartłomiej Dach
b42accb763
Merge pull request #21711 from peppy/update-framework-standardise
Update framework (again) and remove some no-longer required workarounds
2022-12-19 18:03:00 +01:00
Salman Ahmed
d47a8b2e26 Remove unnecessary discard 2022-12-19 18:42:51 +03:00
Salman Ahmed
2249c97a6f Pin certain system package versions to avoid downgrade errors 2022-12-19 18:27:32 +03:00
Salman Ahmed
396ac0436c Remove automatically provided workaround 2022-12-19 18:24:46 +03:00
Dean Herbert
ecac6299c6 Update framework 2022-12-19 22:01:20 +09:00
Dean Herbert
99ad78cdd6 Remove no longer necessary workarounds from mobile props files 2022-12-19 22:01:13 +09:00
Dean Herbert
12c77cca26 Remove rollForward rule for now 2022-12-19 21:54:33 +09:00
Dan Balasescu
1262c44dfb
Merge pull request #21629 from peppy/guard-url-protocols
Update framework
2022-12-19 21:27:44 +09:00
Dean Herbert
4a7d7c6ed9 Use MaxBy in all locations that can and update inspection level to match dotnet-build 2022-12-19 16:47:10 +09:00
Dean Herbert
8a01a22612 Fix two null refrences in OsuGame 2022-12-19 16:47:10 +09:00
Dean Herbert
d3995693a0 Use maui-android 2022-12-19 16:47:10 +09:00
Dean Herbert
877413524f Cherry-picked android changes from #17462 2022-12-19 15:46:54 +09:00
Dean Herbert
b64a5cbda6 Merge branch 'master' into guard-url-protocols 2022-12-19 15:46:45 +09:00
Dan Balasescu
ef7da449b7
Merge pull request #21707 from Joehuu/fix-comment-actions-casing
Fix some comment actions not being lowercased
2022-12-19 15:31:54 +09:00
Joseph Madamba
8d83c78810 Fix casing on comment actions test 2022-12-18 21:12:38 -08:00
Joseph Madamba
6e62033bc4 Fix some comment actions not being lowercased 2022-12-18 20:20:15 -08:00
Dean Herbert
e2d68f6ea9
Merge pull request #21686 from bdach/spectator-end-playing-on-completion
Call spectator `EndPlaying()` immediately after score submission
2022-12-18 13:26:47 +09:00
Bartłomiej Dach
fea0895f16
Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
Salman Ahmed
4dbc1c3cb0 Manually use Xcode 14.1 2022-12-17 03:30:25 +03:00
Salman Ahmed
d74478ce3b Pin workflow to macOS 12 2022-12-17 03:00:59 +03:00
Salman Ahmed
64e0e6f096
Merge pull request #21667 from bdach/fix-wrong-macos-logs-path
Fix wrong paths to macOS log folder in docs
2022-12-16 19:20:51 +03:00
Salman Ahmed
00bae8fab9 Fix slight mistake in path 2022-12-16 18:44:23 +03:00
Bartłomiej Dach
190e7acd39
Fix wrong paths to macOS log folder in docs
Wrong since 2eb1c60d6e72d8b2c478cf4376470ca614ef3f88.
2022-12-16 16:37:38 +01:00
Dean Herbert
192536643c Fix some more inspections 2022-12-16 20:21:19 +09:00
Dean Herbert
dd9a418549 Fix assembly location lookups 2022-12-16 19:19:59 +09:00