1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-13 18:47:27 +08:00
osu-lazer/osu.Game
Bartłomiej Dach fea0895f16
Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
..
Audio Fix disposal of playing preview track not unmuting game track 2022-12-05 14:45:32 +03:00
Beatmaps Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
Collections Partial everything 2022-11-27 00:00:27 +09:00
Configuration Turn on featured artist filter by default and add disclaimer when toggling for the first time 2022-12-15 18:42:47 +09:00
Database Fix some hard links not being created due to missing directory structure 2022-12-15 14:17:28 +09:00
Extensions Fix parsing of Language when using default system locale 2022-11-10 22:56:24 +01:00
Graphics Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
Input Partial everything 2022-11-27 00:00:27 +09:00
IO Add SetLastError hint to CreateHardLink pinvoke method 2022-12-14 11:34:06 +09:00
IPC Handle osu:// scheme links via IPC in desktop game 2022-06-20 21:26:22 +02:00
Localisation Merge pull request #21628 from peppy/go-hard-file-writes 2022-12-16 14:52:57 +09:00
Models Use Unknown instead of default 2022-07-18 16:24:08 +09:00
Online Use LocalisableStrings for date and time formats 2022-12-16 00:05:47 +01:00
Overlays Merge pull request #21654 from Susko3/use-localisable-strings-for-dates-and-times 2022-12-16 16:17:14 +09:00
Performance Partial everything 2022-11-27 00:00:27 +09:00
Properties Automated #nullable processing 2022-06-17 16:37:17 +09:00
Replays Show smoke in replays 2022-09-18 17:55:06 -07:00
Rulesets Merge pull request #21587 from smoogipoo/spectatorstate-maximum-statistics 2022-12-12 20:00:52 +09:00
Scoring Merge pull request #21628 from peppy/go-hard-file-writes 2022-12-16 14:52:57 +09:00
Screens Call spectator EndPlaying() immediately after score submission 2022-12-17 21:35:43 +01:00
Skinning Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
Storyboards Partial everything 2022-11-27 00:00:27 +09:00
Tests Move score token to BeginPlaying 2022-12-12 13:59:27 +09:00
Updater Partial everything 2022-11-27 00:00:27 +09:00
Users Partial everything 2022-11-27 00:00:27 +09:00
Utils Extract common part of regex to separate method 2022-12-03 16:59:43 +01:00
.editorconfig Add localisation length hinting 2022-04-28 19:26:28 +09:00
BackgroundBeatmapProcessor.cs Partial everything 2022-11-27 00:00:27 +09:00
osu!.res
osu.Game.csproj Bump Newtonsoft.Json from 13.0.1 to 13.0.2 in /osu.Game 2022-12-08 05:38:06 +00:00
OsuGame.cs Hook up ImportParameter flow with IModelImporter caller methods 2022-12-13 21:29:32 +09:00
OsuGameBase_Importing.cs Move ImportParameters to better home 2022-12-13 21:41:26 +09:00
OsuGameBase.cs Clamp SFX panning on results screen 2022-12-16 17:19:07 +09:00
PerformFromMenuRunner.cs Partial everything 2022-11-27 00:00:27 +09:00