mirror of
https://github.com/ppy/osu.git
synced 2026-05-13 20:33:35 +08:00
Bartłomiej Dach
c2b96eb0f2
Closes https://github.com/ppy/osu/issues/37715. The user's database contains several scores in which `ScoreInfo.Ruleset` is null. How this happened, I'm not sure, it's probably custom rulesets. The proper way to handle this would be to mark `ScoreInfo.Ruleset` as nullable and deal with the hundred files of fallout, and also the fact that `ScoreInfo` is an overloaded mess of a model that is sometimes a database model and sometimes a post-converted online structure with things backfilled to fit and I'm just not wanting to waste a week here, so I'm choosing to look away. Sidebar: You can't just put a null-propagating operator in the previous conditional too because analysers will scream that `Ruleset` can't *possibly* be null! So this uses `RulesetInfo.Equals(RulesetInfo?)` because that can sorta-kinda handle nulls.
c2b96eb0f2
·
2026-05-12 15:39:00 +09:00
History