1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-21 08:32:54 +08:00
osu-lazer/osu.Game/Online/Rooms
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
RoomStatuses Better signify private rooms by showing a different status pill design 2024-05-03 17:17:35 +08:00
APICreatedRoom.cs Remove unnecessary CQ disable 2022-11-29 14:45:08 +09:00
APILeaderboard.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
APIScoreToken.cs Automated pass 2023-06-24 01:00:03 +09:00
BeatmapAvailability.cs Force a beatmap availability state change when selected item is changed 2023-06-28 16:02:46 +09:00
CreateRoomRequest.cs Automated pass 2023-06-24 01:00:03 +09:00
CreateRoomScoreRequest.cs Add additional gameplay metadata to room score request 2024-02-10 17:20:17 +09:00
GetRoomLeaderboardRequest.cs Automated pass 2023-06-24 01:00:03 +09:00
GetRoomRequest.cs Automated pass 2023-06-24 01:00:03 +09:00
GetRoomsRequest.cs Better signify private rooms by showing a different status pill design 2024-05-03 17:17:35 +08:00
IndexedMultiplayerScores.cs Make score type consistent 2022-11-06 19:59:27 -03:00
IndexPlaylistScoresRequest.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
IndexScoresParams.cs Automated pass 2023-06-24 01:00:03 +09:00
ItemAttemptsCount.cs Automated pass 2023-06-24 01:00:03 +09:00
JoinRoomRequest.cs Fix some more missed CI inspections 2023-06-24 17:11:38 +02:00
MatchType.cs Automated pass 2023-06-24 01:00:03 +09:00
MultiplayerPlaylistItem.cs Remove constructor from MultiplayerPlaylistItem which is only used in tests 2023-05-25 20:09:40 +09:00
MultiplayerScore.cs Use ID rather than SoloScoreID 2023-10-16 12:02:55 +02:00
MultiplayerScores.cs Automated pass 2023-06-24 01:00:03 +09:00
MultiplayerScoresAround.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
OnlinePlayBeatmapAvailabilityTracker.cs Make SelectedItem externally mutable 2024-06-10 12:44:38 +02:00
PartRoomRequest.cs Automated pass 2023-06-24 01:00:03 +09:00
PlaylistAggregateScore.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
PlaylistExtensions.cs Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
PlaylistItem.cs Copy StarRange when creating PlaylistItem 2023-05-14 12:08:37 +02:00
Room.cs Add start date to Room 2024-06-12 11:43:18 +02:00
RoomAvailability.cs Automated pass 2023-06-24 01:00:03 +09:00
RoomCategory.cs Add client/server models & operations for "daily challenge" feature 2024-05-17 10:58:08 +02:00
RoomStatus.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
ShowPlaylistUserScoreRequest.cs Automated pass 2023-06-24 01:00:03 +09:00
SubmitRoomScoreRequest.cs Automated pass 2023-06-24 01:00:03 +09:00
SubmitScoreRequest.cs Automated pass 2023-06-24 01:00:03 +09:00