1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 01:23:05 +08:00
osu-lazer/osu.Game/Screens/OnlinePlay/Playlists
Bartłomiej Dach 0d2a47167c
Fix crash on calculating playlist duration when rate-changing mods are present
Regressed in https://github.com/ppy/osu/pull/28399.

To reproduce, enter a playlist that has an item with a rate-changing mod
(rather than create it yourself).

This is happening because `APIRuleset` has `CreateInstance()`
unimplemented:

    b4cefe0cc2/osu.Game/Online/API/Requests/Responses/APIBeatmap.cs (L159)

and only triggers when the playlist items in question originate from
web.

This is why it is bad to have interface implementations throw outside of
maybe mock implementations for tests. `CreateInstance()` is a scourge
elsewhere in general, we need way less of it in the codebase (because
while convenient, it's also problematic to implement in online contexts,
and also expensive because reflection).
2024-06-25 11:28:10 +02:00
..
CreatePlaylistsRoomButton.cs Automated pass 2023-06-24 01:00:03 +09:00
Playlists.cs Add button to access daily challenge playlist from main menu 2024-05-17 11:15:52 +02:00
PlaylistsLoungeSubScreen.cs Partial everything 2022-11-27 00:00:27 +09:00
PlaylistsPlayer.cs Show user statistics after completing a playlists / multiplayer score 2024-02-22 20:35:50 +01:00
PlaylistsReadyButton.cs Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
PlaylistsResultsScreen.cs Apply nullability annotations to ResultsScreen & inheritors 2024-04-25 10:58:28 +02:00
PlaylistsRoomFooter.cs Partial everything 2022-11-27 00:00:27 +09:00
PlaylistsRoomSettingsOverlay.cs Fix crash on calculating playlist duration when rate-changing mods are present 2024-06-25 11:28:10 +02:00
PlaylistsRoomSettingsPlaylist.cs Automated pass 2023-06-24 01:00:03 +09:00
PlaylistsRoomSubScreen.cs Change ResultsScreen constructor boolean params to init-only properties 2024-02-22 20:15:03 +01:00
PlaylistsSongSelect.cs Partial everything 2022-11-27 00:00:27 +09:00