1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 02:22:59 +08:00
osu-lazer/osu.Game/Screens/Play
Bartłomiej Dach fea0895f16
Call spectator EndPlaying() immediately after score submission
As it turns out, in current `master`, if a gameplay session ends
normally (i.e. by the player completing the beatmap in full), then
the spectator server `EndPlaying()` method will not be called until
`SubmittingPlayer.OnExiting()`, which in practice turns out to be
the moment where the user exits from the post-gameplay results screen
back to song select.

There is seemingly no reasonable cause for not calling this earlier. In
fact the solo spectator flow looks more broken without this call than
with, because without it the spectator view just hangs until the
spectated player exits gameplay, and *only then* shows results, rather
than do it upon normal gameplay completion.
2022-12-17 21:35:43 +01:00
..
Break Partial everything 2022-11-27 00:00:27 +09:00
HUD Partial everything 2022-11-27 00:00:27 +09:00
PlayerSettings Partial everything 2022-11-27 00:00:27 +09:00
BeatmapMetadataDisplay.cs Partial everything 2022-11-27 00:00:27 +09:00
BreakOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
BreakTracker.cs Partial everything 2022-11-27 00:00:27 +09:00
ComboEffects.cs Partial everything 2022-11-27 00:00:27 +09:00
DimmableStoryboard.cs Partial everything 2022-11-27 00:00:27 +09:00
EpilepsyWarning.cs Partial everything 2022-11-27 00:00:27 +09:00
FailAnimation.cs Partial everything 2022-11-27 00:00:27 +09:00
FailOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
GameplayClockContainer.cs Partial everything 2022-11-27 00:00:27 +09:00
GameplayClockExtensions.cs Rename GameplayAdjustments -> AdjustmentsFromMods 2022-09-08 17:14:06 +09:00
GameplayMenuOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
GameplayState.cs Fix TestSceneReplayRecorder not using score provided by gameplay state 2022-07-25 05:21:27 +03:00
HotkeyExitOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
HotkeyRetryOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
HUDOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
IGameplayClock.cs Rename GameplayAdjustments -> AdjustmentsFromMods 2022-09-08 17:14:06 +09:00
ILocalUserPlayInfo.cs Automated #nullable processing 2022-06-17 16:37:17 +09:00
KeyCounter.cs Partial everything 2022-11-27 00:00:27 +09:00
KeyCounterAction.cs Partial everything 2022-11-27 00:00:27 +09:00
KeyCounterDisplay.cs Partial everything 2022-11-27 00:00:27 +09:00
KeyCounterKeyboard.cs Partial everything 2022-11-27 00:00:27 +09:00
KeyCounterMouse.cs Partial everything 2022-11-27 00:00:27 +09:00
MasterGameplayClockContainer.cs Partial everything 2022-11-27 00:00:27 +09:00
OffsetCorrectionClock.cs Split OffsetCorrectionClock out of MasterGameplayClockContainer 2022-08-18 18:54:10 +09:00
PauseOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
Player.cs Partial everything 2022-11-27 00:00:27 +09:00
PlayerConfiguration.cs Ensure gameplay leaderboard hides with rest of HUD when it should 2022-09-13 18:45:11 +09:00
PlayerLoader.cs Partial everything 2022-11-27 00:00:27 +09:00
ReplayPlayer.cs Fix multiple instances of last hitobject time being calculated incorrectly 2022-12-01 18:04:06 +09:00
ReplayPlayerLoader.cs Partial everything 2022-11-27 00:00:27 +09:00
ResumeOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
RoomSubmittingPlayer.cs Partial everything 2022-11-27 00:00:27 +09:00
SaveFailedScoreButton.cs Partial everything 2022-11-27 00:00:27 +09:00
ScreenSuspensionHandler.cs Partial everything 2022-11-27 00:00:27 +09:00
ScreenWithBeatmapBackground.cs Partial everything 2022-11-27 00:00:27 +09:00
SkipOverlay.cs Partial everything 2022-11-27 00:00:27 +09:00
SoloPlayer.cs Partial everything 2022-11-27 00:00:27 +09:00
SoloSpectator.cs Merge branch 'master' into update-framework 2022-11-26 16:19:36 +01:00
SoloSpectatorPlayer.cs Partial everything 2022-11-27 00:00:27 +09:00
SpectatorPlayer.cs Partial everything 2022-11-27 00:00:27 +09:00
SpectatorPlayerLoader.cs Partial everything 2022-11-27 00:00:27 +09:00
SpectatorResultsScreen.cs Partial everything 2022-11-27 00:00:27 +09:00
SquareGraph.cs Partial everything 2022-11-27 00:00:27 +09:00
SubmittingPlayer.cs Call spectator EndPlaying() immediately after score submission 2022-12-17 21:35:43 +01:00