1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-18 12:02:57 +08:00
osu-lazer/osu.Game/Screens
Dean Herbert 520d2d6cfa Fix beatmap carousel panels accepting input while marked as not-visible
This is an issue as carousel panels manage their own animated state. If
they are marked as not-visible (done at a higher level, from filtering
or update pathways) but clicked while fading out, they will animate back
to a visible state but not be marked as visible.

No tests for this one as it's probably not worthwhile to test (and hard
to do so). Manual testing can be done with the following patch:

```diff
diff --git a/osu.Game/Screens/Select/BeatmapCarousel.cs
b/osu.Game/Screens/Select/BeatmapCarousel.cs
index c3d340ac61..3372242acc 100644
--- a/osu.Game/Screens/Select/BeatmapCarousel.cs
+++ b/osu.Game/Screens/Select/BeatmapCarousel.cs
@@ -255,7 +255,7 @@ private void
beatmapSetsChanged(IRealmCollection<BeatmapSetInfo> sender, ChangeS
             }

             foreach (int i in changes.NewModifiedIndices)
-                UpdateBeatmapSet(sender[i].Detach());
+                Scheduler.AddDelayed(() =>
                 UpdateBeatmapSet(sender[i].Detach()), 100, true);

             foreach (int i in changes.InsertedIndices)
                 UpdateBeatmapSet(sender[i].Detach());

```

- Enter gameplay and adjust beatmap offset then return to song select
  and click the flashing panel.
OR
- Enter editor and save then return to song select and click the
  flashing panel.

Closes https://github.com/ppy/osu/discussions/17171.
2022-03-09 16:08:52 +09:00
..
Backgrounds Fix BackgroundScreenDefault incorrectly updating current background after being inactive 2021-12-14 16:40:50 +09:00
Edit Allow tabbing between textboxes in sample point popover 2022-03-06 01:43:56 +01:00
Import Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Menu Use double instead of float for UIHoldActivationDelay configuration value 2022-03-04 12:22:56 +09:00
OnlinePlay Fix nullref in tests 2022-02-25 16:12:25 +09:00
Play Merge branch 'master' into realm-property-watching 2022-03-07 13:53:17 +09:00
Ranking Use const for minimum height specification in final usage location 2022-03-06 01:01:22 +09:00
Select Fix beatmap carousel panels accepting input while marked as not-visible 2022-03-09 16:08:52 +09:00
Spectate Clean up SpectatorScreen based on suggestions 2022-02-09 12:20:07 +09:00
BackgroundScreen.cs Fix background overflows 2021-08-20 17:50:49 +09:00
BackgroundScreenStack.cs Improve code around background screen handling to read better 2021-09-07 14:35:33 +09:00
IHandlePresentBeatmap.cs Remove explicit public definition 2021-03-03 19:03:45 +09:00
IHasSubScreenStack.cs Add the ability for PerformFromMenuRunner to inspect nested screen stacks 2021-02-19 17:58:04 +09:00
IOsuScreen.cs Move MusicController adjustment set to inside OsuScreen itself (and result nullable) 2021-09-16 16:08:09 +09:00
Loader.cs Allow realm migration to run again if interrupted halfway 2022-01-24 18:55:15 +09:00
OsuScreen.cs Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
OsuScreenDependencies.cs
OsuScreenStack.cs Fix the default background parallax being set incorrectly when no screen is present 2021-09-17 18:14:39 +09:00
ScorePresentType.cs Update class exclusion for dynamic compilation 2020-09-04 20:41:08 +09:00
ScreenWhiteBox.cs Remove redundant arguments 2021-07-05 23:52:39 +08:00
StartupScreen.cs Remove unnecessary AllowTrackAdjustments overrides, add true to SongSelect 2021-09-15 13:12:57 +03:00