1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-18 10:32:56 +08:00
osu-lazer/osu.Game.Modes.Taiko/Objects/Drawable
smoogipooo 5bd9147661 Remove CreateCircle() - hitobjects should handle the addition of this to their hierarchy themselves.
CreateCircle() lends itself to a few issues:
- It can't be used for drum roll ticks unless it returned a Container instead, at which point the method loses its meaning, and I would rather that constructed in the ctor.
- Writing `return Accented ? new AccentedCirclePiece() : new CirclePiece()` in two places as the body of this method feels wrong - it's something I would expect to be taken care of in the base DrawableTaikoHitObject, but that leads back to #1.
- Swells don't have an AccentedCirclePiece, so #2 becomes more problematic.
2017-03-25 20:53:45 +09:00
..
Pieces Make CirclePiece use relative width (leaving length control to DrawableDrumRoll). 2017-03-24 20:10:17 +09:00
DrawableDrumRoll.cs Make readonly. 2017-03-23 19:43:49 +09:00
DrawableDrumRollTick.cs Make readonly. 2017-03-23 19:43:49 +09:00
DrawableTaikoHitObject.cs Remove CreateCircle() - hitobjects should handle the addition of this to their hierarchy themselves. 2017-03-25 20:53:45 +09:00